Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-11 Thread David Howells
Tadeusz Struk wrote: > > Why didn't you put the RSA signature parsing - ie. where the OID and the > > other > > bits are checked - into crypto/rsa.c? > > > > Do you want to get rid of the crypto/asymmetric_keys/rsa.c completely? > I wanted to make the conversion churn

Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-11 Thread David Howells
David Howells wrote: > Tadeusz Struk wrote: > > > > Why didn't you put the RSA signature parsing - ie. where the OID and the > > > other > > > bits are checked - into crypto/rsa.c? > > > > > > > Do you want to get rid of the

[PATCH 3/3] crypto: add basic driver for the MXC SCC

2016-02-11 Thread Steffen Trumtrar
According to the Freescale GPL driver code, there are two different Security Controller (SCC) versions: SCC and SCC2. The SCC is found on older i.MX SoCs, e.g. the i.MX25. This is the version implemented and tested here. As there is no publicly available documentation for this IP core, all

[PATCH 2/3] ARM: i.MX25: add scc module to dtsi

2016-02-11 Thread Steffen Trumtrar
Add the Security Controller (SCC) module to the dtsi. Signed-off-by: Steffen Trumtrar --- arch/arm/boot/dts/imx25.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index

[PATCH 1/3] Documentation: devicetree: add Freescale SCC bindings

2016-02-11 Thread Steffen Trumtrar
Add documentation for the Freescale Security Controller (SCC) found on i.MX25 SoCs. Signed-off-by: Steffen Trumtrar --- .../devicetree/bindings/crypto/fsl-imx-scc.txt | 17 + 1 file changed, 17 insertions(+) create mode 100644

[PATCH] X.509: Fix test for self-signed certificate

2016-02-11 Thread Michal Marek
If either the Subject + subjectKeyId or the Issuer + Serial number differs between the certificate and the CA, the certificate is not self-signed. In practice, both will be equal for self-signed certificates and both will differ for CA-signed certificates. It is only an issue if the CA used the

Re: [PATCH 3/3] crypto: add basic driver for the MXC SCC

2016-02-11 Thread Lothar Waßmann
Hi, On Thu, 11 Feb 2016 15:04:45 +0100 Steffen Trumtrar wrote: > According to the Freescale GPL driver code, there are two different > Security Controller (SCC) versions: SCC and SCC2. > > The SCC is found on older i.MX SoCs, e.g. the i.MX25. This is the > version implemented and tested here. >