Re: [PATCH v2 1/4] scatterlist: Introduce some helper functions

2016-04-20 Thread Baolin Wang
Hi Robert, On 5 April 2016 at 15:10, Baolin Wang wrote: > Hi Robert, > > Sorry for the late reply. > > On 2 April 2016 at 23:00, Robert Jarzmik wrote: >> Baolin Wang writes: >> >>> +/** >>> + * sg_is_contiguous - Check if the scatterlists are contiguous >>> + * @sga: SG entry >>> + * @sgb: SG e

Re: [PATCH v2 1/4] scatterlist: Introduce some helper functions

2016-04-20 Thread Herbert Xu
On Wed, Apr 20, 2016 at 03:34:47PM +0800, Baolin Wang wrote: > It seems there are no more comments about this patchset? We really > want to these APIs to coalesce scatterlists to improve the crypto > engine efficiency. Thanks. Your patch-set makes no sense. If the data can be coalesced then it sh

Crypto Fixes for 4.6

2016-04-20 Thread Herbert Xu
Hi Linus: This push fixes the following issues: - Incorrect output buffer size calculation in rsa-pkcs1pad. - Uninitialised padding bytes on exported state in ccp driver. - Potentially freed pointer used on completion callback in sha1-mb. Please pull from git://git.kernel.org/pub/scm/linux/ker

Re: crash in ppc4xx-rng on canyonland

2016-04-20 Thread Herbert Xu
On Mon, Apr 18, 2016 at 01:42:49PM +0200, Christian Lamparter wrote: > > what else I fixed in v1->v2: > - added a check to test trng device's status state with >of_device_is_available. > - if the hwrng device registration failed, the flag which >enables the trng was left enabled (note: t

Re: [PATCH v3] crypto: ccp - Register the CCP as a DMA resource

2016-04-20 Thread Herbert Xu
On Mon, Apr 18, 2016 at 09:21:44AM -0500, Gary R Hook wrote: > The CCP has the ability to provide DMA services to the > kernel using pass-through mode of the device. Register > these services as general purpose DMA channels. > > Changes since v2: > - Add a Signed-off-by Applied. -- Email: Herber

Re: [PATCH 0/2] crypto: talitos - fix conversion to new AEAD interface

2016-04-20 Thread Herbert Xu
On Tue, Apr 19, 2016 at 08:33:46PM +0300, Horia Geantă wrote: > Jonas Eymann reports a crash and some failures of AED algorithms > with kernel 4.4.6, all easily reproducible with tcrypt. > > These have to do with the onversion to the new AEAD interface: > aeb4c132f33d crypto: talitos - Convert to

Re: [PATCH 1/2] crypto: s5p-sss - Fix use after free of copied input buffer in error path

2016-04-20 Thread Herbert Xu
On Tue, Apr 19, 2016 at 03:44:11PM +0200, Krzysztof Kozlowski wrote: > The driver makes copies of memory (input or output scatterlists) if they > are not aligned. In s5p_aes_crypt_start() error path (on unsuccessful > initialization of output scatterlist), if input scatterlist was not > aligned, th

Re: [PATCH] crypto: marvell/cesa: Improving code readability

2016-04-20 Thread Herbert Xu
Romain Perier wrote: > When looking for available engines, the variable "engine" is > assigned to "&cesa->engines[i]" at the beginning of the for loop. Replacing > next occurences of "&cesa->engines[i]" by "engine" and in order to improve > readability. > > Signed-off-by: Romain Perier Applied.

Re: [PATCH 2/2] crypto: s5p-sss - Remove useless hash interrupt handler

2016-04-20 Thread Vladimir Zapolskiy
On 19.04.2016 16:44, Krzysztof Kozlowski wrote: > Beside regular feed control interrupt, the driver requires also hash > interrupt for older SoCs (samsung,s5pv210-secss). However after > requesting it, the interrupt handler isn't doing anything with it, not > even clearing the hash interrupt bit. >

Re: [PATCH 1/2] crypto: s5p-sss - Fix use after free of copied input buffer in error path

2016-04-20 Thread Vladimir Zapolskiy
Hi Krzysztof, On 19.04.2016 16:44, Krzysztof Kozlowski wrote: > The driver makes copies of memory (input or output scatterlists) if they > are not aligned. In s5p_aes_crypt_start() error path (on unsuccessful > initialization of output scatterlist), if input scatterlist was not > aligned, the driv

[cryptodev:master 56/59] warning: (RAPIDIO_DMA_ENGINE && ..) selects DMA_ENGINE which has unmet direct dependencies (DMADEVICES)

2016-04-20 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 21ec757d2dd8650f978d27ad53cb1fcca8bb5e2b commit: 58ea8abf490415c390e0cc671e875510c9b66318 [56/59] crypto: ccp - Register the CCP as a DMA resource config: i386-randconfig-x018-201616 (attached as .con

Re: [PATCH 0/2] crypto: talitos - fix conversion to new AEAD interface

2016-04-20 Thread Horia Ioan Geanta Neag
On 4/20/2016 12:58 PM, Herbert Xu wrote: > On Tue, Apr 19, 2016 at 08:33:46PM +0300, Horia Geantă wrote: >> Jonas Eymann reports a crash and some failures of AED algorithms >> with kernel 4.4.6, all easily reproducible with tcrypt. >> >> These have to do with the onversion to the new AEAD interface

Re: [PATCH 0/2] crypto: talitos - fix conversion to new AEAD interface

2016-04-20 Thread Jonas Eymann
sorry for the late reply, I was out of office. Thank you very much Horia for fixing the typo, adding the sign-off and also for the second patch. I'll also run some tests when I find the time to see how everything works together. Jonas > Gesendet: Mittwoch, 20. April 2016 um 11:58 Uhr > Von: "He

AEAD in TALITOS SEC1 versus TALITOS SEC2

2016-04-20 Thread Christophe Leroy
Today, in Talitos driver crypto alg registration is based on predefined templates with a predefined descriptor type and verification against the descriptors supported by the HW. This works well for ALG that require a unique descriptor. But for IPsec this is slightly different: * IPsec can be per

[cryptodev:master 56/59] undefined reference to `dma_request_slave_channel'

2016-04-20 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 21ec757d2dd8650f978d27ad53cb1fcca8bb5e2b commit: 58ea8abf490415c390e0cc671e875510c9b66318 [56/59] crypto: ccp - Register the CCP as a DMA resource config: x86_64-randconfig-a0-04201917 (attached as .c

[cryptodev:master 56/59] ccp-dmaengine.c:undefined reference to `dma_run_dependencies'

2016-04-20 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 21ec757d2dd8650f978d27ad53cb1fcca8bb5e2b commit: 58ea8abf490415c390e0cc671e875510c9b66318 [56/59] crypto: ccp - Register the CCP as a DMA resource config: i386-randconfig-h0-04201912 (attached as .con

[PATCH] crypto: ccp - Ensure all dependencies are specified

2016-04-20 Thread Gary R Hook
A DMA_ENGINE requires DMADEVICES in Kconfig Signed-off-by: Gary R Hook --- drivers/crypto/ccp/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig index 79cabfb..2238f77 100644 --- a/drivers/crypto/ccp/Kconfig +++ b/drivers/crypto

Re: [cryptodev:master 56/59] warning: (RAPIDIO_DMA_ENGINE && ..) selects DMA_ENGINE which has unmet direct dependencies (DMADEVICES)

2016-04-20 Thread Gary R Hook
On 04/20/2016 05:35 AM, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 21ec757d2dd8650f978d27ad53cb1fcca8bb5e2b commit: 58ea8abf490415c390e0cc671e875510c9b66318 [56/59] crypto: ccp - Register the CCP as a DMA resource co