Re: [PATCH] crypto: ccp - Fix AES XTS error for request sizes above 4096

2016-05-20 Thread Herbert Xu
On Fri, May 20, 2016 at 05:33:03PM -0500, Tom Lendacky wrote: > The ccp-crypto module for AES XTS support has a bug that can allow requests > greater than 4096 bytes in size to be passed to the CCP hardware. The CCP > hardware does not support request sizes larger than 4096, resulting in >

Re: IV generation in cryptographic driver in AEAD

2016-05-20 Thread Herbert Xu
On Fri, May 20, 2016 at 10:50:38AM -0500, Gary R Hook wrote: > > Why is (or should) setting geniv (be) required? > > crypto_givcipher_default() appears to call crypto_default_geniv() if > the geniv member > is NULL. That function returns "eseqiv" or "chainiv" (under certain > conditions). If an >

[PATCH] crypto: ccp - Fix AES XTS error for request sizes above 4096

2016-05-20 Thread Tom Lendacky
The ccp-crypto module for AES XTS support has a bug that can allow requests greater than 4096 bytes in size to be passed to the CCP hardware. The CCP hardware does not support request sizes larger than 4096, resulting in incorrect output. The request should actually be handled by the fallback

Re: IV generation in cryptographic driver in AEAD

2016-05-20 Thread Gary R Hook
On 05/19/2016 11:19 PM, Herbert Xu wrote: Denis B wrote: My algs struct now looks like this: static struct crypto_alg pp_crypto_algs[] = { { .cra_name = "authenc(hmac(sha256),cbc(aes))", .cra_driver_name = "pp_crypto_cbc_hmac_sha256", .cra_priority

Re: HWCAP_CRYPTO define for ARMv8?

2016-05-20 Thread Horia Ioan Geanta Neag
On 5/15/2016 1:13 PM, Jeffrey Walton wrote: > Hi Everyone, > > It appears defines like HWCAP_CRC32 fall under the purview of the > kernel. Confer, http://www.google.com/search?q="HWCAP_CRC32; (my > apologies if this is not the case). > > We use getauxval(AT_HWCAP) and HWCAP_CRC32 for runtime

Crypto Fixes for 4.7

2016-05-20 Thread Herbert Xu
Hi Linus: This push fixes a regression that causes sha-mb to crash. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus Josh Poimboeuf (1): crypto: sha1-mb - make sha1_x8_avx2() conform to C function ABI arch/x86/crypto/sha-mb/sha1_x8_avx2.S |