Am Dienstag, 14. Juni 2016, 09:42:34 schrieb Andrew Zaborowski:
Hi Andrew,
> >
> > I think we have agreed on dropping the length enforcement at the interface
> > level.
>
> Separately from this there's a problem with the user being unable to
> know if the algorithm is going to fail because of d
Hello,
Le 15/06/2016 21:37, Boris Brezillon a écrit :
"
Add a BUG_ON() call when the driver tries to launch a crypto request
while the engine is still processing the previous one. This replaces
a silent system hang by a verbose kernel panic with the associated
backtrace to let the user know tha
Hello,
Le 15/06/2016 22:07, Boris Brezillon a écrit :
On Wed, 15 Jun 2016 21:15:30 +0200
Romain Perier wrote:
Adding a TDMA descriptor at the end of the request for copying the
output IV vector via a DMA transfer. This is required for processing
cipher requests asynchroniously in chained mode
Hi Romain,
On jeu., juin 16 2016, Romain Perier wrote:
>
>>> diff --git a/drivers/crypto/marvell/cesa.h b/drivers/crypto/marvell/cesa.h
>>> index 74071e4..74b84bd 100644
>>> --- a/drivers/crypto/marvell/cesa.h
>>> +++ b/drivers/crypto/marvell/cesa.h
>>> @@ -275,6 +275,7 @@ struct mv_cesa_op_ct
An endianess fix mistakenly used higher_32_bits() instead of
upper_32_bits(), and that doesn't exist:
drivers/crypto/caam/desc_constr.h: In function 'append_ptr':
drivers/crypto/caam/desc_constr.h:84:75: error: implicit declaration of
function 'higher_32_bits' [-Werror=implicit-function-declarati
Hi Stephan,
Thanks for the review comments. I will address it in the next patch.
Please look at my reply below against each comment.
Regards,
Raveendra
On Wed, Jun 15, 2016 at 5:12 PM, Stephan Mueller wrote:
> Am Mittwoch, 15. Juni 2016, 15:11:58 schrieb Raveendra Padasalagi:
>
> Hi Raveendra,
On 6/16/2016 12:04 PM, Arnd Bergmann wrote:
> An endianess fix mistakenly used higher_32_bits() instead of
> upper_32_bits(), and that doesn't exist:
>
> drivers/crypto/caam/desc_constr.h: In function 'append_ptr':
> drivers/crypto/caam/desc_constr.h:84:75: error: implicit declaration of
> functi
Hello,
Le 15/06/2016 22:42, Boris Brezillon a écrit :
On Wed, 15 Jun 2016 21:15:31 +0200
Romain Perier wrote:
Actually the only way to access the tdma chain is to use the 'req' union
Currently, ...
ok
Now that the dma specific fields are part of the base request there's no
reason to kee
On Thu, 16 Jun 2016 14:02:42 +0200
Romain Perier wrote:
> > Now that the dma specific fields are part of the base request there's no
> > reason to keep this union.
> >
> > You can just put struct mv_cesa_req base; directly under struct
> > mv_cesa_ablkcipher_req, and move mv_cesa_ablkcipher_std_r
On Thu, 16 Jun 2016 14:02:42 +0200
Romain Perier wrote:
> > Now that the dma specific fields are part of the base request there's no
> > reason to keep this union.
> >
> > You can just put struct mv_cesa_req base; directly under struct
> > mv_cesa_ablkcipher_req, and move mv_cesa_ablkcipher_std_r
EXTRA_CFLAGS is still supported but its usage is deprecated.
Signed-off-by: Tudor Ambarus
---
drivers/crypto/caam/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/caam/Makefile b/drivers/crypto/caam/Makefile
index 399ad55..3e9d3e1 100644
--- a/drivers/c
Hello,
Le 15/06/2016 22:55, Boris Brezillon a écrit :
+
Nit: not sure you should mix this cosmetic change with the other
changes.
Ok
You already have ivsize initialized.
+ memcpy_fromio(ablkreq->info, basereq->chain.last->data, ivsize);
Use memcpy() here.
good catch, f
Hello,
Le 15/06/2016 23:13, Boris Brezillon a écrit :
On Wed, 15 Jun 2016 21:15:33 +0200
Romain Perier wrote:
This commits adds support for fine grained load balancing on
multi-engine IPs. The engine is pre-selected based on its current load
and on the weight of the crypto request that is abo
Hi Stephan,
On 16 June 2016 at 10:05, Stephan Mueller wrote:
> Am Dienstag, 14. Juni 2016, 09:42:34 schrieb Andrew Zaborowski:
>
> Hi Andrew,
>
>> >
>> > I think we have agreed on dropping the length enforcement at the interface
>> > level.
>>
>> Separately from this there's a problem with the us
Am Donnerstag, 16. Juni 2016, 16:59:01 schrieb Andrew Zaborowski:
Hi Andrew,
> Hi Stephan,
>
> On 16 June 2016 at 10:05, Stephan Mueller wrote:
> > Am Dienstag, 14. Juni 2016, 09:42:34 schrieb Andrew Zaborowski:
> >
> > Hi Andrew,
> >
> >> > I think we have agreed on dropping the length enfor
Am Donnerstag, 16. Juni 2016, 14:44:57 schrieb Raveendra Padasalagi:
Hi Raveendra,
> > Typo DFIPS?
>
> It's not typo, DFIPS mean here Draft FIPS 202.
> Do you want me to put it in another way ?
I have never seen DFIPS. Besides, most FIPS standards are drafts (including of
FIPS 140-2 :-) ), bec
Hi Stephan,
Yes, I was initially thinking of to put it as FIPS but looked at the
existing "crypto/Kconfig"
for other algorithms and found it to be using DFIPS. So kept this also
the same :)
I need some clarification to address your comment
"Shouldn't there be a priority here?"
What I know regar
Am Donnerstag, 16. Juni 2016, 21:39:17 schrieb Raveendra Padasalagi:
Hi Raveendra,
> I need some clarification to address your comment
>
> "Shouldn't there be a priority here?"
>
> What I know regarding priority value for an algorithm
> is higher the priority value it will be get selected for e
Hi Stephan,
On 16 June 2016 at 17:38, Stephan Mueller wrote:
>> This isn't an issue with AF_ALG, I should have changed the subject
>> line perhaps. In this case it's an inconsistency between some
>> implementations and the documentation (header comment). It affects
>> users accessing the cipher
This patchset adds the implementation of SHA-3 algorithm
in software and it's based on original implementation
pushed in patch https://lwn.net/Articles/518415/ with
additional changes to match the padding rules specified
in SHA-3 specification.
This patchset also includes changes in tcrypt module
From: Jeff Garzik
This patch adds the implementation of SHA3 algorithm
in software and it's based on original implementation
pushed in patch https://lwn.net/Articles/518415/ with
additional changes to match the padding rules specified
in SHA-3 specification.
Signed-off-by: Jeff Garzik
Signed-of
Added support for SHA-3 algorithm test's
in tcrypt module and related test vectors.
Signed-off-by: Raveendra Padasalagi
---
crypto/tcrypt.c | 53 ++-
crypto/testmgr.c | 40 ++
crypto/testmgr.h | 125 +++
3
22 matches
Mail list logo
