Re: [PATCH] crypto: rsa-pkcs1pad - Fix akcipher request allocation

2016-07-14 Thread Tadeusz Struk
Hi Salvatore, On 07/14/2016 03:25 AM, Salvatore Benedetto wrote: > Embedding the akcipher_request in pkcs1pad_request don't take > into account the context space required by the akcipher object. I think we do take into account the sub request context. See line 675. The only thing that is wrong is

Please quote urgently

2016-07-14 Thread RAHAMAN BIN ABD HAMID TRADING
Dear sir/madam, I am RAHAMAN BIN, I am the Managing Director/CEO of ABD RAHAMAN BIN ABD HAMID Trading UK, I am introduced to you by a friend and an associate. Please we need this items from you as we have been told you supply them. Kindly view the PDF file attached for copy of the items we need I

Re: [RFC PATCH] KEYS: add SP800-56A KDF support for DH

2016-07-14 Thread Mat Martineau
On Tue, 12 Jul 2016, Stephan Mueller wrote: Hi Mat, David, This patch is based on the cryptodev-2.6 tree with the patch 4693fc734d675c5518ea9bd4c9623db45bc37402 ("KEYS: Add placeholder for KDF usage with DH") from Linus' tree added on top. I am aware of the fact that the compat code is not pre

Re: [PATCH] DH support: add KDF handling support

2016-07-14 Thread Mat Martineau
On Thu, 14 Jul 2016, Stephan Mueller wrote: Am Mittwoch, 13. Juli 2016, 16:17:12 schrieb Mat Martineau: Hi Mat, ---8< Add the interface logic to support DH with KDF handling support. The dh_compute code now allows the following options: - no KDF support / output of raw DH shared secr

Re: [PATCH] DH support: add KDF handling support

2016-07-14 Thread Stephan Mueller
Am Donnerstag, 14. Juli 2016, 04:00:57 schrieb Jeffrey Walton: Hi Jeffrey, > > Note, as shared secrets potentially post-processed by a KDF usually are > > again used as key or data encryption keys, they need to be > > truncated/expanded to a specific length anyway. A KDF inherently provides > > t

[PATCH] crypto: rsa-pkcs1pad - Fix akcipher request allocation

2016-07-14 Thread Salvatore Benedetto
Embedding the akcipher_request in pkcs1pad_request don't take into account the context space required by the akcipher object. This result in memory corruption (and kernel panic) as the akcipher object will overwrite anything after akcipher_request structure. Fix it by dinamically allocating the st

Re: [PATCH] DH support: add KDF handling support

2016-07-14 Thread Jeffrey Walton
> Note, as shared secrets potentially post-processed by a KDF usually are again > used as key or data encryption keys, they need to be truncated/expanded to a > specific length anyway. A KDF inherently provides the truncation support to > any arbitrary length. Thus, I would think that the caller ne