Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

2016-09-27 Thread Herbert Xu
On Tue, Sep 27, 2016 at 04:46:44PM -0300, Marcelo Cerri wrote: > > Can you check if the problem occurs with this patch? In light of the fact that padlock-sha is the correct example to follow, you only need to add one line to the init_tfm fucntion to update the descsize based on that of the fallba

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

2016-09-27 Thread Herbert Xu
On Tue, Sep 27, 2016 at 05:01:03AM -0400, Jan Stancek wrote: > > Also, does that mean that padlock_sha has similar problem? > It does not seem to reserve any space for fallback __ctx and it calls > init()/update()/export() with padlock_sha_desc's fallback: > > struct padlock_sha_desc { >

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

2016-09-27 Thread Marcelo Cerri
Jan, Can you check if the problem occurs with this patch? --- drivers/crypto/vmx/ghash.c | 28 +--- drivers/crypto/vmx/vmx.c | 9 + 2 files changed, 26 insertions(+), 11 deletions(-) diff --git a/drivers/crypto/vmx/ghash.c b/drivers/crypto/vmx/ghash.c index 6

Re: [BUG] crypto: atmel-aes - erro when compiling with VERBOSE_DEBUG enable

2016-09-27 Thread Cyrille Pitchen
Hi Levent, there is a typo in the subject line: erroR. Also it would be better to start the summary phrase of the subject line with a verb: crypto: atmel-aes: fix compiler error when VERBODE_DEBUG is defined Le 22/09/2016 à 14:45, levent demir a écrit : > Fix debug function call in atmel_aes_wri

Re: [v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-09-27 Thread Stephan Mueller
Am Dienstag, 27. September 2016, 16:44:16 CEST schrieb Kalle Valo: Hi Kalle, > Stephan Mueller wrote: > > The ATH9K driver implements an RNG which is completely bypassing the > > standard Linux HW generator logic. > > > > The RNG may or may not deliver entropy. Considering the conservative > >

Re: [1/2] ath9k: change entropy formula for easier understanding

2016-09-27 Thread Kalle Valo
miaoqing pan wrote: > From: Miaoqing Pan > > The quality of ADC entropy is 10 bits of min-entropy for > a 32-bit value, change '(((x) * 8 * 320) >> 10)' to > '(((x) * 8 * 10) >> 5)' for easier understanding. > > Signed-off-by: Miaoqing Pan I need some help here, it this patch ok to take or sh

Re: [v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-09-27 Thread Kalle Valo
Stephan Mueller wrote: > The ATH9K driver implements an RNG which is completely bypassing the > standard Linux HW generator logic. > > The RNG may or may not deliver entropy. Considering the conservative > approach in treating entropy with respect to non-auditable sources, this > patch changes th

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

2016-09-27 Thread Marcelo Cerri
Hi, On Tue, Sep 27, 2016 at 05:01:03AM -0400, Jan Stancek wrote: > So, if we extended p8_ghash_desc_ctx to accommodate fallback_desc's ctx > and then provided statesize/import/export, would that be acceptable? > > struct p8_ghash_desc_ctx { > ... > struct shash_desc fallback_desc;

Re: [PATCH] padata: remove recently added module usage from bool code

2016-09-27 Thread Sebastian Andrzej Siewior
On 2016-09-26 21:18:21 [-0400], Paul Gortmaker wrote: > > ...and so it currently is not being built as a module by anyone. that is correct. Acked-by: Sebastian Andrzej Siewior Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to major

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

2016-09-27 Thread Jan Stancek
- Original Message - > From: "Herbert Xu" > To: "Marcelo Cerri" > Cc: "Jan Stancek" , "rui y wang" , > mhce...@linux.vnet.ibm.com, > leosi...@linux.vnet.ibm.com, pfsmor...@linux.vnet.ibm.com, > linux-crypto@vger.kernel.org, > linuxppc-...@lists.ozlabs.org, linux-ker...@vger.kernel.o