Re: [PATCH] crypto: testmgr - add guard to dst buffer for ahash_export

2016-10-02 Thread Herbert Xu
On Wed, Sep 28, 2016 at 04:38:37PM +0200, Jan Stancek wrote: > Add a guard to 'state' buffer and warn if its consistency after > call to crypto_ahash_export() changes, so that any write that > goes beyond advertised statesize (and thus causing potential > memory corruption [1]) is more visible. >

Re: [PATCH v2] crypto: gcm - Fix IV buffer size in crypto_gcm_setkey

2016-10-02 Thread Herbert Xu
On Fri, Sep 23, 2016 at 10:47:32AM +0200, Ondrej Mosnacek wrote: > The cipher block size for GCM is 16 bytes, and thus the CTR transform > used in crypto_gcm_setkey() will also expect a 16-byte IV. However, > the code currently reserves only 8 bytes for the IV, causing > an out-of-bounds access in

Re: [PATCH] crypto: sunxi-ss: mark sun4i_hash() static

2016-10-02 Thread Herbert Xu
On Sat, Sep 24, 2016 at 12:28:46PM +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/crypto/sunxi-ss/sun4i-ss-hash.c:168:5: warning: no previous prototype > for 'sun4i_hash' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it i

Re: [PATCH] crypto: sha1-powerpc: little-endian support

2016-10-02 Thread Herbert Xu
On Fri, Sep 23, 2016 at 04:31:56PM -0300, Marcelo Cerri wrote: > The driver does not handle endianness properly when loading the input > data. > > Signed-off-by: Marcelo Cerri Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.ap

Re: [BUG] crypto: atmel-aes - erro when compiling with VERBOSE_DEBUG enable

2016-10-02 Thread Herbert Xu
On Tue, Sep 27, 2016 at 06:45:18PM +0200, Cyrille Pitchen wrote: > Hi Levent, > > there is a typo in the subject line: erroR. > Also it would be better to start the summary phrase of the subject line with a > verb: > > crypto: atmel-aes: fix compiler error when VERBODE_DEBUG is defined > > Le 22

Re: [PATCH 0/3] Fix crypto/vmx/p8_ghash memory corruption

2016-10-02 Thread Herbert Xu
On Wed, Sep 28, 2016 at 01:42:08PM -0300, Marcelo Cerri wrote: > This series fixes the memory corruption found by Jan Stancek in 4.8-rc7. The > problem however also affects previous versions of the driver. > > Marcelo Cerri (3): > crypto: ghash-generic - move common definitions to a new header f

Re: [PATCH 0/3] Fix crypto/vmx/p8_ghash memory corruption

2016-10-02 Thread Herbert Xu
On Thu, Sep 29, 2016 at 06:59:08AM +1000, Anton Blanchard wrote: > Hi Marcelo > > > This series fixes the memory corruption found by Jan Stancek in > > 4.8-rc7. The problem however also affects previous versions of the > > driver. > > If it affects previous versions, please add the lines in the s

Re: [PATCH v2 0/2] Minor CCP driver changes

2016-10-02 Thread Herbert Xu
On Wed, Sep 28, 2016 at 11:53:31AM -0500, Gary R Hook wrote: > V2: point a goto statement at the correct label > > The following series is for miscellaneous small changes. Both patches applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.

Re: [PATCH] crypto: arm64/sha256 - add support for SHA256 using NEON instructions

2016-10-02 Thread Herbert Xu
On Sat, Oct 01, 2016 at 07:58:56PM -0700, Ard Biesheuvel wrote: > > Please disregard this patch for now. I will follow up with a more > elaborate series for SHA256 on arm64 Thanks for the heads up. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.

Re: [PATCH v2] crypto: caam - treat SGT address pointer as u64

2016-10-02 Thread Herbert Xu
On Fri, Sep 30, 2016 at 12:09:39PM +0300, Tudor Ambarus wrote: > Even for i.MX, CAAM is able to use address pointers greater than > 32 bits, the address pointer field being interpreted as a double word. > Enforce u64 address pointer in the sec4_sg_entry struct. > > This patch fixes the SGT address