Re: [PATCH 2/6] crypto: ccp - Remove unneeded sign-extension support

2016-10-13 Thread Tom Lendacky
On 10/13/2016 09:53 AM, Gary R Hook wrote: > The reverse-get/set functions can be simplified by > eliminating unused code. > > > Signed-off-by: Gary R Hook > --- > drivers/crypto/ccp/ccp-ops.c | 145 > +- > 1 file changed, 59

Re: [PATCH 3/6] crypto: ccp - Add support for RSA on the CCP

2016-10-13 Thread Gary R Hook
On 10/13/2016 01:25 PM, Stephan Mueller wrote: Am Donnerstag, 13. Oktober 2016, 09:53:09 CEST schrieb Gary R Hook: Hi Gary, Wire up the v3 CCP as a cipher provider. Signed-off-by: Gary R Hook --- ...snip... +} + +static void ccp_free_mpi_key(struct ccp_rsa_key *key) +{

Re: [PATCH 6/6] crypto: ccp - Enable 3DES function on v5 CCPs

2016-10-13 Thread Tom Lendacky
On 10/13/2016 09:53 AM, Gary R Hook wrote: > Wire up support for Triple DES in ECB mode. > > Signed-off-by: Gary R Hook > --- > drivers/crypto/ccp/Makefile |1 > drivers/crypto/ccp/ccp-crypto-des3.c | 254 > ++ >

Re: [PATCH 5/6] crypto: ccp - Enable support for AES GCM on v5 CCPs

2016-10-13 Thread Tom Lendacky
On 10/13/2016 09:53 AM, Gary R Hook wrote: > A version 5 device provides the primitive commands > required for AES GCM. This patch adds support for > en/decryption. > > Signed-off-by: Gary R Hook > --- > drivers/crypto/ccp/Makefile|1 >

Re: [PATCH 3/6] crypto: ccp - Add support for RSA on the CCP

2016-10-13 Thread Tom Lendacky
On 10/13/2016 09:53 AM, Gary R Hook wrote: > Wire up the v3 CCP as a cipher provider. > > Signed-off-by: Gary R Hook > --- > drivers/crypto/ccp/Makefile |1 > drivers/crypto/ccp/ccp-crypto-main.c | 15 ++ > drivers/crypto/ccp/ccp-crypto-rsa.c | 258 >

Re: [PATCH 1/6] crypto: ccp - Add SHA-2 support

2016-10-13 Thread Tom Lendacky
On 10/13/2016 09:52 AM, Gary R Hook wrote: > Incorporate 384-bit and 512-bit hashing for a version 5 CCP > device > > > Signed-off-by: Gary R Hook > --- > drivers/crypto/ccp/ccp-crypto-sha.c | 22 +++ > drivers/crypto/ccp/ccp-crypto.h |9 +++-- >

Re: [PATCH 3/6] crypto: ccp - Add support for RSA on the CCP

2016-10-13 Thread Stephan Mueller
Am Donnerstag, 13. Oktober 2016, 09:53:09 CEST schrieb Gary R Hook: Hi Gary, > Wire up the v3 CCP as a cipher provider. > > Signed-off-by: Gary R Hook > --- > drivers/crypto/ccp/Makefile |1 > drivers/crypto/ccp/ccp-crypto-main.c | 15 ++ >

[PATCH 6/6] crypto: ccp - Enable 3DES function on v5 CCPs

2016-10-13 Thread Gary R Hook
Wire up support for Triple DES in ECB mode. Signed-off-by: Gary R Hook --- drivers/crypto/ccp/Makefile |1 drivers/crypto/ccp/ccp-crypto-des3.c | 254 ++ drivers/crypto/ccp/ccp-crypto-main.c | 10 +

[PATCH 3/6] crypto: ccp - Add support for RSA on the CCP

2016-10-13 Thread Gary R Hook
Wire up the v3 CCP as a cipher provider. Signed-off-by: Gary R Hook --- drivers/crypto/ccp/Makefile |1 drivers/crypto/ccp/ccp-crypto-main.c | 15 ++ drivers/crypto/ccp/ccp-crypto-rsa.c | 258 ++

[PATCH 2/6] crypto: ccp - Remove unneeded sign-extension support

2016-10-13 Thread Gary R Hook
The reverse-get/set functions can be simplified by eliminating unused code. Signed-off-by: Gary R Hook --- drivers/crypto/ccp/ccp-ops.c | 145 +- 1 file changed, 59 insertions(+), 86 deletions(-) diff --git

[PATCH 0/6] Enable hashing and ciphers for v5 CCP

2016-10-13 Thread Gary R Hook
The following series implements new function for a version 5 CCP: Support for SHA-2, wiring of RSA using the updated framework, AES GCM mode, and Triple-DES in ECB mode. --- Gary R Hook (6): crypto: ccp - Add SHA-2 support crypto: ccp - Remove unneeded sign-extension support

[PATCH 5/6] crypto: ccp - Enable support for AES GCM on v5 CCPs

2016-10-13 Thread Gary R Hook
A version 5 device provides the primitive commands required for AES GCM. This patch adds support for en/decryption. Signed-off-by: Gary R Hook --- drivers/crypto/ccp/Makefile|1 drivers/crypto/ccp/ccp-crypto-aes-galois.c | 252 +++

[PATCH 1/6] crypto: ccp - Add SHA-2 support

2016-10-13 Thread Gary R Hook
Incorporate 384-bit and 512-bit hashing for a version 5 CCP device Signed-off-by: Gary R Hook --- drivers/crypto/ccp/ccp-crypto-sha.c | 22 +++ drivers/crypto/ccp/ccp-crypto.h |9 +++-- drivers/crypto/ccp/ccp-ops.c| 70

[PATCH 4/6] crypto: ccp - Add RSA support for a v5 ccp

2016-10-13 Thread Gary R Hook
Take into account device implementation differences for RSA. Signed-off-by: Gary R Hook --- drivers/crypto/ccp/ccp-crypto-rsa.c | 14 +++-- drivers/crypto/ccp/ccp-crypto.h |3 - drivers/crypto/ccp/ccp-dev.h|2 - drivers/crypto/ccp/ccp-ops.c| 97

[PATCH 1/6] chcr:Fix memory corruption done

2016-10-13 Thread Harsh Jain
Fix memory corruption done by *((u32 *)dec_key + k) operation. Signed-off-by: Jitendra Lulla --- drivers/crypto/chelsio/chcr_algo.c | 52 ++ drivers/crypto/chelsio/chcr_algo.h | 58 +- 2 files changed, 53

Git clone/pull not working?

2016-10-13 Thread Gary R Hook
Am I the only person that can't clone/pull from kernel.org? Been getting handshake errors this week, but other sites (e.g. libvirt.org) seem to be working fine. I thought I'd ask first... perhaps it's just me/my employer? -- To unsubscribe from this list: send the line "unsubscribe

[PATCH 5/6] chcr: Move tfm ctx variable to request context

2016-10-13 Thread Harsh Jain
Move tfm ctx variable to request context. Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/chcr_algo.c | 26 +- drivers/crypto/chelsio/chcr_crypto.h | 9 - 2 files changed, 17 insertions(+), 18 deletions(-) diff --git

[PATCH 4/6] chcr: Use SHASH_DESC_ON_STACK

2016-10-13 Thread Harsh Jain
Use SHASH_DESC_ON_STACK macro to allocate memory for ipad/opad calculation. Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/chcr_algo.c | 63 +++- drivers/crypto/chelsio/chcr_crypto.h | 2 +- 2 files changed, 27 insertions(+), 38

[PATCH 2/6] chcr: Remove malloc/free

2016-10-13 Thread Harsh Jain
Remove malloc/free in crypto operation and allocate memory via cra_ctxsize. Added new structure chcr_wr to populate Work Request Header. Fixes: 324429d74127 (chcr: Support for Chelsio's Crypto Hardware) Reported-by: Dan Carpenter Signed-off-by: Jitendra Lulla

[PATCH 3/6] chcr: Adjust Dest. buffer size

2016-10-13 Thread Harsh Jain
Destination buffer size passed to hardware should not be greater than crypto operation output. Signed-off-by: Jitendra Lulla --- drivers/crypto/chelsio/chcr_algo.c | 50 +++--- 1 file changed, 20 insertions(+), 30 deletions(-) diff --git

[PATCH 6/6] Add support for AEAD algos.

2016-10-13 Thread Harsh Jain
Add support for following AEAD algos. GCM,CCM,RFC4106,RFC4309,authenc(hmac(shaXXX),cbc(aes)). Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/Kconfig |1 + drivers/crypto/chelsio/chcr_algo.c | 1466 +-

[PATCH 0/6] chcr: AEAD support and bug fixes

2016-10-13 Thread Harsh Jain
This patch series includes Bug Fixes, performance improvement and support for following AEAD algos. GCM,CCM,RFC4106,RFC4303,authenc(hmac(shaXXX),cbc(aes)) This patch series is based on linux-next tree and depends on ("crypto/chcr: Add support for Chelsio Crypto Driver ") series.

[bug report] crypto: omap-sham - add support functions for sg based data handling

2016-10-13 Thread Dan Carpenter
Hello Tero Kristo, This is a semi-automatic email about new static checker warnings. The patch f19de1bc67a0: "crypto: omap-sham - add support functions for sg based data handling" from Sep 19, 2016, leads to the following Smatch complaint: drivers/crypto/omap-sham.c:808