Re: [PATCH v2 0/8] crypto: ARM/arm64 - big endian fixes

2016-10-20 Thread Herbert Xu
On Tue, Oct 11, 2016 at 07:15:12PM +0100, Ard Biesheuvel wrote: > As it turns out, none of the accelerated crypto routines under > arch/arm64/crypto > currently work, or have ever worked correctly when built for big endian. So > this > series fixes all of them. This v2 now includes a similar fix

Re: [PATCH] crypto: CCP - change type of struct member lsb to signed

2016-10-20 Thread Herbert Xu
On Wed, Oct 12, 2016 at 08:47:03AM -0500, Gary R Hook wrote: > The lsb field uses a value of -1 to indicate that it > is unassigned. Therefore type must be a signed int. > > Signed-off-by: Gary R Hook Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/

Re: [PATCH] crypto: cmac - fix alignment of 'consts'

2016-10-20 Thread Herbert Xu
On Mon, Oct 10, 2016 at 10:15:15AM -0700, Eric Biggers wrote: > The per-transform 'consts' array is accessed as __be64 in > crypto_cmac_digest_setkey() but was only guaranteed to be aligned to > __alignof__(long). Fix this by aligning it to __alignof__(__be64). > > Signed-off-by: Eric Biggers P

Re: [PATCH] crypto: cmac - return -EINVAL if block size is unsupported

2016-10-20 Thread Herbert Xu
On Mon, Oct 10, 2016 at 10:15:14AM -0700, Eric Biggers wrote: > cmac_create() previously returned 0 if a cipher with a block size other > than 8 or 16 bytes was specified. It should return -EINVAL instead. > Granted, this doesn't actually change any behavior because cryptomgr > currently ignores a

Re: [PATCH] crypto: skcipher - Remove unused crypto_lookup_skcipher() declaration

2016-10-20 Thread Herbert Xu
On Fri, Oct 07, 2016 at 02:13:34PM -0700, Eric Biggers wrote: > The definition of crypto_lookup_skcipher() was already removed in > commit 3a01d0ee2b99 ("crypto: skcipher - Remove top-level givcipher > interface"). So the declaration should be removed too. > > Signed-off-by: Eric Biggers Patch

Re: [PATCH] crypto: api - Remove no-op exit_ops code

2016-10-20 Thread Herbert Xu
On Fri, Oct 07, 2016 at 02:13:35PM -0700, Eric Biggers wrote: > crypto_exit_cipher_ops() and crypto_exit_compress_ops() are no-ops and > have been for a long time, so remove them. > > Signed-off-by: Eric Biggers Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au

Re: [PATCH v4 0/2] Improve DMA chaining for ahash requests

2016-10-20 Thread Herbert Xu
On Wed, Oct 05, 2016 at 09:56:31AM +0200, Romain Perier wrote: > This series contain performance improvement regarding ahash requests. > So far, ahash requests were systematically not chained at the DMA level. > However, in some case, like this is the case by using IPSec, some ahash > requests can

Re: [PATCH v2 1/1] crypto: atmel-aes: add support to the XTS mode

2016-10-20 Thread Herbert Xu
On Mon, Oct 03, 2016 at 02:33:16PM +0200, Cyrille Pitchen wrote: > This patch adds the xts(aes) algorithm, which is supported from > hardware version 0x500 and above (sama5d2x). > > Signed-off-by: Cyrille Pitchen Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.a

Re: [PATCH v3 0/8] Add support for SafeXcel IP-76 to OMAP RNG

2016-10-20 Thread Herbert Xu
On Thu, Oct 20, 2016 at 09:02:33AM +0200, Romain Perier wrote: > > Without any feedbacks from the OMAP guys, could you merge please ? > Regressions can be detected in "next" and then fixed. All appied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://

Re: [PATCH 1/1] crypto: atmel-aes: fix compiler error when VERBOSE_DEBUG is defined

2016-10-20 Thread Herbert Xu
On Thu, Sep 29, 2016 at 06:46:57PM +0200, Cyrille Pitchen wrote: > This patch fixes a compiler error when VERBOSE_DEBUG is defined. Indeed, > in atmel_aes_write(), the 3rd argument of atmel_aes_reg_name() was > missing. > > Signed-off-by: Cyrille Pitchen > Reported-by: Levent Demir Patch applie

[PATCH v2 4/8] crypto: doc - fix separation of cipher / req API

2016-10-20 Thread Stephan Mueller
Keep the cipher API and the request API function documentation in separate sections. Signed-off-by: Stephan Mueller --- Documentation/crypto/api-akcipher.rst | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/Documentation/crypto/api-akcipher.rst b/Do

[PATCH v2 6/8] crypto: doc - remove crypto_alloc_ablkcipher

2016-10-20 Thread Stephan Mueller
Remove the documentation reference to crypto_alloc_ablkcipher as the API function call was removed. Signed-off-by: Stephan Mueller --- Documentation/crypto/api-skcipher.rst | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/crypto/api-skcipher.rst b/Documentation/crypto/api-skc

[PATCH v2 0/8] Conversion crypto API documentation to Sphinx

2016-10-20 Thread Stephan Mueller
Hi, the attached patch set converts the existing crypto API documentation from DocBook to Sphinx. The first two patch sets perform the conversion without changes to the content of the documentation. Starting with patch 3, fixes and enhancements are applied. A full review of the new kernel crypto

[PATCH v2 2/8] crypto: doc - remove crypto API DocBook

2016-10-20 Thread Stephan Mueller
With the conversion of the documentation to Sphinx, the old DocBook is now stale. Signed-off-by: Stephan Mueller --- Documentation/DocBook/Makefile|2 +- Documentation/DocBook/crypto-API.tmpl | 2092 - 2 files changed, 1 insertion(+), 2093 deletions(-

[PATCH v2 1/8] crypto: doc - convert crypto API documentation to Sphinx

2016-10-20 Thread Stephan Mueller
With the conversion of the kernel crypto API DocBook to Sphinx, the monolithic document is broken up into individual documents. The documentation is unchanged with the exception of a slight reordering to keep the individual document parts self-contained. Signed-off-by: Stephan Mueller --- Docume

[PATCH v2 5/8] crypto: doc - add KPP documentation

2016-10-20 Thread Stephan Mueller
Add the KPP API documentation to the kernel crypto API Sphinx documentation. This addition includes the documentation of the ECDH and DH helpers which are needed to create the approrpiate input data for the crypto_kpp_set_secret function. Signed-off-by: Stephan Mueller --- Documentation/crypto/a

[PATCH v2 7/8] crypto: doc - clarify AEAD memory structure

2016-10-20 Thread Stephan Mueller
The previous description have been misleading and partially incorrect. Reported-by: Harsh Jain Signed-off-by: Stephan Mueller --- crypto/algif_aead.c | 14 ++ include/crypto/aead.h | 36 2 files changed, 14 insertions(+), 36 deletions(-) diff

[PATCH v2 3/8] crypto: doc - fix source comments for Sphinx

2016-10-20 Thread Stephan Mueller
Update comments to avoid any complaints from Sphinx during compilation. Signed-off-by: Stephan Mueller --- include/crypto/aead.h | 14 +++--- include/crypto/hash.h | 2 +- include/crypto/skcipher.h | 4 ++-- include/linux/crypto.h| 4 ++-- 4 files changed, 12 insertions(+)

[PATCH v2 8/8] crypto: doc - optimize compilation

2016-10-20 Thread Stephan Mueller
The :functions: definition allows the specification of multiple function references which prevents parsing the header file multiple times. Reported-by: Jani Nikula Signed-off-by: Stephan Mueller --- Documentation/crypto/api-aead.rst | 51 +--- Documentation/crypto/api-akcipher.rst

Re: [PATCH v9 1/8] crypto: add asynchronous compression api

2016-10-20 Thread Herbert Xu
On Thu, Sep 29, 2016 at 11:18:55AM +0100, Giovanni Cabiddu wrote: > > + if (nla_put(skb, CRYPTOCFGA_REPORT_COMPRESS, > + sizeof(struct crypto_report_comp), &racomp)) > + goto nla_put_failure; This bit doesn't compile for me. Please fix up and resubmit. ../crypto/c

Re: [PATCH 2/6] chcr: Remove malloc/free

2016-10-20 Thread Herbert Xu
On Thu, Oct 13, 2016 at 04:39:35PM +0530, Harsh Jain wrote: > Remove malloc/free in crypto operation and allocate memory via cra_ctxsize. > Added new structure chcr_wr to populate Work Request Header. > Fixes: 324429d74127 (chcr: Support for Chelsio's Crypto Hardware) Do you mean the reqsize as op

Re: [PATCH][TRIVIAL] crypto: ccp - fix typo "CPP"

2016-10-20 Thread Gary R Hook
On 10/20/2016 02:20 PM, Paul Bolle wrote: The abbreviation for Cryptographic Coprocessor is "CCP". Signed-off-by: Paul Bolle Acked-by: Gary R Hook --- include/linux/ccp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/ccp.h b/include/linux/ccp.h in

[PATCH][TRIVIAL] crypto: ccp - fix typo "CPP"

2016-10-20 Thread Paul Bolle
The abbreviation for Cryptographic Coprocessor is "CCP". Signed-off-by: Paul Bolle --- include/linux/ccp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/ccp.h b/include/linux/ccp.h index a7653339fedb..c71dd8fa5764 100644 --- a/include/linux/ccp.h +++ b/i

Re: [PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS

2016-10-20 Thread Kevin Hilman
Javier Martinez Canillas writes: > The Amlogic Meson is a DT-only platform, which means the devices are > registered via OF and not using the legacy platform devices support. > > So there's no need to have a MODULE_ALIAS("platform:meson-rng") since > the reported uevent MODALIAS to user-space wil

Re: [PATCH v3 0/8] Add support for SafeXcel IP-76 to OMAP RNG

2016-10-20 Thread Romain Perier
Hello, Le 26/09/2016 à 12:01, Romain Perier a écrit : Le 16/09/2016 14:52, Romain Perier a écrit : Hello, Le 16/09/2016 12:08, Romain Perier a écrit : The driver omap-rng has a lot of similarity with the IP block SafeXcel IP-76. A lot of registers are the same and the way that the driver wo