Re: [PATCH] nvmem: sunxi-sid: SID content is not a valid source of randomness

2016-10-24 Thread LABBE Corentin
On Mon, Oct 24, 2016 at 10:10:20PM +0200, Maxime Ripard wrote: > On Sat, Oct 22, 2016 at 03:53:28PM +0200, Corentin Labbe wrote: > > Since SID's content is constant over reboot, > > That's not true, at least not across all the Allwinner SoCs, and > especially not on the A10 and A20 that this drive

Re: [PATCH v10 0/8] crypto: asynchronous compression api

2016-10-24 Thread Herbert Xu
On Fri, Oct 21, 2016 at 01:19:46PM +0100, Giovanni Cabiddu wrote: > The following patch set introduces acomp, a generic asynchronous > (de)compression api with support for SG lists. > We propose a new crypto type called crypto_acomp_type, a new struct acomp_alg > and struct crypto_acomp, together w

Re: [PATCH][TRIVIAL] crypto: ccp - fix typo "CPP"

2016-10-24 Thread Herbert Xu
Paul Bolle wrote: > The abbreviation for Cryptographic Coprocessor is "CCP". > > Signed-off-by: Paul Bolle Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: sen

Re: [PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS

2016-10-24 Thread Herbert Xu
On Wed, Oct 19, 2016 at 04:50:18PM -0300, Javier Martinez Canillas wrote: > The Amlogic Meson is a DT-only platform, which means the devices are > registered via OF and not using the legacy platform devices support. > > So there's no need to have a MODULE_ALIAS("platform:meson-rng") since > the re

Re: [PATCH] crypto: ccp - Clean up the LSB slot allocation code

2016-10-24 Thread Herbert Xu
On Tue, Oct 18, 2016 at 05:33:37PM -0500, Gary R Hook wrote: > Fix a few problems revealed by testing: verify consistent > units, especially in public slot allocation. Percolate > some common initialization code up to a common routine. > Add some comments. > > Signed-off-by: Gary R Hook Patch ap

Re: [PATCH] crypto: engine - Handle the kthread worker using the new API

2016-10-24 Thread Herbert Xu
On Wed, Oct 19, 2016 at 01:54:30PM +0200, Petr Mladek wrote: > Use the new API to create and destroy the crypto engine kthread > worker. The API hides some implementation details. > > In particular, kthread_create_worker() allocates and initializes > struct kthread_worker. It runs the kthread the

Re: [PATCH] crypto: ccp - remove unneeded code

2016-10-24 Thread Herbert Xu
On Tue, Oct 18, 2016 at 05:28:49PM -0500, Gary R Hook wrote: > Clean up patch for an unneeded structure member. > > Signed-off-by: Gary R Hook Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --

Re: [PATCH v2] hwrng: meson: Fix module autoload for OF registration

2016-10-24 Thread Herbert Xu
On Mon, Oct 17, 2016 at 04:51:17PM -0300, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias inf

Re: [PATCH -next] crypto: gcm - Fix error return code in crypto_gcm_create_common()

2016-10-24 Thread Herbert Xu
On Mon, Oct 17, 2016 at 03:10:06PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return error code -EINVAL from the invalid alg ivsize error > handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Patch applied. Thanks. -- Email: Herbert Xu

Re: [PATCH] crypto: ccp - change bitfield type to unsigned ints

2016-10-24 Thread Herbert Xu
On Tue, Oct 18, 2016 at 05:28:35PM -0500, Gary R Hook wrote: > Bit fields are not sensitive to endianness, so use > a transparent standard data type > > Signed-off-by: Gary R Hook Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondo

Re: [PATCH -next] crypto: ccp - Fix non static symbol warning

2016-10-24 Thread Herbert Xu
On Mon, Oct 17, 2016 at 03:08:50PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/crypto/ccp/ccp-dev.c:44:6: warning: > symbol 'ccp_error_codes' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun Patch applied. Thanks. --

Re: [RESEND][PATCH] crypto: caam: add support for iMX6UL

2016-10-24 Thread Herbert Xu
On Mon, Oct 17, 2016 at 01:28:00PM +0200, Marcus Folkesson wrote: > i.MX6UL does only require three clocks to enable CAAM module. > > Signed-off-by: Marcus Folkesson > Acked-by: Rob Herring > Reviewed-by: Horia Geantă Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apan

Re: [PATCH] padata: Remove unused but set variables

2016-10-24 Thread Herbert Xu
Steffen Klassert wrote: > On Mon, Oct 17, 2016 at 12:16:08PM +0200, Tobias Klauser wrote: >> Remove the unused but set variable pinst in padata_parallel_worker to >> fix the following warning when building with 'W=1': >> >> kernel/padata.c: In function ‘padata_parallel_worker’: >> kernel/pada

Re: [PATCH] crypto: Move RSA+MPI constructs into an #include file

2016-10-24 Thread Herbert Xu
On Fri, Oct 14, 2016 at 02:36:00PM -0500, Gary R Hook wrote: > Move RSA support of general use into internal/rsa.h. > This allows reuse of, e.g. RSA MPI keys and support > functions. > > Signed-off-by: Gary R Hook Please fold this patch into the series that makes use of it. Thanks, -- Email: H

Re: [PATCH v2 0/8] Conversion crypto API documentation to Sphinx

2016-10-24 Thread Herbert Xu
On Sun, Oct 23, 2016 at 06:46:12PM +0200, Stephan Mueller wrote: > Am Sonntag, 23. Oktober 2016, 10:32:38 CEST schrieb Jonathan Corbet: > > Hi Jonathan, > > > On Fri, 21 Oct 2016 04:53:45 +0200 > > > > Stephan Mueller wrote: > > > the attached patch set converts the existing crypto API document

Crypto Fixes for 4.9

2016-10-24 Thread Herbert Xu
Hi Linus: This push fixes a regression caused by the stack vmalloc change. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus Andrew Lutomirski (1): hwrng: core - Don't use a stack buffer in add_early_randomness() drivers/char/hw_random/core.c

ARM-CE aes encryption on uneven blocks

2016-10-24 Thread Cata Vasile
Hi, I'm trying to understand the code for AES encryption from ARM-CE. >From the aes-glue.S calls I understand that the encryption primitives receive >the number of blocks, but have no way of determining the number of bytes to >encrypt, if for example the plaintext does not have a length of a mu

[PATCH v2] char: hw_random: atmel-rng: disable TRNG during suspend

2016-10-24 Thread Wenyou Yang
To fix the over consumption on the VDDCore due to the TRNG enabled, disable the TRNG during suspend, not only disable the user interface clock (which is controlled by PMC). Because the user interface clock is independent from any clock that may be used in the entropy source logic circuitry. Signed

RE: [PATCH v1] char: hw_random: atmel-rng: disable TRNG during suspend

2016-10-24 Thread Wenyou.Yang
> -Original Message- > From: Nicolas Ferre [mailto:nicolas.fe...@atmel.com] > Sent: 2016年10月24日 20:07 > To: Wenyou Yang - A41535 ; Herbert Xu > ; Matt Mackall > Cc: linux-crypto@vger.kernel.org; Wenyou Yang - A41535 > ; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v1] char:

Re: [PATCH v2] crypto: mxs-dcp - Remove hash support

2016-10-24 Thread Fabio Estevam
On Mon, Oct 24, 2016 at 6:39 PM, Marek Vasut wrote: > Can't you rather fix it? I would love to have this fixed, but I don't know how. Any volunteers? -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo i

Re: [PATCH v2] crypto: mxs-dcp - Remove hash support

2016-10-24 Thread Marek Vasut
On 10/24/2016 06:43 PM, Fabio Estevam wrote: > From: Fabio Estevam > > mxs-dcp driver does not probe for a long time: > > mxs-dcp 80028000.dcp: Failed to register sha1 hash! > mxs-dcp: probe of 80028000.dcp failed with error -22 > > There were some previous attempts to fix this, and the followi

Equivalent of blkciper_walk for skcipher

2016-10-24 Thread Alex Cope
How should an algorithm implementing the skcipher api walk over the scatterlist? blkcipher_walk seems to be what I need, but the API is not compatible with skciper at the moment. Repeatedly calling scatterwalk_map_and_copy looks like it will work, but would be less performant than using something

Re: [PATCH] nvmem: sunxi-sid: SID content is not a valid source of randomness

2016-10-24 Thread Maxime Ripard
On Sat, Oct 22, 2016 at 03:53:28PM +0200, Corentin Labbe wrote: > Since SID's content is constant over reboot, That's not true, at least not across all the Allwinner SoCs, and especially not on the A10 and A20 that this driver supports. > it must not be used as source of randomness. And I don't

[PATCH v2] crypto: mxs-dcp - Remove hash support

2016-10-24 Thread Fabio Estevam
From: Fabio Estevam mxs-dcp driver does not probe for a long time: mxs-dcp 80028000.dcp: Failed to register sha1 hash! mxs-dcp: probe of 80028000.dcp failed with error -22 There were some previous attempts to fix this, and the following feedback was given by Herbert Xu [1]: "This driver is hop

[PATCH] crypto: mxs-dcp - Remove hash support

2016-10-24 Thread Fabio Estevam
From: Fabio Estevam mxs-dcp driver does not probe for a long time: mxs-dcp 80028000.dcp: Failed to register sha1 hash! mxs-dcp: probe of 80028000.dcp failed with error -22 There were some previous attempts to fix this, and the following feedback was given by Herbert Xu's [1]: "This driver is h

[PATCH -next] crypto: drop pointless static qualifier in atmel_aes_probe()

2016-10-24 Thread Wei Yongjun
From: Wei Yongjun There is no need to have the 'struct atmel_aes_dev *aes_dd' variable static since new value always be assigned before use it. Signed-off-by: Wei Yongjun --- drivers/crypto/atmel-aes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/atmel-aes

Re: [PATCH v1] char: hw_random: atmel-rng: disable TRNG during suspend

2016-10-24 Thread Nicolas Ferre
Le 24/10/2016 à 10:03, Wenyou Yang a écrit : > To fix the over consumption on the VDDCore due to the TRNG enabled, > disable the TRNG during suspend, not only disable the user interface > clock (which is controlled by PMC). Because the user interface clock > is independent from any clock that may b

[PATCH v1] char: hw_random: atmel-rng: disable TRNG during suspend

2016-10-24 Thread Wenyou Yang
To fix the over consumption on the VDDCore due to the TRNG enabled, disable the TRNG during suspend, not only disable the user interface clock (which is controlled by PMC). Because the user interface clock is independent from any clock that may be used in the entropy source logic circuitry. Signed