[PATCH] crypto: testmgr: Use linear alias for test input

Christopher Covington reported a crash on aarch64 on recent Fedora kernels: kernel BUG at ./include/linux/scatterlist.h:140! Internal error: Oops - BUG: 0 [#1] PREEMPT SMP Modules linked in: CPU: 2 PID: 752 Comm: cryptomgr_test Not tainted 4.9.0-11815-ge93b1cc #162 Hardware name: linux,dummy-virt

Re: HalfSipHash Acceptable Usage

Hi JP, On Mon, Dec 19, 2016 at 9:49 PM, Jean-Philippe Aumasson wrote: > > On Mon, Dec 19, 2016 at 6:32 PM Jason A. Donenfeld wrote: >> >> Hi JP, >> >> With the threads getting confusing, I've been urged to try and keep >> the topics and threads

RE: [PATCH v5 1/4] siphash: add cryptographically secure PRF

David Laight wrote: > From: George Spelvin ... >> uint32_t >> hsiphash24(char const *in, size_t len, uint32_t const key[2]) >> { >> uint32_t c = key[0]; >> uint32_t d = key[1]; >> uint32_t a = 0x6c796765 ^ 0x736f6d65; >> uint32_t b = d ^ 0x74656462 ^ 0x646f7261; > I've not

HalfSipHash Acceptable Usage

Hi JP, With the threads getting confusing, I've been urged to try and keep the topics and threads more closely constrained. Here's where we're at, and here's the current pressing security concern. It'd be helpful to have a definitive statement on what you think is best, so we can just build on

Re: [kernel-hardening] Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF

Hi Ted, On Sat, Dec 17, 2016 at 4:41 PM, Theodore Ts'o wrote: > On Fri, Dec 16, 2016 at 09:15:03PM -0500, George Spelvin wrote: >> >> - Ted, Andy Lutorminski and I will try to figure out a construction of >> >> get_random_long() that we all like. > > We don't have to find the

Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF

On Sat, Dec 17, 2016 at 3:55 PM, Jeffrey Walton wrote: > It may be prudent to include the endian reversal in the test to ensure > big endian machines produce expected results. Some closely related > testing on an old Apple PowerMac G5 revealed that result needed to be >

Re: [RFC PATCH 1/3] crypto: zip - Add ThunderX ZIP driver core

On Mon, Dec 12, 2016 at 10:04 AM, Jan Glauber wrote: > +/* error messages */ > +#define zip_err(fmt, args...) pr_err("ZIP ERR:%s():%d: " \ > + fmt "\n", __func__, __LINE__, ## args) > + > +#ifdef MSG_ENABLE > +/* Enable all messages */ > +#define

Re: [RFC PATCH 1/3] crypto: zip - Add ThunderX ZIP driver core

Hi Corentin, thanks for your review! Your comments all look reasonable to me, Mahipal will address them. Since I posted this series at the beginning of the merge window I'd like to wait for some more time before we post an updated version. --Jan On Tue, Dec 13, 2016 at 02:39:00PM +0100,

RE: [PATCH v5 1/4] siphash: add cryptographically secure PRF

From: George Spelvin > Sent: 17 December 2016 15:21 ... > uint32_t > hsiphash24(char const *in, size_t len, uint32_t const key[2]) > { > uint32_t c = key[0]; > uint32_t d = key[1]; > uint32_t a = 0x6c796765 ^ 0x736f6d65; > uint32_t b = d ^ 0x74656462 ^ 0x646f7261; I've

Re: Test AEAD/authenc algorithms from userspace

Hi Herbert, TLS default mode of operation is MAC-then-Encrypt for Authenc algos. Currently framework only supports EtM used in IPSec. User space programs like openssl cannot use af-alg interface to encrypt/decrypt in TLS mode. Are we going to support Mac-then-Encrypt mode in future kernel