Re: [PATCH v2 9/9] crypto: ccp - Use IPAD/OPAD constant

2017-05-19 Thread Gary R Hook
On 5/19/2017 1:53 AM, Corentin Labbe wrote: This patch simply replace all occurrence of HMAC IPAD/OPAD value by their define. Signed-off-by: Corentin Labbe Acked-by: Gary R Hook --- drivers/crypto/ccp/ccp-crypto-sha.c | 5 +++-- 1 file

Re: [PATCH v2 4/9] crypto: marvell - Use IPAD/OPAD constant

2017-05-19 Thread Boris Brezillon
On Fri, 19 May 2017 08:53:26 +0200 Corentin Labbe wrote: > This patch simply replace all occurrence of HMAC IPAD/OPAD value by their > define. > > Signed-off-by: Corentin Labbe Acked-by: Boris Brezillon

Re: [PATCH v2 8/9] crypto: mediatek - Use IPAD/OPAD constant

2017-05-19 Thread Matthias Brugger
On 19/05/17 08:53, Corentin Labbe wrote: This patch simply replace all occurrence of HMAC IPAD/OPAD value by their define. Signed-off-by: Corentin Labbe --- Reviewed-by: Matthias Brugger drivers/crypto/mediatek/mtk-sha.c | 5 +++-- 1

[PATCH] staging: ccree: add CRYPTO dependency

2017-05-19 Thread Arnd Bergmann
A rare randconfig build error shows up when we have CONFIG_CRYPTO=m in combination with a built-in CCREE driver: crypto/hmac.o: In function `hmac_update': hmac.c:(.text.hmac_update+0x28): undefined reference to `crypto_shash_update' crypto/hmac.o: In function `hmac_setkey':

[PATCH v2 3/9] crypto: ixp4xx - Use IPAD/OPAD constant

2017-05-19 Thread Corentin Labbe
This patch simply replace all occurrence of HMAC IPAD/OPAD value by their define. Signed-off-by: Corentin Labbe --- drivers/crypto/ixp4xx_crypto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/ixp4xx_crypto.c

[PATCH v2 4/9] crypto: marvell - Use IPAD/OPAD constant

2017-05-19 Thread Corentin Labbe
This patch simply replace all occurrence of HMAC IPAD/OPAD value by their define. Signed-off-by: Corentin Labbe --- drivers/crypto/marvell/hash.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/marvell/hash.c

[PATCH v2 5/9] crypto: mv_cesa - Use IPAD/OPAD constant

2017-05-19 Thread Corentin Labbe
This patch simply replace all occurrence of HMAC IPAD/OPAD value by their define. Signed-off-by: Corentin Labbe --- drivers/crypto/mv_cesa.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c

[PATCH v2 2/9] crypto: brcm - Use IPAD/OPAD constant

2017-05-19 Thread Corentin Labbe
This patch simply replace all occurrence of HMAC IPAD/OPAD value by their define. Signed-off-by: Corentin Labbe --- drivers/crypto/bcm/cipher.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/bcm/cipher.c

[PATCH v2 0/9] crypto: add HMAC IPAD/OPAD constant

2017-05-19 Thread Corentin Labbe
Hello Many HMAC users directly use directly 0x36/0x5c values. It's better with crypto to use a name instead of directly some crypto constant. Changes since v1: - Moved constant to include/crypto/hmac.h - Added to includes Corentin Labbe (9): crypto: add hmac IPAD/OPAD constant crypto: brcm

[PATCH v2 9/9] crypto: ccp - Use IPAD/OPAD constant

2017-05-19 Thread Corentin Labbe
This patch simply replace all occurrence of HMAC IPAD/OPAD value by their define. Signed-off-by: Corentin Labbe --- drivers/crypto/ccp/ccp-crypto-sha.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ccp/ccp-crypto-sha.c

[PATCH v2 7/9] crypto: qat - Use IPAD/OPAD constant

2017-05-19 Thread Corentin Labbe
This patch simply replace all occurrence of HMAC IPAD/OPAD value by their define. Signed-off-by: Corentin Labbe --- drivers/crypto/qat/qat_common/qat_algs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v2 6/9] crypto: omap-sham - Use IPAD/OPAD constant

2017-05-19 Thread Corentin Labbe
This patch simply replace all occurrence of HMAC IPAD/OPAD value by their define. Signed-off-by: Corentin Labbe --- drivers/crypto/omap-sham.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/omap-sham.c

[PATCH v2 8/9] crypto: mediatek - Use IPAD/OPAD constant

2017-05-19 Thread Corentin Labbe
This patch simply replace all occurrence of HMAC IPAD/OPAD value by their define. Signed-off-by: Corentin Labbe --- drivers/crypto/mediatek/mtk-sha.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/mediatek/mtk-sha.c

[PATCH v2 1/9] crypto: add hmac IPAD/OPAD constant

2017-05-19 Thread Corentin Labbe
Many HMAC users directly use directly 0x36/0x5c values. It's better with crypto to use a name instead of directly some crypto constant. This patch simply add HMAC_IPAD_VALUE/HMAC_OPAD_VALUE defines in a new include file "crypto/hmac.h" and use them in crypto/hmac.c Signed-off-by: Corentin Labbe