Re: [PATCH] staging: ccree: local variable "dev" not required

2017-10-05 Thread Suniel Mahesh
On Thursday 05 October 2017 11:30 PM, Joe Perches wrote: > On Thu, 2017-10-05 at 10:07 +0300, Gilad Ben-Yossef wrote: >> On Wed, Oct 4, 2017 at 10:12 PM, wrote: >>> There is no need to create a local pointer variable "dev" and >>> pass it various API's, instead use plat_dev

Re: [PATCH 0/8] KEYS: keyctl operations for asymmetric keys [ver #2]

2017-10-05 Thread George Wilson
On Thu, Jun 23, 2016 at 02:47:34PM +0100, David Howells wrote: > > Here's a set of patches that provides keyctl access for asymmetric keys, > including a query function, and functions to do encryption, decryption, > signature creation and signature verification. > > I've added a PKCS#8

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-05 Thread Marcelo Ricardo Leitner
On Thu, Oct 05, 2017 at 09:16:31PM +0800, Herbert Xu wrote: > On Thu, Oct 05, 2017 at 06:16:20PM +0800, Herbert Xu wrote: > > > > That was my point. Functions like sctp_pack_cookie shouldn't be > > setting the key in the first place. The setkey should happen at > > the point when the key is

Re: [PATCH] staging: ccree: local variable "dev" not required

2017-10-05 Thread Joe Perches
On Thu, 2017-10-05 at 10:07 +0300, Gilad Ben-Yossef wrote: > On Wed, Oct 4, 2017 at 10:12 PM, wrote: > > There is no need to create a local pointer variable "dev" and > > pass it various API's, instead use plat_dev which is enumerated > > by platform core on successful

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-05 Thread Herbert Xu
On Thu, Oct 05, 2017 at 06:16:20PM +0800, Herbert Xu wrote: > > That was my point. Functions like sctp_pack_cookie shouldn't be > setting the key in the first place. The setkey should happen at > the point when the key is generated. That's sctp_endpoint_init > which AFAICS only gets called in

Re: [PATCH 5/6] crypto: talitos - use kzalloc instead of kmalloc

2017-10-05 Thread Christophe LEROY
Le 21/09/2017 à 09:19, Christophe Leroy a écrit : Use kzalloc() to zeroize the extended descriptor at allocation and further zeorising This patch significantly degrades performances. I will submit a new serie soon. Christophe Signed-off-by: Christophe Leroy ---

Re: [PATCH] staging: ccree: local variable "dev" not required

2017-10-05 Thread Gilad Ben-Yossef
Hi Suniel, On Wed, Oct 4, 2017 at 10:12 PM, wrote: > From: Suniel Mahesh > > There is no need to create a local pointer variable "dev" and > pass it various API's, instead use plat_dev which is enumerated > by platform core on successful probe. > >