Re: [PATCH 0/4] KVM: SVM: kbuild test robot warning fixes

On 15/01/2018 14:32, Brijesh Singh wrote: > The patch series fixes the warnings reported by kbuild test robot > after SEV patches. Additionally, during testing I found that LAUNCH_SECRET > command was broken and patch series contains the fix for it. > > The patch series applies on kvm/queue

Re: [PATCH v3 0/4] crypto: aesni - Use zero-copy for gcm(aes) buffers that are partially contiguous

On 02/22/2018 06:50 AM, Herbert Xu wrote: > > I think this conflicts with Dave Watson's work. Could you rebase > this on top of his patches? > > Thanks, > Hi Herbert, I'll try to send a new version rebased on top of Dave's patches, but it might be some time before I can get to it. I guess

[PATCH] crypto/ccp: don't disable interrupts while setting up debugfs

I don't why we need take a single write lock and disable interrupts while setting up debugfs. This is what what happens when we try anyway: |ccp :03:00.2: enabling device ( -> 0002) |BUG: sleeping function called from invalid context at kernel/locking/rwsem.c:69 |in_atomic(): 1,

Re: [Crypto v7 03/12] tls: support for inline tls

On 02/23/18 04:58 PM, Atul Gupta wrote: > > On 02/22/18 11:21 PM, Atul Gupta wrote: > > > @@ -403,6 +431,15 @@ static int do_tls_setsockopt_tx(struct sock *sk, > > > char __user *optval, > > > goto err_crypto_info; > > > } > > > > > > + rc = tls_offload_dev_absent(sk); > > > + if

RE: [Crypto v7 03/12] tls: support for inline tls

-Original Message- From: Dave Watson [mailto:davejwat...@fb.com] Sent: Friday, February 23, 2018 9:53 PM To: Atul Gupta Cc: da...@davemloft.net; herb...@gondor.apana.org.au; s...@queasysnail.net; linux-crypto@vger.kernel.org; net...@vger.kernel.org; Ganesh GR

Re: [Crypto v7 03/12] tls: support for inline tls

On 02/22/18 11:21 PM, Atul Gupta wrote: > @@ -403,6 +431,15 @@ static int do_tls_setsockopt_tx(struct sock *sk, char > __user *optval, > goto err_crypto_info; > } > > + rc = tls_offload_dev_absent(sk); > + if (rc == -EINVAL) { > + goto out; > + } else

Re: [Crypto v7 00/12] Chelsio Inline TLS

If nobody is going to actually review these changes for substance and give real feedback, I will just keep picking the patch series apart with coding style nitpicks until somebody does. You have been warned :-)

Re: [PATCH] crypto: atmel-aes - fix the keys zeroing on errors

Hi Tudor, On Fri, Feb 23, 2018 at 02:04:33PM +0200, Tudor Ambarus wrote: > > There are few other places in crypto where we extract the authenc keys > in the same type of local variable, struct crypto_authenc_keys keys, and > we don't zeroize it after use. I think we should fix those cases too.

Re: [PATCH] crypto: atmel-aes - fix the keys zeroing on errors

Thanks Antoine, On 02/23/2018 11:01 AM, Antoine Tenart wrote: The Atmel AES driver uses memzero_explicit on the keys on error, but the variable zeroed isn't the right one because of a typo. Fix this by using the right variable. Fixes: 89a82ef87e01 ("crypto: atmel-authenc - add support to

Re: [PATCH v3 0/4] crypto: AF_ALG AIO improvements

On Fri, Feb 23, 2018 at 09:33:33AM +0100, Stephan Müller wrote: > > A simple copy operation, however, will imply that in one AIO recvmsg request, > only *one* IOCB can be set and processed. Sure, but the recvmsg will return as soon as the crypto API encrypt or decrypt function returns. It's

[PATCH] crypto: atmel-aes - fix the keys zeroing on errors

The Atmel AES driver uses memzero_explicit on the keys on error, but the variable zeroed isn't the right one because of a typo. Fix this by using the right variable. Fixes: 89a82ef87e01 ("crypto: atmel-authenc - add support to authenc(hmac(shaX), Y(aes)) modes") Signed-off-by: Antoine Tenart

Re: [PATCH] Remove useless assignment in rsa_verify

Hi, Ben, On 02/22/2018 07:16 PM, C0deAi wrote: Hi my name is Benjamin Bales. I am the founder and creator of CodeAI, the first non-human contributor to your software project. CodeAI finds and fixes security defects for you. It fixed 327. It wants to merge a fix for a useless assignment. To

Re: [PATCH v3 0/4] crypto: AF_ALG AIO improvements

Am Donnerstag, 22. Februar 2018, 14:06:00 CET schrieb Herbert Xu: Hi Herbert, > On Fri, Feb 09, 2018 at 11:02:27PM +0100, Stephan Müller wrote: > > Hi, > > > > Herbert, the patch 1 is meant for stable. However, this patch as is > > only applies to the new AF_ALG interface implementation.

Re: [2/2] crypto: bcm: One function call less in do_shash() after error detection

> This patch is pointless as kfree on NULL is a no-op. I prefer to avoid unnecessary function calls generally. Regards, Markus