[PATCH v3 2/2] crypto: authencesn - don't leak pointers to authenc keys

2018-04-02 Thread Tudor Ambarus
In crypto_authenc_esn_setkey we save pointers to the authenc keys in a local variable of type struct crypto_authenc_keys and we don't zeroize it after use. Fix this and don't leak pointers to the authenc keys. Signed-off-by: Tudor Ambarus --- crypto/authencesn.c | 1 + 1 file changed, 1 insertio

[PATCH v3 1/2] crypto: authenc - don't leak pointers to authenc keys

2018-04-02 Thread Tudor Ambarus
In crypto_authenc_setkey we save pointers to the authenc keys in a local variable of type struct crypto_authenc_keys and we don't zeroize it after use. Fix this and don't leak pointers to the authenc keys. Signed-off-by: Tudor Ambarus --- crypto/authenc.c | 1 + 1 file changed, 1 insertion(+) d

Re: [PATCH] crypto: rsa - remove unneeded initializations

2018-04-02 Thread Tudor Ambarus
On 03/30/2018 08:27 PM, Herbert Xu wrote: On Mon, Mar 26, 2018 at 02:59:06PM +0300, Tudor Ambarus wrote: Remove useless assignment of ret to -ENOMEM in rsa_verify. Remove useless initialization of ret to zero at declaration in rsa_enc/dec/sign/verify. Benefit of the power of undefined values