Re: [PATCH v2] crypto: caam: - Use kmemdup() function

2018-04-16 Thread Horia Geantă
On 4/16/2018 7:07 PM, Fabio Estevam wrote: > From: Fabio Estevam > > Use kmemdup() rather than duplicating its implementation. > > By usign kmemdup() we can also get rid of the 'val' variable. > > Detected with Coccinelle script. > > Signed-off-by: Fabio Estevam Reviewed-by: Horia Geantă Th

[PATCH] crypto: api - fix finding algorithm currently being tested

2018-04-16 Thread Eric Biggers
From: Eric Biggers Commit eb02c38f0197 ("crypto: api - Keep failed instances alive") is making allocating crypto transforms sometimes fail with ELIBBAD, when multiple processes try to access encrypted files with fscrypt for the first time since boot. The problem is that the "request larval" for

Proposal

2018-04-16 Thread MS Zeliha Omer Faruk
Hello Greeetings to you please did you get my previous email regarding my investment proposal last week friday ? MS.Zeliha ömer faruk zeliha.omer.fa...@gmail.com

Re: [PATCH] crypto: caam - strip input zeros from RSA input buffer

2018-04-16 Thread Martin Townsend
On Mon, Apr 16, 2018 at 10:34 AM, Horia Geantă wrote: > Sometimes the provided RSA input buffer provided is not stripped > of leading zeros. This could cause its size to be bigger than that > of the modulus, making the HW complain: > > caam_jr 2142000.jr1: 4789: DECO: desc idx 7: > Protocol Si

Re: [PATCH 0/1] cover-letter/lz4: Implement lz4 with dynamic offset length.

2018-04-16 Thread Eric Biggers
On Mon, Apr 16, 2018 at 07:34:29PM +, Yann Collet wrote: > Hi Singh > > I don't have any strong opinion on this topic. > > You made your case clear: > your variant trades a little bit of speed for a little bit more compression > ratio. > In the context of zram, it makes sense, and I would e

Re: [PATCH 0/1] cover-letter/lz4: Implement lz4 with dynamic offset length.

2018-04-16 Thread Yann Collet
Hi Singh I don't have any strong opinion on this topic. You made your case clear: your variant trades a little bit of speed for a little bit more compression ratio. In the context of zram, it makes sense, and I would expect it to work, as advertised in your benchmark results. (disclaimer: I ha

[PATCH v2] crypto: caam: - Use kmemdup() function

2018-04-16 Thread Fabio Estevam
From: Fabio Estevam Use kmemdup() rather than duplicating its implementation. By usign kmemdup() we can also get rid of the 'val' variable. Detected with Coccinelle script. Signed-off-by: Fabio Estevam --- Changes since v1: - Drop the val variable and return kmemdup() directly. drivers/cryp

Re: [PATCH v2] crypto/ecc: Actually remove stack VLA usage

2018-04-16 Thread Kees Cook
On Fri, Mar 30, 2018 at 9:55 AM, Kees Cook wrote: > On the quest to remove all VLAs from the kernel[1], this avoids VLAs > by just using the maximum allocation size (4 bytes) for stack arrays. > All the VLAs in ecc were either 3 or 4 bytes (or a multiple), so just > make it 4 bytes all the time. I

Re: [PATCH RESEND] crypto: caam - strip input zeros from RSA input buffer

2018-04-16 Thread Tudor Ambarus
On 04/16/2018 04:07 PM, Horia Geantă wrote: Sometimes the provided RSA input buffer provided is not stripped of leading zeros. This could cause its size to be bigger than that of the modulus, making the HW complain: caam_jr 2142000.jr1: 4789: DECO: desc idx 7: Protocol Size Error - A proto

Re: [PATCH] crypto: caam: - Use kmemdup() function

2018-04-16 Thread Horia Geantă
On 4/16/2018 5:08 PM, Fabio Estevam wrote: > From: Fabio Estevam > > Use kmemdup() rather than duplicating its implementation. > > Detected with Coccinelle script. > > Signed-off-by: Fabio Estevam > --- > drivers/crypto/caam/caampkc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-)

Re: [PATCH] crypto: caam: - Use kmemdup() function

2018-04-16 Thread Corentin Labbe
On Mon, Apr 16, 2018 at 11:05:14AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Use kmemdup() rather than duplicating its implementation. > > Detected with Coccinelle script. > > Signed-off-by: Fabio Estevam > --- > drivers/crypto/caam/caampkc.c | 4 +--- > 1 file changed, 1 insertio

[PATCH] crypto: caam: - Use kmemdup() function

2018-04-16 Thread Fabio Estevam
From: Fabio Estevam Use kmemdup() rather than duplicating its implementation. Detected with Coccinelle script. Signed-off-by: Fabio Estevam --- drivers/crypto/caam/caampkc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/c

Re: [PATCH RESEND] crypto: caam - strip input zeros from RSA input buffer

2018-04-16 Thread Fabio Estevam
On Mon, Apr 16, 2018 at 10:07 AM, Horia Geantă wrote: > Sometimes the provided RSA input buffer provided is not stripped > of leading zeros. This could cause its size to be bigger than that > of the modulus, making the HW complain: > > caam_jr 2142000.jr1: 4789: DECO: desc idx 7: > Protocol Si

Re: [PATCH v3] crypto: caam: Drop leading zero from input buffer

2018-04-16 Thread Horia Geantă
On 4/15/2018 6:51 PM, Martin Townsend wrote: > On Sun, Apr 15, 2018 at 3:12 PM, Fabio Estevam wrote: >> From: Fabio Estevam >> >> imx6ul and imx7 report the following error: >> >> caam_jr 2142000.jr1: 4789: DECO: desc idx 7: >> Protocol Size Error - A protocol has seen an error in size. When

[PATCH RESEND] crypto: caam - strip input zeros from RSA input buffer

2018-04-16 Thread Horia Geantă
Sometimes the provided RSA input buffer provided is not stripped of leading zeros. This could cause its size to be bigger than that of the modulus, making the HW complain: caam_jr 2142000.jr1: 4789: DECO: desc idx 7: Protocol Size Error - A protocol has seen an error in size. When running RSA,

Re: [PATCH 0/1] cover-letter/lz4: Implement lz4 with dynamic offset length.

2018-04-16 Thread Maninder Singh
 Hello Nick/ Yann, Any inputs regarding LZ4 dyn results & lz4 dyn approach. >Hello Nick/Sergey, > >Any suggestion or comments, so that we can change code and resend the patch? > >> Hi Nick / Sergey, >> >> >> We have compared LZ4 Dyn with Original LZ4 using some samples of realtime >> applic