Re: [PATCH] crypto: ccree: limit build to plausible archs

2018-04-23 Thread Geert Uytterhoeven
Hi Gilad, On Mon, Apr 23, 2018 at 3:22 PM, Gilad Ben-Yossef wrote: > On Mon, Apr 23, 2018 at 3:13 PM, Geert Uytterhoeven > wrote: >> On Mon, Apr 23, 2018 at 1:48 PM, Gilad Ben-Yossef >> wrote: >>> Limit option to compile ccree to

Re: GCM and XTS: kcapi result not matching with NIST vectors

2018-04-23 Thread Stephan Mueller
Am Montag, 23. April 2018, 07:51:35 CEST schrieb Jitendra Lulla: Hi Jitendra, > > TEST 2: > > Similarly for XTS also we have one mismatch: > https://csrc.nist.gov/CSRC/media/Projects/Cryptographic-Algorithm-Validation > -Program/documents/aes/XTSTestVectors.zip > > /XTSTestVectors/format

[PATCH 0/2] Fix stm32-rng for default state and suspend

2018-04-23 Thread Lionel Debieve
This series are fixing the default build state for stm32-rng that activate the driver with arm multi_v7_defconfig. Second patch is fixing the power suspend/resume behavior which was not working. Lionel Debieve (2): hwrng: stm32 - define default state for rng driver hwrng: stm32-rng: Fix

[PATCH 1/2] hwrng: stm32 - define default state for rng driver

2018-04-23 Thread Lionel Debieve
Define default state for stm32_rng driver. It will be default selected with multi_v7_defconfig Signed-off-by: Lionel Debieve --- drivers/char/hw_random/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/hw_random/Kconfig

[PATCH 2/2] hwrng: stm32-rng - fix pm_suspend issue

2018-04-23 Thread Lionel Debieve
When suspend is called after pm_runtime_suspend, same callback is used and access to rng register is freezing system. By calling the pm_runtime_force_suspend, it first checks that runtime has been already done. Signed-off-by: Lionel Debieve ---

Re: [PATCH] crypto: ccree: limit build to plausible archs

2018-04-23 Thread Gilad Ben-Yossef
On Mon, Apr 23, 2018 at 3:13 PM, Geert Uytterhoeven wrote: > Hi Gilad, > > On Mon, Apr 23, 2018 at 1:48 PM, Gilad Ben-Yossef wrote: >> Limit option to compile ccree to plausible architectures. > > Thanks for your patch! > >> Suggested-by: Geert

Re: [PATCH] crypto: ccree: limit build to plausible archs

2018-04-23 Thread Geert Uytterhoeven
Hi Gilad, On Mon, Apr 23, 2018 at 1:48 PM, Gilad Ben-Yossef wrote: > Limit option to compile ccree to plausible architectures. Thanks for your patch! > Suggested-by: Geert Uytterhoeven > Signed-off-by: Gilad Ben-Yossef > --- >

[PATCH] crypto: ccree: limit build to plausible archs

2018-04-23 Thread Gilad Ben-Yossef
Limit option to compile ccree to plausible architectures. Suggested-by: Geert Uytterhoeven Signed-off-by: Gilad Ben-Yossef --- drivers/crypto/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig

Re: WARNING: kernel stack regs at (ptrval) in syzkaller has bad 'bp' value (ptrval)

2018-04-23 Thread Dmitry Vyukov
On Mon, Apr 23, 2018 at 12:10 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 5ec83b22a2dd13180762c89698e4e2c2881a423c (Sun Apr 22 19:13:04 2018 +) > Merge tag '4.17-rc1-SMB3-CIFS' of

Re: [PATCH/RFC] crypto: Add platform dependencies for CRYPTO_DEV_CCREE

2018-04-23 Thread Geert Uytterhoeven
Hi Gilad, On Mon, Apr 23, 2018 at 9:45 AM, Gilad Ben-Yossef wrote: > On Wed, Apr 18, 2018 at 10:47 AM, Geert Uytterhoeven > wrote: >> On Wed, Apr 18, 2018 at 6:32 AM, Gilad Ben-Yossef >> wrote: >>> On Tue, Apr 17, 2018 at 9:14

Re: [PATCH/RFC] crypto: Add platform dependencies for CRYPTO_DEV_CCREE

2018-04-23 Thread Gilad Ben-Yossef
On Wed, Apr 18, 2018 at 10:47 AM, Geert Uytterhoeven wrote: > Hi Gilad, > > On Wed, Apr 18, 2018 at 6:32 AM, Gilad Ben-Yossef wrote: >> On Tue, Apr 17, 2018 at 9:14 PM, Geert Uytterhoeven >> wrote: >>> The ARM TrustZone CryptoCell

Re: GCM and XTS: kcapi result not matching with NIST vectors

2018-04-23 Thread Stephan Mueller
Am Montag, 23. April 2018, 07:51:35 CEST schrieb Jitendra Lulla: Hi Jitendra, > Hi, > > Consider the following 2 invocations from kcapi and the results we get > from it. They are not matching with the NIST vectors [links pasted > below]. > > Could somebody please tell why that could be

[PATCH v2 2/2] crypto: ccree: use proper printk format

2018-04-23 Thread Gilad Ben-Yossef
Fix incorrect use of %pad as a printk format string for none dma_addr_t variable. Discovered via smatch. Signed-off-by: Gilad Ben-Yossef --- drivers/crypto/ccree/cc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 1/2] crypto: ccree: enable support for hardware keys

2018-04-23 Thread Gilad Ben-Yossef
Enable CryptoCell support for hardware keys. Hardware keys are regular AES keys loaded into CryptoCell internal memory via firmware, often from secure boot ROM or hardware fuses at boot time. As such, they can be used for enc/dec purposes like any other key but cannot (read: extremely hard to)

[PATCH v2 0/2] cleanup and hardware keys

2018-04-23 Thread Gilad Ben-Yossef
Small cleanup and add support for CryptoCell hardware keys. Changes from v1: - The cleanup patch is new, as Herbert took the previous one :-) - Hardware key API uses the "paes" designator to indicate a protected key, same as s390, as per Herbert preference - Avoid direct casting and reference

Re: [PATCH 2/2] crypto: ccree: enable support for hardware keys

2018-04-23 Thread Gilad Ben-Yossef
On Thu, Apr 19, 2018 at 6:35 AM, Herbert Xu wrote: > On Mon, Apr 09, 2018 at 11:42:31AM +0300, Gilad Ben-Yossef wrote: >> >> Please look again. The stub version of cc_is_hw_key() doing that is being >> replaced in this patch. > > The point is that the existing