RE: [PATCH V8 1/5] crypto: Multi-buffer encryption infrastructure support

>-Original Message- >From: Herbert Xu [mailto:herb...@gondor.apana.org.au] >Sent: Thursday, April 26, 2018 2:45 AM >To: Dey, Megha >Cc: linux-ker...@vger.kernel.org; linux-crypto@vger.kernel.org; >da...@davemloft.net >Subject: Re: [PATCH V8 1/5] crypto: Multi-buffer

[PATCH v2 7/7] crypto: chtls: HW supported socket opt

HW supported socket options are handled by HW while rest are handled by SW Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h | 10 ++ drivers/crypto/chelsio/chtls/chtls_cm.h | 12 ++ drivers/crypto/chelsio/chtls/chtls_hw.c | 2 +-

[PATCH v2 6/7] crypto: chtls: generic handling of data and hdr

removed redundant check and made TLS PDU and header recv handling common as received from HW Signed-off-by: Atul Gupta Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/chtls/chtls.h| 10 ++ drivers/crypto/chelsio/chtls/chtls_cm.c | 12

[PATCH v2 5/7] crypto: chtls: free beyond end rspq_skb_cache

Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_main.c

[PATCH v2 1/7] crypto: chtls: wait for memory sendmsg, sendpage

Reported-by: Gustavo A. R. Silva Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h | 1 + drivers/crypto/chelsio/chtls/chtls_io.c | 90 +-- drivers/crypto/chelsio/chtls/chtls_main.c | 1 + 3

[PATCH v2 3/7] crypto: chtls: dereference null variable

skb dereferenced before check in sendpage Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH v2 2/7] crypto:chtls: key len correction

corrected the key length to copy 128b key. Removed 192b and 256b key as user input supports key of size 128b in gcm_ctx Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_hw.c | 6 +- 1 file changed,

[PATCH v2 4/7] crypto: chtls: kbuild warnings

- unindented continue - check for null page - signed return Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git