On Fri, Mar 15, 2019 at 07:40:18PM +0100, Petr Vorel wrote:
> Hi Eric,
>
> > > you forget to add af_alg03 into runtest/cve.
> > > The same applies to af_alg0{4,5}.
>
> > As far as I know, there are no CVEs assigned for those bugs.
> Wouldn't be better to add them to runtest/cve (or other runtest
Hi Eric,
> > you forget to add af_alg03 into runtest/cve.
> > The same applies to af_alg0{4,5}.
> As far as I know, there are no CVEs assigned for those bugs.
Wouldn't be better to add them to runtest/cve (or other runtest file) just with
filename? And rename them in runtest file once the CVEs ar
Hi Petr,
On Fri, Mar 15, 2019 at 10:29:53AM +0100, Petr Vorel wrote:
> Hi Eric,
>
> you forget to add af_alg03 into runtest/cve.
> The same applies to af_alg0{4,5}.
>
>
> Kind regards,
> Petr
As far as I know, there are no CVEs assigned for those bugs.
- Eric
In caam_jr_enqueue(), a write barrier is needed to order stores to job
ring slot before declaring addition of new job into input job ring.
The register write is done using wr_reg32() which internally uses
iowrite32() for write operation. The api iowrite32() issues a write
barrier before issuing wri
This patchset cleans up caam job ring driver.
The patch series needs to be applied after merging below mentioned
patch.
https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg37068.html
Vakul Garg (3):
crypto: caam/jr - Remove spinlock for output job ring
crypto: caam/jr - Remove redund
For each job ring pair, the output ring is processed exactly by one cpu
at a time under a tasklet context (one per ring). Therefore, there is no
need to protect a job ring's access & its private data structure using a
lock. Hence the lock can be removed.
Signed-off-by: Vakul Garg
---
Changes sinc
For each job ring, the variable 'ringsize' is initialised but never
used. Similarly variables 'inp_ring_read_index' and 'head' always track
the same value and instead of 'inp_ring_read_index', caam_jr_enqueue()
can use 'head' itself. Both these variables have been removed.
Signed-off-by: Vakul Gar
Hi Eric,
apart from missing AF_ALG for old distros and missing record
in runtest/cve for af_alg0[3-5] LGTM.
Sorry for delay with the review.
Reviewed-by: Petr Vorel
Kind regards,
Petr
> Hello,
> This series adds helper functions for testing AF_ALG (the userspace
> interface to algorithms in
Hi Eric,
> +static void run(void)
> +{
> + /* try several different unkeyed hash algorithms */
> + static const char * const hash_algs[] = {
> + "md5", "md5-generic",
> + "sha1", "sha1-generic",
> + "sha224", "sha224-generic",
> + "sha256", "
Hi Eric,
> From: Eric Biggers
> Add helper functions for creating and using AF_ALG sockets. AF_ALG is
> the userspace interface to algorithms in the Linux kernel's crypto API.
> See https://www.kernel.org/doc/html/latest/crypto/userspace-if.html for
> more information about this interface.
AF_
Hi Eric,
you forget to add af_alg03 into runtest/cve.
The same applies to af_alg0{4,5}.
Kind regards,
Petr
Hi Vakul,
On Fri, 15 Mar 2019 at 04:05, Vakul Garg wrote:
> For each job ring pair, the output ring is processed exactly by one cpu
> at a time under a tasklet context (one per ring). Therefore, there is no
> need to protect a job ring's access & its private data structure using a
> lock. Hence t
Spotted while reviewind patches from Eric Biggers.
Signed-off-by: Ondrej Mosnacek
---
crypto/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/crypto/Kconfig b/crypto/Kconfig
index bbab6bf33519..93270797e04a 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -312
Hi Eric,
On Sun, Mar 10, 2019 at 8:02 PM Eric Biggers wrote:
> This series updates crypto_simd to support wrapping AEADs, then makes
> all AEADs that implement the same functionality use crypto_simd instead.
>
> This simplifies the code, and it also fixes the bug where these
> algorithms modify t
14 matches
Mail list logo
