Re: [LTP] [PATCH v2 0/6] ltp: AF_ALG test helpers and a few regression tests

2019-03-18 Thread Petr Vorel
Hi Eric, > > Changed since v1: > > - Define 'AF_ALG' in include/lapi/socket.h if undefined. > > Also move 'SOL_ALG' definition to there. > The only minor issue is with missing SOL_ALG on older distros. > Going to push it with this fix including lapi/socket.h on lib/tst_af_alg.c and > t

Re: [LTP] [PATCH v2 0/6] ltp: AF_ALG test helpers and a few regression tests

2019-03-18 Thread Petr Vorel
Hi Eric, > This series adds helper functions for testing AF_ALG (the userspace > interface to algorithms in the Linux kernel's crypto API) to the > Linux Test Project. It then adds a few sample regression tests. > I've had these patches sitting around for a while with the goal of also > writing

[PATCH v2 2/6] crypto/af_alg01: new regression test for hmac nesting bug

2019-03-18 Thread Eric Biggers
From: Eric Biggers Signed-off-by: Eric Biggers --- runtest/crypto | 1 + runtest/cve| 1 + testcases/kernel/crypto/.gitignore | 1 + testcases/kernel/crypto/af_alg01.c | 78 ++ 4 files changed, 81 insertions(+) create m

[PATCH v2 4/6] crypto/af_alg03: new regression test for rfc7539 hash alg validation

2019-03-18 Thread Eric Biggers
From: Eric Biggers Signed-off-by: Eric Biggers --- runtest/crypto | 1 + testcases/kernel/crypto/.gitignore | 1 + testcases/kernel/crypto/af_alg03.c | 31 ++ 3 files changed, 33 insertions(+) create mode 100644 testcases/kernel/crypto/af_alg03

[PATCH v2 0/6] ltp: AF_ALG test helpers and a few regression tests

2019-03-18 Thread Eric Biggers
Hello, This series adds helper functions for testing AF_ALG (the userspace interface to algorithms in the Linux kernel's crypto API) to the Linux Test Project. It then adds a few sample regression tests. I've had these patches sitting around for a while with the goal of also writing some "real"

[PATCH v2 6/6] crypto/af_alg05: new regression test for skcipher_walk error bug

2019-03-18 Thread Eric Biggers
From: Eric Biggers Signed-off-by: Eric Biggers --- runtest/crypto | 1 + testcases/kernel/crypto/.gitignore | 1 + testcases/kernel/crypto/af_alg05.c | 43 ++ 3 files changed, 45 insertions(+) create mode 100644 testcases/kernel/crypto/af_alg05

[PATCH v2 3/6] crypto/af_alg02: new regression test for salsa20 empty message bug

2019-03-18 Thread Eric Biggers
From: Eric Biggers Signed-off-by: Eric Biggers --- runtest/crypto | 1 + runtest/cve| 1 + testcases/kernel/crypto/.gitignore | 1 + testcases/kernel/crypto/af_alg02.c | 29 + 4 files changed, 32 insertions(+) create mo

[PATCH v2 1/6] lib: add tst_af_alg lib

2019-03-18 Thread Eric Biggers
From: Eric Biggers Add helper functions for creating and using AF_ALG sockets. AF_ALG is the userspace interface to algorithms in the Linux kernel's crypto API. See https://www.kernel.org/doc/html/latest/crypto/userspace-if.html for more information about this interface. Signed-off-by: Eric Big

[PATCH v2 5/6] crypto/af_alg04: new regression test for vmac race conditions

2019-03-18 Thread Eric Biggers
From: Eric Biggers Signed-off-by: Eric Biggers --- runtest/crypto | 1 + testcases/kernel/crypto/.gitignore | 1 + testcases/kernel/crypto/af_alg04.c | 56 ++ 3 files changed, 58 insertions(+) create mode 100644 testcases/kernel/crypto/af_alg04

Re: [Bug] Rockchip crypto driver sometimes produces wrong ciphertext

2019-03-18 Thread Gael PORTAY
Hello, On 3/16/19 6:31 PM, Ezequiel Garcia wrote: Adding my colleague Gael, who has been working on fixing this driver. I have a couple of pending commits that may fix that issue. I will give it a try, and get back to you then. On Friday, March 15, 2019 00:31 -03, Eric Biggers wrote: