[PATCH] crypto: ccp - Make ccp_dev_suspend and ccp_dev_resume void functions

2021-04-14 Thread Tian Tao
Since ccp_dev_suspend() and ccp_dev_resume() only return 0 which causes ret to equal 0 in sp_suspend and sp_resume, making the if condition impossible to use. it might be a more appropriate fix to have these be void functions and eliminate the if condition in sp_suspend() and sp_resume(). Signed-o

Re: [PATCH] crypto: ccp - Fix to return the correct return value

2021-04-14 Thread tiantao (H)
在 2021/4/15 6:48, Tom Lendacky 写道: On 4/14/21 4:17 AM, Tian Tao wrote: ccp_dev_suspend and ccp_dev_resume return 0 on error, which causes ret to equal 0 in sp_suspend and sp_resume, making the if condition impossible to use. Why do you think that is an error and why do you think it should ret

Re: [RFC Part2 PATCH 01/30] x86: Add the host SEV-SNP initialization support

2021-04-14 Thread Brijesh Singh
On 4/14/21 2:27 AM, Borislav Petkov wrote: > On Wed, Mar 24, 2021 at 12:04:07PM -0500, Brijesh Singh wrote: >> @@ -538,6 +540,10 @@ >> #define MSR_K8_SYSCFG 0xc0010010 >> #define MSR_K8_SYSCFG_MEM_ENCRYPT_BIT 23 >> #define MSR_K8_SYSCFG_MEM_ENCRYPT BIT_ULL(MSR_K8_

Re: [PATCH] crypto: ccp - Fix to return the correct return value

2021-04-14 Thread Tom Lendacky
On 4/14/21 4:17 AM, Tian Tao wrote: > ccp_dev_suspend and ccp_dev_resume return 0 on error, which causes > ret to equal 0 in sp_suspend and sp_resume, making the if condition > impossible to use. Why do you think that is an error and why do you think it should return -ENXIO? Since ccp_dev_suspend(

Re: [GIT PULL][PATCH v9 0/3] Update to zstd-1.4.10

2021-04-14 Thread Nick Terrell
On Wed, Apr 14, 2021 at 12:04 PM Eric Biggers wrote: > > On Wed, Apr 14, 2021 at 11:53:51AM -0700, Nick Terrell wrote: > > On Wed, Apr 14, 2021 at 11:35 AM Eric Biggers wrote: > > > > > > On Wed, Apr 14, 2021 at 11:01:29AM -0700, Nick Terrell wrote: > > > > Hi all, > > > > > > > > I would really

Re: [GIT PULL][PATCH v9 0/3] Update to zstd-1.4.10

2021-04-14 Thread Eric Biggers
On Wed, Apr 14, 2021 at 11:53:51AM -0700, Nick Terrell wrote: > On Wed, Apr 14, 2021 at 11:35 AM Eric Biggers wrote: > > > > On Wed, Apr 14, 2021 at 11:01:29AM -0700, Nick Terrell wrote: > > > Hi all, > > > > > > I would really like to make some progress on this and get it merged. > > > This patch

Re: [GIT PULL][PATCH v9 0/3] Update to zstd-1.4.10

2021-04-14 Thread Nick Terrell
On Wed, Apr 14, 2021 at 11:35 AM Eric Biggers wrote: > > On Wed, Apr 14, 2021 at 11:01:29AM -0700, Nick Terrell wrote: > > Hi all, > > > > I would really like to make some progress on this and get it merged. > > This patchset offsers: > > * 15-30% better decompression speed > > * 3 years of zstd b

Re: [GIT PULL][PATCH v9 0/3] Update to zstd-1.4.10

2021-04-14 Thread Eric Biggers
On Wed, Apr 14, 2021 at 11:01:29AM -0700, Nick Terrell wrote: > Hi all, > > I would really like to make some progress on this and get it merged. > This patchset offsers: > * 15-30% better decompression speed > * 3 years of zstd bug fixes and code improvements > * Allows us to import zstd directly

Re: [GIT PULL][PATCH v9 0/3] Update to zstd-1.4.10

2021-04-14 Thread Nick Terrell
Hi all, I would really like to make some progress on this and get it merged. This patchset offsers: * 15-30% better decompression speed * 3 years of zstd bug fixes and code improvements * Allows us to import zstd directly from upstream so we don't fall 3 years out of date again Thanks, Nick On F

Re: [PATCH 1/4] X.509: Add CodeSigning extended key usage parsing

2021-04-14 Thread joeyli
Hi Varad, Thanks for your review! On Tue, Apr 13, 2021 at 04:28:11PM +0200, Varad Gautam wrote: > Hi, > > On 3/9/21 10:10 AM, Lee, Chun-Yi wrote: > > This patch adds the logic for parsing the CodeSign extended key usage > > extension in X.509. The parsing result will be set to the eku flag > >

[PATCH] crypto: ux500: cryp: Remove duplicate argument

2021-04-14 Thread Wan Jiabing
Fix the following coccicheck warning: ./drivers/crypto/ux500/cryp/cryp_p.h:84:6-27:duplicated argument to | Signed-off-by: Wan Jiabing --- drivers/crypto/ux500/cryp/cryp_p.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/ux500/cryp/cryp_p.h b/drivers/crypto/ux500/cryp/cryp_p

[PATCH] crypto: ccp - Fix to return the correct return value

2021-04-14 Thread Tian Tao
ccp_dev_suspend and ccp_dev_resume return 0 on error, which causes ret to equal 0 in sp_suspend and sp_resume, making the if condition impossible to use. Signed-off-by: Tian Tao --- drivers/crypto/ccp/ccp-dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypt

Re: [RFC Part2 PATCH 01/30] x86: Add the host SEV-SNP initialization support

2021-04-14 Thread Borislav Petkov
On Wed, Mar 24, 2021 at 12:04:07PM -0500, Brijesh Singh wrote: > @@ -538,6 +540,10 @@ > #define MSR_K8_SYSCFG0xc0010010 > #define MSR_K8_SYSCFG_MEM_ENCRYPT_BIT23 > #define MSR_K8_SYSCFG_MEM_ENCRYPTBIT_ULL(MSR_K8_SYSCFG_MEM_ENCRYPT_BIT) > +#define MSR_K8_SYSCFG