Re: [PATCH v3] crypto: arm64/sha2: integrate OpenSSL implementations of SHA256/SHA512

2016-11-13 Thread Andy Polyakov
> Looking at the generated code, I see references to __ARMEB__ and __ILP32__. > The former is probably a bug, >>> >>> Oh! You mean that it should be __AARCH64EB__/__AARCH64EL__! >> >> Indeed: >> >> $ aarch64-linux-gnu-gcc -dM -E - <<<"" |grep AARCH >> #define

Re: [PATCH v3] crypto: arm64/sha2: integrate OpenSSL implementations of SHA256/SHA512

2016-11-13 Thread Andy Polyakov
>>> (+ Andy) >>> >>> ... Looking at the generated code, I see references to __ARMEB__ and >>> __ILP32__. The former is probably a bug, >> >> Oh! You mean that it should be __AARCH64EB__/__AARCH64EL__! > > Indeed: > > $ aarch64-linux-gnu-gcc -dM -E - <<<"" |grep AARCH > #define

Re: [PATCH v3] crypto: arm64/sha2: integrate OpenSSL implementations of SHA256/SHA512

2016-11-13 Thread Andy Polyakov
> (+ Andy) > > ... >> >> Looking at the generated code, I see references to __ARMEB__ and > __ILP32__. >> The former is probably a bug, Oh! You mean that it should be __AARCH64EB__/__AARCH64EL__! Apparently I simply went on assuming that it would be __ARMEB__/__ARMEL__ even in 64-bit case. As

Re: [PATCH] arm64: add support for SHA256 using NEON instructions

2016-09-30 Thread Andy Polyakov
> This is a port of the ARMv7 implementation in arch/arm/crypto. For a > Cortex-A57 > (r2p1), the performance numbers are listed below. In summary, 40% - 50% > speedup > where it counts, i.e., block sizes over 256 bytes with few updates. Cool! Great! Just in case for reference. You compare

Re: [PATCH] crypto/arm: accelerated SHA-512 using ARM generic ASM and NEON

2015-03-29 Thread Andy Polyakov
This updates the SHA-512 NEON module with the faster and more versatile implementation from the OpenSSL project. It consists of both a NEON and a generic ASM version of the core SHA-512 transform, where the NEON version reverts to the ASM version when invoked in non-process context.

Re: [PATCHv2] arm: crypto: Add optimized SHA-256/224

2015-03-29 Thread Andy Polyakov
arch/arm/crypto/sha256-core.S: Assembler messages: arch/arm/crypto/sha256-core.S:1847: Error: invalid constant (efb0) after fixup This is caused by the fact that, when building the integer-only code for an older architecture, the conditional compilation produces a slightly bigger

Re: [PATCHv2] arm: crypto: Add optimized SHA-256/224

2015-03-27 Thread Andy Polyakov
Could you share the error log please? OK, I spotted one issue with this code: arch/arm/crypto/sha256-core.S: Assembler messages: arch/arm/crypto/sha256-core.S:1847: Error: invalid constant (efb0) after fixup This is caused by the fact that, when building the integer-only code for

Re: [PATCH] arm: crypto: Add NEON optimized SHA-256

2015-03-17 Thread Andy Polyakov
Hi, Have you tested this code with the tcrypt.ko module? I have not, but I can look into it. Did you talk to Andy about the license? I don't think this is permissible for the kernel as-is. Unless I have misunderstood something, the license at the Cryptogams website includes an option to