Re: RSA signature verification

2011-03-22 Thread Dmitry Kasatkin
before it is signed. So after RSA decryption, de-padding has to be done, before comparing result to the calculated hash. - Dmitry On 22/03/11 08:59, Dmitry Kasatkin wrote: > Hi, > > As I have said in my email that it will be used by IMA/EVM subsystem. > See security/integrity subdirect

Re: RSA signature verification

2011-03-22 Thread Dmitry Kasatkin
Hi, As I have said in my email that it will be used by IMA/EVM subsystem. See security/integrity subdirectory in Linux kernel... Indeed, use of HW accelerator is also on of the targets... - Dmitry On 21/03/11 16:06, ext Herbert Xu wrote: > On Mon, Mar 21, 2011 at 04:04:41PM +0200, Dmi

RSA signature verification

2011-03-21 Thread Dmitry Kasatkin
Hi Herbert, I work on kernel RSA verification for IMA/EVM. Currently I have a patch which provides "direct" API like ksign_verify() to get signature verified. I was thinking about doing it via crypto interface as usual but for now I have done it directly. I have found some very old (5y) patches w

Re: hash finup() issue

2011-01-26 Thread Dmitry Kasatkin
data coming (like MSG_MORE) finup() is just final update... Basically driver on update() will not do extra buffering.. Is it clear now? How would you solve such issue? - Dmitry On 27/01/11 01:32, ext Herbert Xu wrote: > On Wed, Jan 26, 2011 at 09:47:27AM +0200, Dmitry Kasatkin wrote: >>

Re: hash finup() issue

2011-01-25 Thread Dmitry Kasatkin
/01/11 01:29, ext Herbert Xu wrote: > On Tue, Jan 25, 2011 at 03:44:47PM +0200, Dmitry Kasatkin wrote: >> What we have done in our system is introduced a new flag which is set to >> request. >> flags |= CRYPTO_TFM_REQ_USE_FINUP; >> ahash_request_set_callback(req, flags,

hash finup() issue

2011-01-25 Thread Dmitry Kasatkin
Hello, It is often very important to know for implementation or optimization if we get more data to process or not. New user space crypto API uses socket MSG_MORE flag to know if more data is coming. >From kernel crypto API it is also may be very important to know if more data is coming. OMAP S

Re: RSA verification in the kernel

2011-01-13 Thread Dmitry Kasatkin
Hi, Indeed. Forgot about it. I even have that repo on my computer: newapi branch. Thanks, Dmitry On 13/01/11 10:08, ext Nikos Mavrogiannopoulos wrote: > On Thu, Jan 13, 2011 at 8:19 AM, Dmitry Kasatkin > wrote: >> Hi, >> Does anybody know if there is a GPL implementation o

RSA verification in the kernel

2011-01-12 Thread Dmitry Kasatkin
Hi, Does anybody know if there is a GPL implementation of RSA verification for the Linux kernel? I know DigSig, but is anything recent available? Thanks, Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH 02/16] crypto: omap-sham: don't treat NULL clk as an error

2011-01-12 Thread Dmitry Kasatkin
it returns a ERR_PTR() encoded pointer. >> >> Cc: Dmitry Kasatkin >> Cc: linux-crypto@vger.kernel.org >> Signed-off-by: Jamie Iles > > Reviewed-by: Aaro Koskinen > Reviewed-by: Dmitry Kasatkin >> --- >> drivers/crypto/omap-sham.c |4 ++-- >> 1

Re: [PATCH 01/16] crypto: omap-aes: don't treat NULL clk as an error

2011-01-12 Thread Dmitry Kasatkin
failed if it returns a ERR_PTR() encoded pointer. >> >> Cc: Dmitry Kasatkin >> Cc: linux-crypto@vger.kernel.org >> Signed-off-by: Jamie Iles > > Reviewed-by: Aaro Koskinen Reviewed-by: Dmitry Kasatkin > >> --- >> drivers/crypto/omap-aes.c |5 +

[PATCH 0/1] crypto: omap-sham backlog handling fix

2010-12-29 Thread Dmitry Kasatkin
Hi, Please take this important fix. - Dmitry Dmitry Kasatkin (1): omap-sham: backlog handling fix drivers/crypto/omap-sham.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of

[PATCH 1/1] omap-sham: backlog handling fix

2010-12-29 Thread Dmitry Kasatkin
ut it will happen in implementation similar to dm-crypt. Backlog needs to be checked before dequeuing next request. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/c

Re: [PATCHv2 0/6] omap-aes off mode and error handling fixes

2010-12-07 Thread Dmitry Kasatkin
thanks On 02/12/10 10:37, ext Herbert Xu wrote: > On Tue, Nov 30, 2010 at 10:13:26AM +0200, Dmitry Kasatkin wrote: > >> Changes to v1: >> - omap type specific handling removed >> - fixed backlog handling bug in "redundunt locking is removed" >> - aes mod

Re: crypto: algif_skcipher - Fixed overflow when sndbuf is page aligned

2010-11-30 Thread Dmitry Kasatkin
Hi, What is the repo with algif patches? Would like to try it.. - Dmitry On 30/11/10 10:51, ext Herbert Xu wrote: > Hi: > > Just noticed that algif_skcipher fails to apply the sk_sndbuf limit > correctly unless it is a multiple of PAGE_SIZE. What happens is > that the merge path will exceed sk

[PATCHv2 4/6] omap-aes: unnecessary code removed

2010-11-30 Thread Dmitry Kasatkin
Key and IV should always be set before AES operation. So no need to check if it has changed or not. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c | 70 +++-- 1 files changed, 17 insertions(+), 53 deletions(-) diff --git a/drivers/crypto

[PATCHv2 2/6] omap-aes: redundant locking is removed

2010-11-30 Thread Dmitry Kasatkin
Submitting request involved double locking for enqueuing and dequeuing. Now it is done under the same lock. FLAGS_BUSY is now handled under the same lock. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c | 70 1 files changed, 32

[PATCHv2 5/6] omap-aes: initialize aes module once per request

2010-11-30 Thread Dmitry Kasatkin
AES module was initialized for every DMA transaction. That is redundant. Now it is initialized once per request. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c | 54 +++- 1 files changed, 28 insertions(+), 26 deletions(-) diff --git a

[PATCHv2 6/6] omap-aes: checkpatch --file warning fixes

2010-11-30 Thread Dmitry Kasatkin
Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index b69da4f..add2a1a 100644 --- a/drivers/crypto/omap-aes.c +++ b/drivers/crypto/omap-aes.c @@ -96,7

[PATCHv2 1/6] omap-aes: DMA initialization fixes for OMAP off mode

2010-11-30 Thread Dmitry Kasatkin
DMA parameters for constant data were initialized during driver probe(). It seems that those settings sometimes are lost when devices goes to off mode. This patch makes DMA initialization just before use. It solves off mode problems. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c

[PATCHv2 3/6] omap-aes: error handling implementation improved

2010-11-30 Thread Dmitry Kasatkin
Previous version had not error handling. Request could remain uncompleted. Also in the case of DMA error, FLAGS_INIT is unset and accelerator will be initialized again. Buffer size allignment is checked. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c | 134

[PATCHv2 0/6] omap-aes off mode and error handling fixes

2010-11-30 Thread Dmitry Kasatkin
Changes to v1: - omap type specific handling removed - fixed backlog handling bug in "redundunt locking is removed" - aes module initialized once per request instead of dma transaction more efficient and right way to do it - checkpatch fixes in separate patch Dmitry Kasatkin (6):

Re: [PATCH v3 0/8] omap-sham: OMAP SHA1/MD5 driver fixes and improvements

2010-11-29 Thread Dmitry Kasatkin
Thanks. On 27/11/10 10:39, ext Herbert Xu wrote: > On Fri, Nov 19, 2010 at 04:04:21PM +0200, Dmitry Kasatkin wrote: > >> Hi, >> >> Here is a set of patches which provides fixes and improvements. >> >> Based on Herbert feedback it also includes fixes so that

[PATCH v3 7/8] omap-sham: FLAGS_FIRST is redundant and removed

2010-11-19 Thread Dmitry Kasatkin
bufcnt is 0 if it was no update requests before, which is exact meaning of FLAGS_FIRST. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index

[PATCH v3 1/8] omap-sham: uses digest buffer in request context

2010-11-19 Thread Dmitry Kasatkin
Currently driver storred digest results in req->results provided by the client. But some clients do not set it until final() call. It leads to crash. Changed to use internal buffer to store temporary digest results. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c |

[PATCH v3 5/8] omap-sham: crypto_ahash_final() now not need to be called.

2010-11-19 Thread Dmitry Kasatkin
, and clocks will not be disabled. This patch provides support for atomic crypto_ahash_update() call. Clocks are now enabled and disabled per update request. Data buffer is now allocated as a part of request context. Client is obligated to free it with crypto_free_ahash(). Signed-off-by: Dmitry

[PATCH v3 6/8] omap-sham: hash-in-progress is stored in hw format

2010-11-19 Thread Dmitry Kasatkin
Hash-in-progress is now stored in hw format. Only on final call, hash is converted to correct format. Speedup copy procedure and will allow to use OMAP burst mode. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 38 -- 1 files changed, 24

[PATCH v3 3/8] omap-sham: error handling improved

2010-11-19 Thread Dmitry Kasatkin
possible HW failures. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 67 +--- 1 files changed, 44 insertions(+), 23 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 9dfbc4a..db20628 100644 --- a/drivers

[PATCH v3 8/8] omap-sham: zero-copy scatterlist handling

2010-11-19 Thread Dmitry Kasatkin
buffer. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 87 +++- 1 files changed, 61 insertions(+), 26 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index d88d7eb..eb988e7 100644 --- a/drivers/crypto/omap

[PATCH v3 0/8] omap-sham: OMAP SHA1/MD5 driver fixes and improvements

2010-11-19 Thread Dmitry Kasatkin
Hi, Here is a set of patches which provides fixes and improvements. Based on Herbert feedback it also includes fixes so that calling final() is not mandatory. BR, Dmitry Dmitry Kasatkin (8): omap-sham: uses digest buffer in request context omap-sham: DMA initialization fixes for off mode

[PATCH v3 4/8] omap-sham: removed redundunt locking

2010-11-19 Thread Dmitry Kasatkin
Locking for queuing and dequeuing is combined. test_and_set_bit() is also replaced with checking under dd->lock. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 47 +++ 1 files changed, 21 insertions(+), 26 deletions(-) diff --gi

[PATCH v3 2/8] omap-sham: DMA initialization fixes for off mode

2010-11-19 Thread Dmitry Kasatkin
gned-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 370..9dfbc4a 100644 --- a/drivers/crypto/omap-sham.c +++ b/drivers/crypto/omap-sh

Re: [PATCH 1/7] crypto: updates omap sham device related platform code

2010-11-17 Thread Dmitry Kasatkin
Hi, This patch was already applied months ago. It appeared by mistake as "git format-patch" took it somehow. Please ignore it... - Dmitry On 16/11/10 19:19, ext Tony Lindgren wrote: > * Dmitry Kasatkin [101110 09:20]: > >> - registration with multi OMAP kerne

Re: crypto ahash error handling

2010-11-12 Thread Dmitry Kasatkin
Well.. That was not the case before. I made a new patch set. I will send updates for SHA and AES soon after some more testing. - Dmitry On 12/11/10 02:05, ext Herbert Xu wrote: > On Thu, Nov 11, 2010 at 08:11:21PM +0200, Dmitry Kasatkin wrote: > >> Hi, >> >> Y

Re: crypto ahash error handling

2010-11-11 Thread Dmitry Kasatkin
Hi, Yes. Our HW is capable of producing unfinalised hashes. Everything is fine. No. It is not broken.. It cleans up if error... - Dmitry On 11/11/10 18:17, ext Herbert Xu wrote: > On Wed, Nov 10, 2010 at 04:54:51PM +0200, Dmitry Kasatkin wrote: > >> This is not good. >&g

[PATCH 3/4] omap-sham: error handling improved

2010-11-10 Thread Dmitry Kasatkin
possible HW failures. Signed-off-by: Dmitry Kasatkin Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 67 +--- 1 files changed, 44 insertions(+), 23 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index

[PATCH 4/4] omap-sham: removed redundunt locking

2010-11-10 Thread Dmitry Kasatkin
Locking for queuing and dequeuing is combined. test_and_set_bit() is also replaced with checking under dd->lock. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 47 +++ 1 files changed, 21 insertions(+), 26 deletions(-) diff --gi

[PATCH 2/4] omap-sham: DMA initialization fixes for off mode

2010-11-10 Thread Dmitry Kasatkin
gned-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 370..9dfbc4a 100644 --- a/drivers/crypto/omap-sham.c +++ b/drivers/crypto/omap-sh

[PATCH 1/4] omap-sham: uses digest buffer in request context

2010-11-10 Thread Dmitry Kasatkin
Currently driver storred digest results in req->results provided by the client. But some clients do not set it until final() call. It leads to crash. Changed to use internal buffer to store temporary digest results. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c |

[PATCH 0/4]v2 omap-sham off mode and error handling fixes.

2010-11-10 Thread Dmitry Kasatkin
Please ignore previous patch set. Some old patches appeared there... Dmitry Kasatkin (4): omap-sham: uses digest buffer in request context omap-sham: DMA initialization fixes for off mode omap-sham: error handling improved omap-sham: removed redundunt locking drivers/crypto/omap-sham.c

[PATCH 7/7] omap-sham: removed redundunt locking

2010-11-10 Thread Dmitry Kasatkin
Locking for queuing and dequeuing is combined. test_and_set_bit() is also replaced with checking under dd->lock. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 47 +++ 1 files changed, 21 insertions(+), 26 deletions(-) diff --gi

[PATCH 6/7] omap-sham: error handling improved

2010-11-10 Thread Dmitry Kasatkin
possible HW failures. Signed-off-by: Dmitry Kasatkin Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 67 +--- 1 files changed, 44 insertions(+), 23 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index

[PATCH 5/7] omap-sham: DMA initialization fixes for off mode

2010-11-10 Thread Dmitry Kasatkin
gned-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 370..9dfbc4a 100644 --- a/drivers/crypto/omap-sham.c +++ b/drivers/crypto/omap-sh

[PATCH 4/7] omap-sham: uses digest buffer in request context

2010-11-10 Thread Dmitry Kasatkin
Currently driver storred digest results in req->results provided by the client. But some clients do not set it until final() call. It leads to crash. Changed to use internal buffer to store temporary digest results. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sham.c |

[PATCH 3/7] omap-sham: OMAP macros corrected

2010-11-10 Thread Dmitry Kasatkin
Signed-off-by: Dmitry Kasatkin --- arch/arm/mach-omap2/devices.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index beac46c..79dbf04 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm/mach-omap2

[PATCH 2/7] crypto: omap-sham - omap sha1 & md5 driver

2010-11-10 Thread Dmitry Kasatkin
,0 +1,1259 @@ +/* + * Cryptographic API. + * + * Support for OMAP SHA1/MD5 HW acceleration. + * + * Copyright (c) 2010 Nokia Corporation + * Author: Dmitry Kasatkin + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License ve

[PATCH 1/7] crypto: updates omap sham device related platform code

2010-11-10 Thread Dmitry Kasatkin
- registration with multi OMAP kernels support - clocks Signed-off-by: Dmitry Kasatkin --- arch/arm/mach-omap2/clock2420_data.c |2 +- arch/arm/mach-omap2/clock2430_data.c |2 +- arch/arm/mach-omap2/clock3xxx_data.c |2 +- arch/arm/mach-omap2/devices.c

[PATCH 0/7] omap-sham off mode and error handling fixes.

2010-11-10 Thread Dmitry Kasatkin
Dmitry Kasatkin (7): crypto: updates omap sham device related platform code crypto: omap-sham - omap sha1 & md5 driver omap-sham: OMAP macros corrected omap-sham: uses digest buffer in request context omap-sham: DMA initialization fixes for off mode omap-sham: error handling impr

[PATCH 4/5] omap-aes: error handling implementation improved

2010-11-10 Thread Dmitry Kasatkin
Previous version had not error handling. Request could remain uncompleted. Also in the case of DMA error, FLAGS_INIT is unset and accelerator will be initialized again. Buffer size allignment is checked. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c | 135

[PATCH 5/5] omap-aes: unnecessary code removed

2010-11-10 Thread Dmitry Kasatkin
Key and IV should always be set before AES operation. So no need to check if it has changed or not. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c | 64 +++- 1 files changed, 16 insertions(+), 48 deletions(-) diff --git a/drivers/crypto

[PATCH 2/5] omap-aes: DMA initialization fixes for OMAP off mode

2010-11-10 Thread Dmitry Kasatkin
DMA parameters for constant data were initialized during driver probe(). It seems that those settings sometimes are lost when devices goes to off mode. This patch makes DMA initialization just before use. It solves off mode problems. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c

[PATCH 3/5] omap-aes: redundant locking is removed

2010-11-10 Thread Dmitry Kasatkin
Submitting request involved double locking for enqueuing and dequeuing. Now it is done under the same lock. FLAGS_BUSY is now handled under the same lock. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c | 68 1 files changed, 31

[PATCH 1/5] crypto: omap-aes: change in prevention of OCP bus error

2010-11-10 Thread Dmitry Kasatkin
Suggested to use udelay() instead of nop as on the higher core frequencies it might not be enough time. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-aes.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap

[PATCH 0/5] omap-aes off mode and error handling fixes

2010-11-10 Thread Dmitry Kasatkin
Dmitry Kasatkin (5): crypto: omap-aes: change in prevention of OCP bus error omap-aes: DMA initialization fixes for OMAP off mode omap-aes: redundant locking is removed omap-aes: error handling implementation improved omap-aes: unnecessary code removed drivers/crypto/omap-aes.c | 269

Re: crypto ahash error handling

2010-11-10 Thread Dmitry Kasatkin
This is not good. Driver might allocate some resources, which needs to be released. crypto_ahash_final() should do some kind of "cleanup" task. - Dmitry On 10/11/10 14:27, ext Herbert Xu wrote: > Dmitry Kasatkin wrote: > >> Hello, >> >> When using crypto ah

crypto ahash error handling

2010-11-08 Thread Dmitry Kasatkin
Hello, When using crypto ahash API, is it necessary/mandatory to call crypto_ahash_final() if crypto_ahash_update() returns error... Basically it might happen after several calls while calculating hash if HW error happens. It is not possible to continue hash calculation. it is necessary to reset

Re: How do you specify driver in tcrypt

2010-11-03 Thread Dmitry Kasatkin
Hi, I guess you can provide driver name, like "omap-aes". - Dmitry On 02/11/10 23:11, ext Mark Allyn wrote: > I want to run tcrypt, but I want to only use a specific driver. How do I > do that? > > Thanks > > Truly, > > Mark Allyn > Portland, Oregon > www.allyn.com > 971-563-7588 > -- > To uns

Re: alg_test question

2010-11-03 Thread Dmitry Kasatkin
Hi Mark, cryptomgr_test call it like err = alg_test(param->driver, param->alg, type, CRYPTO_ALG_TESTED); tcrypt_test: ret = alg_test(alg, alg, 0, 0); - Dmitry On 02/11/10 19:42, ext Mark Allyn wrote: > What is the mask parameter for in the alg_test function? Also what is the > type?

[PATCH 0/1] omap-sham: use prefetch mechanism to increase transfer speed

2010-09-02 Thread Dmitry Kasatkin
Samu Onkalo (1): crypto: omap-sham: Adjust DMA parameters drivers/crypto/omap-sham.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo i

[PATCH 1/1] crypto: omap-sham: Adjust DMA parameters

2010-09-02 Thread Dmitry Kasatkin
takes time to fetch data from memory and transfer it via L4 bus. With prefetch enabled, data is waiting in DMA fifo and SHAM block receives new data block faster. This increases SHA processing speed up to 30 percent depending on the bus / memory load. Signed-off-by: Samu Onkalo Signed-off-by: D

Re: [PATCH 2/2] crypto: omap-aes: OMAP2/3 AES hw accelerator driver

2010-08-31 Thread Dmitry Kasatkin
To this actually. Thanks On 20/08/10 16:44, Kasatkin Dmitry (Nokia-MS/Helsinki) wrote: > Signed-off-by: Dmitry Kasatkin > --- > drivers/crypto/Kconfig|8 + > drivers/crypto/Makefile |1 + > drivers/crypto/omap-aes.c | 948 >

Re: [PATCH 1/2] crypto: updates to enable omap aes

2010-08-31 Thread Dmitry Kasatkin
Hi, Does anyone want to comment on this? Thanks, Dmitry On 20/08/10 16:44, Kasatkin Dmitry (Nokia-MS/Helsinki) wrote: > Signed-off-by: Dmitry Kasatkin > --- > arch/arm/mach-omap2/clock2420_data.c |2 +- > arch/arm/mach-omap2/clock2430_data.c |2 +- > arch

[PATCH 0/2] omap-aes: OMAP2/3 AES HW accelerator driver

2010-08-20 Thread Dmitry Kasatkin
This set of patches provides implementation of the driver for OMAP2/3 AES hw accelerator. Dmitry Kasatkin (2): crypto: updates to enable omap aes crypto: omap-aes: OMAP2/3 AES hw accelerator driver arch/arm/mach-omap2/clock2420_data.c |2 +- arch/arm/mach-omap2/clock2430_data.c |2

[PATCH 2/2] crypto: omap-aes: OMAP2/3 AES hw accelerator driver

2010-08-20 Thread Dmitry Kasatkin
Signed-off-by: Dmitry Kasatkin --- drivers/crypto/Kconfig|8 + drivers/crypto/Makefile |1 + drivers/crypto/omap-aes.c | 948 + 3 files changed, 957 insertions(+), 0 deletions(-) create mode 100644 drivers/crypto/omap-aes.c diff --git

[PATCH 1/2] crypto: updates to enable omap aes

2010-08-20 Thread Dmitry Kasatkin
Signed-off-by: Dmitry Kasatkin --- arch/arm/mach-omap2/clock2420_data.c |2 +- arch/arm/mach-omap2/clock2430_data.c |2 +- arch/arm/mach-omap2/clock3xxx_data.c |2 +- arch/arm/mach-omap2/devices.c| 71 ++ 4 files changed, 74 insertions(+), 3

Re: Crypto API from user space

2010-06-16 Thread Dmitry Kasatkin
Hi, BTW. git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git Has this kernel anything about cryptodev as well? Thanks, - Dmitry On 15/06/10 19:24, ext Nikos Mavrogiannopoulos wrote: > Dmitry Kasatkin wrote: > >> Hi, >> >> Can I use kernel Cr

Crypto API from user space

2010-06-15 Thread Dmitry Kasatkin
Hi, Can I use kernel Crypto API from user space? I remember 2 or 3 projects about it. But what is the one and only one I need? :) Thanks, Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info a

Re: [PATCH 1/1] omap-sham: OMAP macros corrected

2010-05-10 Thread Dmitry Kasatkin
On 10/05/10 15:14, ext Herbert Xu wrote: > On Mon, May 10, 2010 at 03:07:55PM +0300, Dmitry Kasatkin wrote: > >> Signed-off-by: Dmitry Kasatkin >> --- >> arch/arm/mach-omap2/devices.c |4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >>

[PATCH 1/1] omap-sham: OMAP macros corrected

2010-05-10 Thread Dmitry Kasatkin
Signed-off-by: Dmitry Kasatkin --- arch/arm/mach-omap2/devices.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index beac46c..79dbf04 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm/mach-omap2

Re: [PATCHv4 0/2] omap-sham: OMAP SHA1/MD5 driver

2010-05-10 Thread Dmitry Kasatkin
Hi, Hmm.. yes. in my first patch I had OMAP3 and 2 Should I send updated patch above that? - Dmitry On 05/05/10 21:38, ext Tony Lindgren wrote: > * Herbert Xu [100502 20:07]: > >> On Wed, Apr 28, 2010 at 05:18:05PM +0300, Dmitry Kasatkin wrote: >> >>> Chan

[PATCH 2/2] crypto: omap-sham - omap sha1 & md5 driver

2010-04-28 Thread Dmitry Kasatkin
,0 +1,1259 @@ +/* + * Cryptographic API. + * + * Support for OMAP SHA1/MD5 HW acceleration. + * + * Copyright (c) 2010 Nokia Corporation + * Author: Dmitry Kasatkin + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License ve

[PATCHv4 0/2] omap-sham: OMAP SHA1/MD5 driver

2010-04-28 Thread Dmitry Kasatkin
Changes to v4: - concurrent requests support via queue - hmac - shash support removed Dmitry Kasatkin (2): crypto: updates omap sham device related platform code crypto: omap-sham - omap sha1 & md5 driver arch/arm/mach-omap2/clock2420_data.c |2 +- arch/arm/mach-o

[PATCH 1/2] crypto: updates omap sham device related platform code

2010-04-28 Thread Dmitry Kasatkin
- registration with multi OMAP kernels support - clocks Signed-off-by: Dmitry Kasatkin --- arch/arm/mach-omap2/clock2420_data.c |2 +- arch/arm/mach-omap2/clock2430_data.c |2 +- arch/arm/mach-omap2/clock3xxx_data.c |2 +- arch/arm/mach-omap2/devices.c

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-04-16 Thread Dmitry Kasatkin
09:51:22AM +0300, Dmitry Kasatkin wrote: What do you mean by "merge operation". request merging? By buffering user data, you're in essence merging requests. I have no objections to doing that, but let's not do it in every driver. Of course, the ultimate solution is

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-04-13 Thread Dmitry Kasatkin
On 14/04/10 09:44, ext Herbert Xu wrote: On Wed, Apr 14, 2010 at 09:37:47AM +0300, Dmitry Kasatkin wrote: Like just with import/export. Problems for hw: 1. To have a good performance with DMA we need to have large buffer. Not just 64 bytes block. state becomes large Sure

Re: [PATCHv3 2/2] crypto: omap-sham - omap sha1 & md5 driver

2010-04-13 Thread Dmitry Kasatkin
On 14/04/10 09:20, ext Herbert Xu wrote: Dmitry Kasatkin wrote: Earlier kernel contained omap sha1 and md5 driver, which was not maintained, was not ported to new crypto APIs and removed from the source tree. - implements async and sync crypto API using dma and cpu. - supports multiple

Re: [PATCHv3 2/2] crypto: omap-sham - omap sha1 & md5 driver

2010-04-13 Thread Dmitry Kasatkin
Hi, I am thinking to update to have: - concurrent requests with queue. - import/export problem but it takes a time. - Dmitry On 14/04/10 09:20, ext Herbert Xu wrote: Dmitry Kasatkin wrote: Earlier kernel contained omap sha1 and md5 driver, which was not maintained, was not ported to

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-04-13 Thread Dmitry Kasatkin
On 14/04/10 03:44, ext Herbert Xu wrote: On Tue, Apr 13, 2010 at 06:21:44PM +0300, Dmitry Kasatkin wrote: On 13/04/10 18:16, ext Uri Simchoni wrote: Doing step 3 using sw is probably faster than by hw (because it's short and avoid all the hw setup), so the suggested approa

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-04-13 Thread Dmitry Kasatkin
update there is a data in the cache. Doing export means that we need to get out intermediate hash and that buffer. Any suggestion? Thanks On 13/04/10 17:48, ext Herbert Xu wrote: On Tue, Apr 13, 2010 at 04:44:35PM +0300, Dmitry Kasatkin wrote: Well it can... if reqa occupied hw all

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-04-13 Thread Dmitry Kasatkin
On 13/04/10 17:42, ext Herbert Xu wrote: On Tue, Apr 13, 2010 at 05:36:40PM +0300, Dmitry Kasatkin wrote: Also one more question. can reqa and reqb could come from the same tfm as well? Yes of course. Two packets coming from different CPUs going to through the same IPsec SA for

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-04-13 Thread Dmitry Kasatkin
I do not see any problems as well with finishing it with sw. On 4/13/2010 5:45 PM, Herbert Xu wrote: On Tue, Apr 13, 2010 at 04:00:11PM +0300, Dmitry Kasatkin wrote: I would also: 1. calc hash(opad) using sw, export 2. hash(ipad ∥ message) using hw 3. then import and finup hash from s

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-04-13 Thread Dmitry Kasatkin
Also one more question. can reqa and reqb could come from the same tfm as well? thanks On 13/04/10 16:44, Kasatkin Dmitry (Nokia-D/Helsinki) wrote: Please see inline. Nice to clarify it. On 13/04/10 15:10, ext Herbert Xu wrote: On Tue, Apr 13, 2010 at 01:15:34PM +0300, Dmitry Kasatkin

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-04-13 Thread Dmitry Kasatkin
Please see inline. Nice to clarify it. On 13/04/10 15:10, ext Herbert Xu wrote: On Tue, Apr 13, 2010 at 01:15:34PM +0300, Dmitry Kasatkin wrote: But anyway hmac does not support ahash now. right? So the only way currently is to add to the driver. No the only way is to add an ahash

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-04-13 Thread Dmitry Kasatkin
On 13/04/10 15:02, ext Herbert Xu wrote: On Tue, Apr 13, 2010 at 01:13:47PM +0300, Dmitry Kasatkin wrote: As I can see from the patch initial vectors calculated with SW shash Rest is done in hw, basically sha1. Ideally that code shouldn't be duplicated either, but honestly

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-04-13 Thread Dmitry Kasatkin
Btw. But anyway hmac does not support ahash now. right? So the only way currently is to add to the driver. On 13/04/10 13:03, ext Herbert Xu wrote: On Tue, Apr 13, 2010 at 12:39:55PM +0300, Dmitry Kasatkin wrote: btw. patch to mv_cesa is actually adding hmac to the driver. How would you

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-04-13 Thread Dmitry Kasatkin
Hi On 13/04/10 13:03, ext Herbert Xu wrote: On Tue, Apr 13, 2010 at 12:39:55PM +0300, Dmitry Kasatkin wrote: btw. patch to mv_cesa is actually adding hmac to the driver. How would you comment that? AFAICS it's doing HMAC in hardware. Uri, is that not the case? As I ca

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-04-13 Thread Dmitry Kasatkin
Hi, btw. patch to mv_cesa is actually adding hmac to the driver. How would you comment that? The same way could be also used here. I could calc final output with sw. Any comments? - Dmitry On 13/04/10 11:59, ext Herbert Xu wrote: On Thu, Apr 08, 2010 at 06:35:33PM +0200, dmitry.kasat...@no

[PATCHv3 0/2] omap-sham: OMAP SHA1/MD5 driver

2010-04-13 Thread Dmitry Kasatkin
Changes to v2: - Added multi omap kernel support based on comment - some redundant vars removed Dmitry Kasatkin (2): crypto: updates omap sham device related platform code crypto: omap-sham - omap sha1 & md5 driver arch/arm/mach-omap2/clock2420_data.c |2 +- arch/arm/mach-o

[PATCHv3 1/2] crypto: updates omap sham device related platform code

2010-04-13 Thread Dmitry Kasatkin
- registration with multi OMAP kernels support - clocks Signed-off-by: Dmitry Kasatkin --- arch/arm/mach-omap2/clock2420_data.c |2 +- arch/arm/mach-omap2/clock2430_data.c |2 +- arch/arm/mach-omap2/clock3xxx_data.c |2 +- arch/arm/mach-omap2/devices.c

[PATCHv3 2/2] crypto: omap-sham - omap sha1 & md5 driver

2010-04-13 Thread Dmitry Kasatkin
Earlier kernel contained omap sha1 and md5 driver, which was not maintained, was not ported to new crypto APIs and removed from the source tree. - implements async and sync crypto API using dma and cpu. - supports multiple sham instances if available Signed-off-by: Dmitry Kasatkin --- drivers

Re: [PATCHv2 1/2] crypto: updates omap sham device related platform code

2010-04-08 Thread Dmitry Kasatkin
Hi, BTW.. How will it work if those resource structures anyway conditionally compiled for OMAP2 or 3 or 4? only one structure will be compiled at once. - Dmitry On 30/03/10 12:41, ext Paul Walmsley wrote: Hi Dmitry, a few comments: On Thu, 25 Mar 2010, Dmitry Kasatkin wrote

Re: [PATCHv2 1/2] crypto: updates omap sham device related platform code

2010-03-31 Thread Dmitry Kasatkin
On 30/03/10 12:41, ext Paul Walmsley wrote: Hi Dmitry, a few comments: On Thu, 25 Mar 2010, Dmitry Kasatkin wrote: - registration - clocks Signed-off-by: Dmitry Kasatkin --- arch/arm/mach-omap2/clock2420_data.c |2 +- arch/arm/mach-omap2/clock2430_data.c |2

[PATCHv2 2/2] crypto: omap-sham - omap sha1 & md5 driver

2010-03-25 Thread Dmitry Kasatkin
Earlier kernel contained omap sha1 and md5 driver, which was not maintained, was not ported to new crypto APIs and removed from the source tree. - implements async and sync crypto API using dma and cpu. - supports multiple sham instances if available Signed-off-by: Dmitry Kasatkin --- drivers

[PATCHv2 1/2] crypto: updates omap sham device related platform code

2010-03-25 Thread Dmitry Kasatkin
- registration - clocks Signed-off-by: Dmitry Kasatkin --- arch/arm/mach-omap2/clock2420_data.c |2 +- arch/arm/mach-omap2/clock2430_data.c |2 +- arch/arm/mach-omap2/clock3xxx_data.c |2 +- arch/arm/mach-omap2/devices.c | 26

[PATCHv2 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-03-25 Thread Dmitry Kasatkin
- omap-sha1-md5 name changed to omap-sham match omap spec - standard clock name "ick" in use - style fixes Dmitry Kasatkin (2): crypto: updates omap sham device related platform code crypto: omap-sham - omap sha1 & md5 driver arch/arm/mach-omap2/clock2420_data.c |

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-03-24 Thread Dmitry Kasatkin
On 23/03/10 13:32, ext Herbert Xu wrote: On Wed, Mar 17, 2010 at 03:12:49PM +0200, Dmitry Kasatkin wrote: Earlier kernel contained omap sha1 and md5 driver, which was not maintained, was not ported to new crypto APIs and removed from the source tree. This driver implements async and sync

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-03-24 Thread Dmitry Kasatkin
On 23/03/10 13:32, ext Herbert Xu wrote: On Wed, Mar 17, 2010 at 03:12:49PM +0200, Dmitry Kasatkin wrote: Earlier kernel contained omap sha1 and md5 driver, which was not maintained, was not ported to new crypto APIs and removed from the source tree. This driver implements async and sync

[PATCH 2/2] sec: Makefile/Kconfig update for omap sha1 md5 driver

2010-03-17 Thread Dmitry Kasatkin
Signed-off-by: Dmitry Kasatkin --- drivers/crypto/Kconfig |9 + drivers/crypto/Makefile |2 ++ 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index b08403d..4cca798 100644 --- a/drivers/crypto/Kconfig +++ b/drivers

[PATCH 1/2] sec: omap sha1 & md5 driver

2010-03-17 Thread Dmitry Kasatkin
Earlier kernel contained omap sha1 and md5 driver, which was not maintained, was not ported to new crypto APIs and removed from the source tree. This driver implements async and sync crypto API. Signed-off-by: Dmitry Kasatkin --- drivers/crypto/omap-sha1-md5.c | 1449

[PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver

2010-03-17 Thread Dmitry Kasatkin
Earlier kernel contained omap sha1 and md5 driver, which was not maintained, was not ported to new crypto APIs and removed from the source tree. This driver implements async and sync crypto API. It still contains pr_debug() for debugging purpose. Will be remove for integration. Dmitry Kasatkin

Re: crypto_shash_update & CRYPTO_TFM_REQ_MAY_SLEEP

2010-02-15 Thread Dmitry Kasatkin
ext Herbert Xu wrote: > On Tue, Feb 16, 2010 at 08:36:08AM +0200, Dmitry Kasatkin wrote: > >> Hi, >> >> we have HW accelerator which can be accessed without DMA. >> CPU just sequentially writes data to the port and then reads result. >> > > Well if

<    1   2   3   >