Re: [PATCH 03/17] hw_random: bcm2835-rng: Switch to SPDX identifier

Stefan Wahren writes: > Adopt the SPDX license identifier headers to ease license compliance > management. While we are at this fix the comment style, too. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()

Wei Yongjun <weiyongj...@huawei.com> writes: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature

Re: [PATCH v2 06/12] hwrng: bcm2835-rng: Rework interrupt masking

Stefan Wahren writes: > Hi Florian, > >> Florian Fainelli hat am 8. November 2017 um 01:44 >> geschrieben: >> >> >> The interrupt masking done for Northstart Plus and Northstar (BCM5301X) >> is moved from being a function pointer mapped to

Re: [PATCH v2 12/12] hwrng: bcm63xx-rng: Remove since bcm2835-rng takes over

t the .name handling you settled on works, patches 9, 11, 12 are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature

Re: [PATCH v2 08/12] hwrng: bcm2835-rng: Abstract I/O accessors

the barrier variants now! Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature

Re: [PATCH v2 07/12] hwrng: bcm2835-rng: Manage an optional clock

> static void bcm2835_rng_cleanup(struct hwrng *rng) > @@ -88,6 +97,9 @@ static void bcm2835_rng_cleanup(struct hwrng *rng) > > /* disable rng hardware */ > __raw_writel(0, priv->base + RNG_CTRL); > + > + if (!IS_ERR(priv->clk)) > + clk_disable_unprepare(priv->clk); Same. With those conditionals dropped, Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature

Re: [PATCH v2 06/12] hwrng: bcm2835-rng: Rework interrupt masking

river and some platforms need it. Looks like a fine refactor, though: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature

Re: [PATCH v2 05/12] hwrng: bcm2835-rng: Use device managed helpers

Florian Fainelli <f.faine...@gmail.com> writes: > Now that we have moved the RNG disabling into a hwrng::cleanup callback, > we can use the device managed registration operation and remove our > remove callback since it won't do anything necessary. 3-5 are: Reviewed-by:

Re: [PATCH v2 02/12] hwrng: bcm2835-rng: Define a driver private context

rng_base); > + return PTR_ERR(priv->base); > } > - bcm2835_rng_ops.priv = (unsigned long)rng_base; > + > + priv->rng.name = "bcm2835-rng"; Looks like an unintentional change from the previous "bcm2835" here? Other than that, 1-2 are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature

Re: [PATCH 08/12] hwrng: bcm2835-rng: Abstract I/O accessors

Florian Fainelli writes: > In preparation for allowing BCM63xx to use this driver, we abstract I/O > accessors such that we can easily change those later on. > > Signed-off-by: Florian Fainelli > --- > drivers/char/hw_random/bcm2835-rng.c | 27

Re: [PATCH 12/12] hwrng: bcm63xx-rng: Remove since bcm2835-rng takes over

Florian Fainelli writes: > bcm2835-rng is now capable of supporting the BCM63xx hardware, so remove > the driver which duplicates the same functionality. > > Signed-off-by: Florian Fainelli > --- > drivers/char/hw_random/Kconfig | 13 --- >

Re: [PATCH] char: hw_random: bcm2835: handle of_iomap failures in bcm2835 driver

Arvind Yadav <arvind.yadav...@gmail.com> writes: > Check return value of of_iomap and handle errors correctly. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Acked-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature

Re: [PATCH 1/4] dt-bindings: rng: Northstar Plus SoC rng bindings

Yendapally Reddy Dhananjaya Reddy <yendapally.re...@broadcom.com> writes: > Document the bindings used by Northstar Plus(NSP) SoC random number > generator. > > Signed-off-by: Yendapally Reddy Dhananjaya Reddy > <yendapally.re...@broadcom.com> Acked-by: E

Re: [PATCH 4/4] hwrng: bcm2835: Read as much data as available

num_words = (readl(rng_base + RNG_STATUS) >> 24); Optional cleanup: here and in the return statement, drop the extra parenthesis. Functionality-wise, this patch looks great to me, and should make the driver more efficient. With at least the binary operators change done, it will be: Reviewed-by: Eric Anholt <e...@anholt.net> Thanks! signature.asc Description: PGP signature