On 3/4/2021 10:26 PM, Álvaro Fernández Rojas wrote:
> Hi Florian,
>
>> El 4 mar 2021, a las 23:28, Florian Fainelli escribió:
>>
>> On 3/4/21 7:11 AM, Nicolas Saenz Julienne wrote:
>>> On Wed, 2021-03-03 at 10:29 +0100, Álvaro Fernández Rojas wrote:
>>
On 3/4/21 11:01 PM, Álvaro Fernández Rojas wrote:
> brcm,bcm6368-rng controllers require resetting the IPSEC clock in order to get
> a functional RNG.
>
> Signed-off-by: Álvaro Fernández Rojas
Acked-by: Florian Fainelli
--
Florian
On 3/4/21 11:01 PM, Álvaro Fernández Rojas wrote:
> brcm,bcm6368-rng controllers require enabling the IPSEC clock in order to get
> a functional RNG.
>
> Signed-off-by: Álvaro Fernández Rojas
Acked-by: Florian Fainelli
--
Florian
1-10-10) Continuous run: 0
> rngtest: input channel speed: (min=37.253; avg=320.827; max=635.783)Mibits/s
> rngtest: FIPS tests speed: (min=12.141; avg=15.034; max=16.428)Mibits/s
> rngtest: Program run time: 1336176 microseconds
>
> Signed-off-by: Álvaro Fernández Rojas
Acked-by: Florian Fainelli
--
Florian
On 3/4/21 7:11 AM, Nicolas Saenz Julienne wrote:
> On Wed, 2021-03-03 at 10:29 +0100, Álvaro Fernández Rojas wrote:
>> Hi Herbert,
>>
>>> El 3 mar 2021, a las 10:20, Herbert Xu
>>> escribió:
>>>
>>> On Sat, Feb 20, 2021 at 08:12:45PM +0100, Álvaro Fernández Rojas wrote:
I ran rngtest an
On 3/3/21 6:06 AM, Álvaro Fernández Rojas wrote:
> Hi Philipp,
>
>> El 3 mar 2021, a las 14:52, Philipp Zabel escribió:
>>
>> Hi Álvaro,
>>
>> On Wed, 2021-02-24 at 09:22 +0100, Álvaro Fernández Rojas wrote:
>> [...]
>>> @@ -115,6 +121,8 @@ static void bcm2835_rng_cleanup(struct hwrng *rng)
>>>
On 2/23/2021 9:00 AM, Álvaro Fernández Rojas wrote:
> BCM6368 devices need to reset the in order to generate true random numbers.
> This is what BCM6368 produces without a reset:
> root@OpenWrt:/# cat /dev/hwrng | rngtest -c 1000
> rngtest 6.10
> Copyright (c) 2004 by Henrique de Moraes Holschuh
On 2/23/2021 8:01 AM, Álvaro Fernández Rojas wrote:
> Some devices may need to perform a reset before using the RNG, such as the
> BCM6368.
>
> Signed-off-by: Álvaro Fernández Rojas
Since the reset is unique to the 6368, you may want to make the property
mandatory for the 6368 compatible stri
On 2/9/2021 5:14 PM, Tian Tao wrote:
> clk_prepare_enable() and clk_disable_unprepare() will check
> NULL clock parameter, so It is not necessary to add additional checks.
>
> Signed-off-by: Tian Tao
Acked-by: Florian Fainelli
Thanks for the quick spin!
--
Florian
On 2/8/21 10:25 PM, Tian Tao wrote:
> clk_prepare_enable() and clk_disable_unprepare() will check
> NULL clock parameter, so It is not necessary to add additional checks.
>
> Signed-off-by: Tian Tao
I don't believe this is going to work unless you also change
devm_clk_get() to devm_clk_get_optio
: kernel test robot
Signed-off-by: Florian Fainelli
---
drivers/crypto/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index e535f28a8028..c833ac08ea81 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
ady set
> the enable bit to zero by appling inverted RNG_RBGEN_MASK.
>
> Signed-off-by: Matthias Brugger
Acked-by: Florian Fainelli
--
Florian
; Fixes: c83d45d5685f ("hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver")
> Signed-off-by: Matthias Brugger
Acked-by: Florian Fainelli
--
Florian
Since you are refactoring this into a new function, do you mind changing
the variable to u32 to match the kernel code? With that fixed:
Acked-by: Florian Fainelli
Thanks!
--
Florian
: Florian Fainelli
--
Florian
ers/char/hw_random/bcm2835-rng.o
>
> After:
>textdata bss dec hex filename
>2464 104 02568 a08 drivers/char/hw_random/bcm2835-rng.o
>
> Signed-off-by: Rikard Falkeborn
Acked-by: Florian Fainelli
--
Florian
On 10/16/19 3:46 AM, YueHaibing wrote:
> devm_platform_ioremap_resource() internally have platform_get_resource()
> and devm_ioremap_resource() in it. So instead of calling them separately
> use devm_platform_ioremap_resource() directly.
Did your coccinelle script not cover
drivers/char/hw_random/
On 10/16/19 3:46 AM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing
Acked-by: Florian Fainelli
--
Florian
us Elfring
Reviewed-by: Florian Fainelli
--
Florian
On 5/22/19 10:37 PM, Herbert Xu wrote:
> On Mon, May 20, 2019 at 03:49:12PM -0700, Florian Fainelli wrote:
>> On 5/10/19 10:31 AM, Florian Fainelli wrote:
>>> Hi Herbert,
>>>
>>> This patch series adds support for BCM7211 to the iproc-rng200 driver,
>
On 5/10/19 10:31 AM, Florian Fainelli wrote:
> BCM7211 features a RNG200 block, document its compatible string.
>
> Signed-off-by: Florian Fainelli
Rob, does this look okay to you?
> ---
> Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt | 1 +
> 1 file ch
On 5/10/19 10:31 AM, Florian Fainelli wrote:
> Hi Herbert,
>
> This patch series adds support for BCM7211 to the iproc-rng200 driver,
> nothing special besides matching the compatibile string and updating the
> binding document.
Herbert, can you apply those patches?
>
>
if we are probing from device
> tree.
>
> Fixes: 8705f24f7b57 ("hwrng: bcm2835 - Enable BCM2835 RNG to work on BCM63xx
> platforms")
> Signed-off-by: Jonas Gorski
Acked-by: Florian Fainelli
Sorry about that, thanks for the fix!
--
Florian
On 11/6/18 12:28 AM, Raveendra Padasalagi wrote:
> Remove setkey() callback handler for normal/non key
> hash algorithms and keep it for AES-CBC/CMAC which needs key.
>
> Signed-off-by: Raveendra Padasalagi
Should this have the following Fixes tag?
Fixes: 9d12ba86f818 ("crypto: brcm - Add Broad
On Sat, 18 Nov 2017 14:04:13 +0100, Stefan Wahren
wrote:
> This patch adds the missing interrupt property to the RNG block
> of BCM283x.
>
> Link: https://github.com/raspberrypi/linux/issues/2195
> CC: Florian Fainelli
> Signed-off-by: Stefan Wahren
> ---
Applied to de
ink: https://github.com/raspberrypi/linux/issues/2195
> CC: Florian Fainelli
> Signed-off-by: Stefan Wahren
Applied to devicetree/next, thanks!
--
Florian
ck")
> Signed-off-by: Stefan Wahren
Acked-by: Florian Fainelli
Thanks Stephan!
--
Florian
On 01/17/2018 03:40 AM, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun
Acked-by: Florian Fainelli
--
Florian
On 11/28/2017 10:30 PM, Herbert Xu wrote:
> On Tue, Nov 07, 2017 at 04:44:38PM -0800, Florian Fainelli wrote:
>> In preparation for consolidating bcm63xx-rng into bcm2835-rng, make sure
>> that we obtain the base register via platform_get_resource() since we
>> need to suppo
We should be disabling the RNG in a hwrng::cleanup callback if we are
not longer the system selected RNG, not wait until the device driver is
removed.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions
In preparation for consolidating bcm63xx-rng into bcm2835-rng, make sure
that we obtain the base register via platform_get_resource() since we
need to support the non-DT enabled MIPS-based BCM63xx DSL SoCs.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 20
Instead of making hwrng::priv host the base register address, define a
driver private context, make it per platform device instance and pass it
down the different functions.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 55 ++--
1
One of the last steps before bcm63xx-rng can be eliminated is to manage
a clock during hwrng::init and hwrng::cleanup, so fetch it in the probe
function, and manage it during these two steps when valid.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 17
Broadcom MIPS HW is always strapped to match the system-wide endian such
that all I/O access to this RNG block is done with the native CPU
endian, account for that.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 13 +++--
1 file changed, 11 insertions(+), 2
In preparation for allowing BCM63xx to use this driver, we abstract I/O
accessors such that we can easily change those later on.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff
we need to add a second type of platform information, we would
have to do that anyway.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 39 +---
1 file changed, 23 insertions(+), 16 deletions(-)
diff --git a/drivers/char/hw_random/bcm2835
Now that we have moved the RNG disabling into a hwrng::cleanup callback,
we can use the device managed registration operation and remove our
remove callback since it won't do anything necessary.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 13 +
1
We have now incorporated all necessary functionality for the BCM63xx
platforms to successfully migrate over bcm2835-rng, so add the final
bits: Kconfig selection and proper platform_device device type matching
to keep the same platform device name for registration to work.
Signed-off-by: Florian
Since the same block is used on BCM2835 and BCM6368, merge the bindings
and remove the brcm,bcm6368.txt binding document.
Acked-by: Rob Herring
Signed-off-by: Florian Fainelli
---
.../devicetree/bindings/rng/brcm,bcm2835.txt | 22 +++---
.../devicetree/bindings/rng/brcm
bcm2835-rng is now capable of supporting the BCM63xx hardware, so remove
the driver which duplicates the same functionality.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/Kconfig | 13 ---
drivers/char/hw_random/Makefile | 1 -
drivers/char/hw_random/bcm63xx-rng.c
We should be moving the enabling of the HWRNG into a hwrng::init
callback since we can be disabled and enabled every time a different
hwrng is selected in the system.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 16
1 file changed, 12 insertions
warm up count and the number of words available in the
FIFO size.
Thanks!
Changes in v2:
- rework the logic about how we manage the optional clock
- use pdev->name for the rng.name member
Florian Fainelli (12):
hwrng: bcm2835-rng: Obtain base register via resource
hwrng: bcm2835-rng: Defin
On 11/04/2017 11:27 AM, Stefan Wahren wrote:
> Hi Florian
>
>> Florian Fainelli hat am 2. November 2017 um 02:04
>> geschrieben:
>>
>>
>> We have now incorporated all necessary functionality for the BCM63xx
>> platforms to successfully migrate over bcm2
Hi Stefan,
On 11/04/2017 06:50 AM, Stefan Wahren wrote:
> Hi Florian,
>
>> Florian Fainelli hat am 2. November 2017 um 02:04
>> geschrieben:
>>
>>
>> One of the last steps before bcm63xx-rng can be eliminated is to manage
>> a clock during hwrng::i
On 11/03/2017 01:19 PM, Eric Anholt wrote:
> Florian Fainelli writes:
>
>> In preparation for allowing BCM63xx to use this driver, we abstract I/O
>> accessors such that we can easily change those later on.
>>
>> Signed-off-by: Florian Fainelli
>> ---
>
On 11/03/2017 01:18 PM, Eric Anholt wrote:
> Florian Fainelli writes:
>
>> bcm2835-rng is now capable of supporting the BCM63xx hardware, so remove
>> the driver which duplicates the same functionality.
>>
>> Signed-off-by: Florian Fainelli
>> ---
>>
Hi Stefan,
On 11/02/2017 12:01 PM, Stefan Wahren wrote:
> Hi Florian,
>
>> Florian Fainelli hat am 2. November 2017 um 02:03
>> geschrieben:
>>
>>
>> Hi,
>>
>> As it usually happens when there is a fair amount of HW IP block re-use,
>&g
Instead of making hwrng::priv host the base register address, define a
driver private context, make it per platform device instance and pass it
down the different functions.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 55 ++--
1
warm up count and the number of words available in the
FIFO size.
Thanks!
Florian Fainelli (12):
hwrng: bcm2835-rng: Obtain base register via resource
hwrng: bcm2835-rng: Define a driver private context
hwrng: bcm2835-rng: Move enabling to hwrng::init
hwrng: bcm2835-rng: Implementation
Now that we have moved the RNG disabling into a hwrng::cleanup callback,
we can use the device managed registration operation and remove our
remove callback since it won't do anything necessary.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 13 +
1
In preparation for consolidating bcm63xx-rng into bcm2835-rng, make sure
that we obtain the base register via platform_get_resource() since we
need to support the non-DT enabled MIPS-based BCM63xx DSL SoCs.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 20
We should be moving the enabling of the HWRNG into a hwrng::init
callback since we can be disabled and enabled every time a different
hwrng is selected in the system.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 16
1 file changed, 12 insertions
We should be disabling the RNG in a hwrng::cleanup callback if we are
not longer the system selected RNG, not wait until the device driver is
removed.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions
we need to add a second type of platform information, we would
have to do that anyway.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 39 +---
1 file changed, 23 insertions(+), 16 deletions(-)
diff --git a/drivers/char/hw_random/bcm2835
One of the last steps before bcm63xx-rng can be eliminated is to manage
a clock during hwrng::init and hwrng::cleanup, so fetch it in the probe
function, and manage it during these two steps when valid.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 14
Broadcom MIPS HW is always strapped to match the system-wide endian such
that all I/O access to this RNG block is done with the native CPU
endian, account for that.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 13 +++--
1 file changed, 11 insertions(+), 2
Since the same block is used on BCM2835 and BCM6368, merge the bindings
and remove the brcm,bcm6368.txt binding document.
Signed-off-by: Florian Fainelli
---
.../devicetree/bindings/rng/brcm,bcm2835.txt | 22 +++---
.../devicetree/bindings/rng/brcm,bcm6368.txt | 17
We have now incorporated all necessary functionality for the BCM63xx
platforms to successfully migrate over bcm2835-rng, so add the final
bits: Kconfig selection and proper platform_device device type matching
to keep the same platform device name for registration to work.
Signed-off-by: Florian
bcm2835-rng is now capable of supporting the BCM63xx hardware, so remove
the driver which duplicates the same functionality.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/Kconfig | 13 ---
drivers/char/hw_random/Makefile | 1 -
drivers/char/hw_random/bcm63xx-rng.c
In preparation for allowing BCM63xx to use this driver, we abstract I/O
accessors such that we can easily change those later on.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm2835-rng.c | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff
Hi,
This patch series adds support for the RNG200 block found on the BCM7278 SoC.
This requires us to update the compatible string (and associated binding
document) as well as the Kconfig option to make that driver selectable with
ARCH_BRCMSTB gating the enabling of such SoCs.
Thank you
Florian
BCM7278 includes a RGN200 hardware random number generator, document the
compatible string for that version of the IP.
Signed-off-by: Florian Fainelli
---
Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a
BCM7278 features a RNG200 hardware random number generator block, add
support for this chip by matching the chip-specific compatible string
and extending the Kconfig dependencies to allow building on ARCH_BRCMSTB
(base platform for 7278).
Signed-off-by: Florian Fainelli
---
drivers/char
On 03/06/2017 11:22 AM, Florian Fainelli wrote:
> On 02/28/2017 12:31 PM, Florian Fainelli wrote:
>> On 02/22/2017 01:22 PM, Steve Lin wrote:
>>> Adds crypto hardware (SPU) to Northstar Plus device tree file.
>>>
>>> Signed-off-by: Steve Lin
>>
>> A
On 02/28/2017 12:31 PM, Florian Fainelli wrote:
> On 02/22/2017 01:22 PM, Steve Lin wrote:
>> Adds crypto hardware (SPU) to Northstar Plus device tree file.
>>
>> Signed-off-by: Steve Lin
>
> Applied, thanks!
And dropped, since there is a dependency on "ARM: dt
On 02/22/2017 01:22 PM, Steve Lin wrote:
> Adds crypto hardware (SPU) to Northstar Plus device tree file.
>
> Signed-off-by: Steve Lin
Applied, thanks!
--
Florian
On 02/13/2017 07:11 AM, Jon Mason wrote:
> On Sat, Feb 11, 2017 at 5:54 AM, Herbert Xu
> wrote:
>> On Fri, Feb 03, 2017 at 12:55:31PM -0500, Rob Rice wrote:
>>> Changes in v4:
>>> - Added Rob Herring's Acked-by to patch 1/3 for bindings doc
>>> - In response to Herbert's comment, in ahash_export(
On 01/25/2017 08:44 AM, Rob Rice wrote:
> Changes in v3:
> - rebase to 4.10-rc3 in cryptodev-2.6 tree
> - in bindings doc, list all valid compatibility strings
> - rename DT nodes "crypto" rather than "spu-crypto"
> - include a separate DT node for each SPU hardware block. Previously,
> there was
On 06/22/2016 05:27 PM, Florian Fainelli wrote:
> Add the DT node for the random number generator peripheral.
>
> Signed-off-by: Florian Fainelli
Applied
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord
On 06/24/2016 06:31 AM, Herbert Xu wrote:
> On Wed, Jun 22, 2016 at 05:27:02PM -0700, Florian Fainelli wrote:
>> The Broadcom BCM5301x SoCs (Northstar) utilize the same random number
>> generator peripheral as Northstar Plus and BCM2835, but just like the
>> NSP SoC,
Add the DT node for the random number generator peripheral.
Signed-off-by: Florian Fainelli
---
arch/arm/boot/dts/bcm5301x.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
index 7d4d29bf0ed3..c67e451435f4 100644
Document the binding used by the Broadcom BCM5301x (Northstar) SoC
random number generator.
Signed-off-by: Florian Fainelli
---
Documentation/devicetree/bindings/rng/brcm,bcm2835.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/rng/brcm
The Broadcom BCM5301x SoCs (Northstar) utilize the same random number
generator peripheral as Northstar Plus and BCM2835, but just like the
NSP SoC, we need to enable the interrupt.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/Kconfig | 2 +-
drivers/char/hw_random/bcm2835
Hi all,
This patch series adds support for the Broadcom BCM5301x SoCs random number
generator which is the same block as the one found in NSP and BCM2835.
Florian Fainelli (3):
Documentation: devicetree: bindings: Add BCM5301x binding
hw_random: bcm2835: Add support for Broadcom BCM5301x
On 05/31/2016 03:19 AM, Herbert Xu wrote:
> On Fri, May 27, 2016 at 06:10:37AM -0400, Yendapally Reddy Dhananjaya Reddy
> wrote:
>> This patchset contains the hw random number generator support for the
>> Broadcom's NSP SoC. The block is similar to the block available in
>> bcm2835 with different
Hi,
This patchset prepares the driver to be built on non-MIPS bcm63xx architectures
such as the ARM bcm63xx variants, thanks!
Although patch 3 touches a MIPS header file, there should be little to no
conflicts there if all patches went through the hw_random tree (is there one?)
Thanks!
Florian
arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h contains the register
definitions for this random number generator block, incorporate these
register definitions directly into the bcm63xx-rng driver so we do not
rely on this header to be provided.
Signed-off-by: Florian Fainelli
---
drivers
Simplify the driver's probe function and error handling by using the
device managed allocators, while at it, drop the redundant "out of
memory" messages since these are already printed by the allocator.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm
Now that these definitions have been moved to
drivers/char/hw_random/bcm63xx-rng.c where they belong to make the
driver standalone, we can safely remove these definitions from
bcm63xx_regs.h.
Signed-off-by: Florian Fainelli
---
arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h | 14
bcm_{readl,writel} macros expand to __raw_{readl,writel}, use these
directly such that we do not rely on the platform to provide these for
us. As a result, we no longer use bcm63xx_io.h, so remove that inclusion
too.
Signed-off-by: Florian Fainelli
---
drivers/char/hw_random/bcm63xx-rng.c | 13
80 matches
Mail list logo