Re: [PATCH -next 09/12] crypto: rockchip - use devm_platform_ioremap_resource() to simplify code

Am Freitag, 2. August 2019, 15:28:06 CEST schrieb YueHaibing: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing looks like nice and simple improvement Reviewed-by: Heiko St

Re: [Bug] Rockchip crypto driver sometimes produces wrong ciphertext

(also add Ezequiel who has spent a bit of time on the rockchip crypto driver recently) Am Sonntag, 27. Januar 2019, 09:54:54 CET schrieb Ard Biesheuvel: > (add LAKML and arm-soc maintainers) > > On Sat, 26 Jan 2019 at 22:05, Eric Biggers wrote: > > > > Hello, > > > > I don't know whether anyone

Re: [PATCH v3 3/4] Crypto: rockchip/crypto - add crypto driver for rk3288

Hi Zain, Am Freitag, 13. November 2015, 14:44:43 schrieb Zain: > > On 2015年11月12日 20:32, Heiko Stuebner wrote: > > Hi Zain, > > > > I was able to sucessfully test your crypto-driver, but have found some > > improvements below that should probably get looked at: >

Re: [PATCH v3 3/4] Crypto: rockchip/crypto - add crypto driver for rk3288

Hi Zain, I was able to sucessfully test your crypto-driver, but have found some improvements below that should probably get looked at: Am Mittwoch, 11. November 2015, 14:35:58 schrieb Zain Wang: > Crypto driver support: > ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) > You

Re: [PATCH v3 4/4] ARM: dts: rockchip: Add Crypto node for rk3288

Am Mittwoch, 11. November 2015, 14:35:59 schrieb Zain Wang: > Add Crypto node for rk3288 including crypto controller and dma clk. > > Signed-off-by: Zain Wang I'd like to pick this one and the clock-patch2 up, once the crypto driver itself got accepted and we have an Ack from the clock-maintaine

Re: [PATCH v3 0/4] crypto: add crypto accelerator support for rk3288

ly for modes 200 (aes), 201 (des3) and 204 (des), so this series Tested-by: Heiko Stuebner > > Changed in v3: > - add OF depended in Kconfig > - rename some variate > - add reset property > - remove crypto_p variate > > Changed in v2: > - remove some part abou

Re: [PATCH v3 2/4] clk: rockchip: set an ID for crypto clk

Am Donnerstag, 12. November 2015, 09:13:20 schrieb Zain: > > On 2015年11月12日 07:57, Heiko Stuebner wrote: > > Am Mittwoch, 11. November 2015, 14:35:57 schrieb Zain Wang: > >> Set an ID for crypto clk, so that it can be called in other part. > >> > >> Signed-o

Re: [PATCH v3 2/4] clk: rockchip: set an ID for crypto clk

Am Mittwoch, 11. November 2015, 14:35:57 schrieb Zain Wang: > Set an ID for crypto clk, so that it can be called in other part. > > Signed-off-by: Zain Wang this should go in together with patch4, the dts change, so an Ack from the clock-maintainers would be nice :-) Heiko > --- > > Changed

Re: [PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

Hi Zain, looks like my comment on v1 came later than your v2 submission, so here it is again :-) Am Freitag, 6. November 2015, 09:17:21 schrieb Zain Wang: > The names registered are: > ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) > You can alloc tags above in your case. >

Re: [PATCH v1 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

Hi Zain, Am Dienstag, 3. November 2015, 13:52:05 schrieb Zain Wang: > Crypto driver support cbc/ecb two chainmode, and aes/des/des3 three cipher > mode. > The names registered are: > ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) > You can alloc tags above in your case. > > A

Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

Am Freitag, 6. November 2015, 09:17:23 schrieb Zain Wang: > Add Crypto drivers for rk3288 including crypto controller and dma clk. > > Signed-off-by: Zain Wang > --- > > Changed in v2: > - None > > Changed in v1: > - remove the _crypto suffix > - use "rockchip,rk3288-crypto" instead of "rockchi

Re: [PATCH v2 4/4] crypto: rockchip/crypto - add DT bindings documentation

Am Freitag, 6. November 2015, 09:17:24 schrieb Zain Wang: > Add DT bindings documentation for the rk3288 crypto drivers. > > Signed-off-by: Zain Wang > --- > > Changde in v2: > - None > > Changed in v1: > - remove the _crypto suffix > - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"

Re: [RESEND PATCH 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

Hi, first of all, thanks for working on this, it will be really cool to see the crypto accelerator supported in the kernel :-) Am Freitag, 30. Oktober 2015, 16:22:46 schrieb Zain Wang: > Crypto driver support cbc/ecb two chainmode, and aes/des/des3 three cipher > mode. > The names registered are

Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation

Hi, Am Freitag, 30. Oktober 2015, 16:22:49 schrieb Zain Wang: > Add DT bindings documentation for the rk3288 crypto drivers. > > Signed-off-by: Zain Wang > --- > .../devicetree/bindings/crypto/rk-crypto.txt | 31 > ++ > 1 file changed, 31 insertions(+) > create mode

Re: [RESEND PATCH 2/4] clk: rockchip: set an id for crypto clk

Hi Zain, Am Freitag, 30. Oktober 2015, 16:22:47 schrieb Zain Wang: > set an id for crypto clk, so that it can be called in other part. > > Signed-off-by: Zain Wang > --- > drivers/clk/rockchip/clk-rk3288.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/roc