[ANNOUNCE][CFP] Linux Security Summit 2021

2021-02-08 Thread James Morris
LinuxSecSummit #linuxsecuritysummit PROGRAM COMMITTEE The program committee for LSS 2021 is: * James Morris, Microsoft * Serge Hallyn, Cisco * Paul Moore, Cisco * Stephen Smalley, NSA * Elena Reshetova, Intel * John Johansen, Canonical * Kees Cook, Google * Casey Sc

Re: [PATCH v8 00/14] Appended signatures support for IMA appraisal

2018-12-04 Thread James Morris
rs at all, and this will work with existing signed modules? -- James Morris

Re: [PATCH v2][RESEND] X.509: unpack RSA signatureValue field from BIT STRING

2018-06-20 Thread James Morris
On Thu, 21 Jun 2018, Herbert Xu wrote: > Hi James: > > I presume you will pick this up then? I will -- not sure why David hasn't merged it into his tree. Can I add your acked or reviewed by? -- James Morris

Re: [PATCH v2][RESEND] X.509: unpack RSA signatureValue field from BIT STRING

2018-06-20 Thread James Morris
re > > > is missing/invalid > > > > Kernel modules signature verification probably has similar problem, too. > > > > That's why it would be nice if you could ack this patch, please. > > David/James, is there an issue with the patch? Not from my POV. -- James Morris

[ANNOUNCE] Linux Security Summit North America 2018 - CFP

2018-04-09 Thread James Morris
S 2018 is: * James Morris, Microsoft * Serge Hallyn, Cisco * Paul Moore, Red Hat * Stephen Smalley, NSA * Elena Reshetova, Intel * John Johansen, Canonical * Kees Cook, Google * Casey Schaufler, Intel * Mimi Zohar, IBM * David A. Wheeler, Institute for Defense Analys

Re: [PATCH v2] tpm: Move Linux RNG connection to hwrng

2018-01-30 Thread James Morris
to be that way? > > > > 1. > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=6e592a065d51d26f9d62b8b7501a5114076af8b4 > > > > Thanks, > > PrasannaKumar > > Yes, it would be senseful. > > James, would it still be possible to amend this tag to security tree? Nope, it's been pushed to Linus. -- James Morris

Re: [PATCH] pkcs7: fix check for self-signed certificate

2017-11-27 Thread James Morris
#x27;t know them, then we can't accept them. > */ > - if (x509->next == x509) { > + if (x509->signer == x509) { > kleave(" = -ENOKEY [unknown self-signed]"); > return -ENOKEY; > } > -- Reviewed-by: James Morris -- James Morris

Re: [PATCH] pkcs7: return correct error code if pkcs7_check_authattrs() fails

2017-11-27 Thread James Morris
; > - if (ret < 0) > + if (ret < 0) { > + msg = ERR_PTR(ret); > goto out; > + } > > msg = ctx->msg; > ctx->msg = NULL; Reviewed-by: James Morris -- James Morris

Re: [PATCH] X.509: fix buffer overflow detection in sprint_oid()

2017-11-27 Thread James Morris
On Sun, 26 Nov 2017, Eric Biggers wrote: > > Fixes: 4f73175d0375 ("X.509: Add utility functions to render OIDs as strings") > Cc: Takashi Iwai > Signed-off-by: Eric Biggers > --- > lib/oid_registry.c | 8 > 1 file changed, 4 insertions(+), 4 deletions

Re: [PATCH] X.509: fix comparisons of ->pkey_algo

2017-11-27 Thread James Morris
gers > --- > crypto/asymmetric_keys/pkcs7_verify.c| 2 +- > crypto/asymmetric_keys/x509_public_key.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: James Morris -- James Morris

Re: [PATCH] crypto: rsa - fix buffer overread when stripping leading zeroes

2017-11-27 Thread James Morris
return -EINVAL; > > if (fips_enabled) { > - while (!*ptr && n_sz) { > + while (n_sz && !*ptr) { > ptr++; > n_sz--; > } Reviewed-by: James Morris -- James Morris

Re: [PATCH] X.509: reject invalid BIT STRING for subjectPublicKey

2017-11-27 Thread James Morris
On Sun, 26 Nov 2017, Eric Biggers wrote: > Fixes: 42d5ec27f873 ("X.509: Add an ASN.1 decoder") > Cc: # v3.7+ > Signed-off-by: Eric Biggers > --- > crypto/asymmetric_keys/x509_cert_parser.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: James Morris -- James Morris

Re: [PATCH] ASN.1: check for error from ASN1_OP_END__ACT actions

2017-11-27 Thread James Morris
On Sun, 26 Nov 2017, Eric Biggers wrote: > Fixes: 42d5ec27f873 ("X.509: Add an ASN.1 decoder") > Cc: # v3.7+ > Signed-off-by: Eric Biggers Reviewed-by: James Morris -- James Morris

Re: [GIT PULL] KEYS: Fixes and crypto fixes

2017-09-27 Thread James Morris
On Wed, 27 Sep 2017, Eric Biggers wrote: > On Thu, Sep 28, 2017 at 09:14:58AM +1000, James Morris wrote: > > On Wed, 27 Sep 2017, David Howells wrote: > > > > > (2) Fixing big_key to use safe crypto from Jason A. Donenfeld. > > > > > > > I'm c

Re: [GIT PULL] KEYS: Fixes and crypto fixes

2017-09-27 Thread James Morris
s code? If not, it would be good to make some. -- James Morris

[ANNOUNCE] Linux Security Summit 2017 - CFP

2017-03-23 Thread James Morris
ut to the development process. WEB SITE http://events.linuxfoundation.org/events/linux-security-summit TWITTER For event updates and announcements, follow: https://twitter.com/LinuxSecSummit PROGRAM COMMITTEE The program committee for LSS 2017 is: * James Morris, Oracle

Re: [PATCH] KEYS: Add placeholder for KDF usage with DH

2016-05-31 Thread James Morris
> Is this likely to go to Linus before -rc2? If not, we'll need to do things > differently. It should be ok, I'll see how it goes with Linus. -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to m

[ANNOUNCE] Linux Security Summit 2016 - CFP

2016-03-24 Thread James Morris
t and operational practices * Emerging technologies, threats & techniques Proposals should be submitted via the event web site: http://events.linuxfoundation.org/events/linux-security-summit/program/cfp PROGRAM COMMITTEE The Linux Security Summit for 2016 is organized by:

Re: [GIT PULL] KEYS: Miscellaneous bits for security/next

2016-03-03 Thread James Morris
On Fri, 4 Mar 2016, David Howells wrote: > Hi James, > > Could you pull this into security/next, please? > Done. -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More m

Re: Transferring applied X.509 patches from crypto/next to security/next

2016-02-08 Thread James Morris
at you'll > > fix it up later. Sorry for the misunderstanding. Do you want me to > > revert? > > If you can back them out, I'll apply them to my keys-next branch. Unless > James is willing to rebase security/next on top of your crypto branch? > I don't want to

Re: [PATCH v4] keys, trusted: select hash algorithm for TPM2 chips

2015-11-09 Thread James Morris
On Thu, 5 Nov 2015, Jarkko Sakkinen wrote: > v4: > > * Added missing select CRYPTO_HASH_INFO in drivers/char/tpm/Kconfig > > Signed-off-by: Jarkko Sakkinen Reviewed-by: James Morris -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [GIT PULL] Move cert handling to certs/ directory

2015-08-25 Thread James Morris
> place to make them easier to find and clean up. > Pulled to my next branch, thanks. - James -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [GIT PULL] ASN.1 fixes

2015-08-06 Thread James Morris
his class of bugfix. -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] ASN.1: Fix handling of CHOICE in ASN.1 compiler

2015-08-05 Thread James Morris
ate in the -rc cycle. -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[CFP] Reminder: Linux Security Summit 2015 CFP closes this Friday 5th June

2015-06-03 Thread James Morris
even developers -- any interesting/novel application of Linux security or research is welcome. We're also looking for round-table discussion topics, and people to lead those discussions. Get your proposals in soon! - James -- James Morris -- To unsubscribe from this list: send the line &q

Re: [GIT PULL] Keyrings: PKCS#7 fixup

2014-07-25 Thread James Morris
#7: Missing inclusion of linux/err.h (2014-07-25 11:33:53 +0100) Thanks, pulled. -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [GIT PULL] Keyrings and asymmetric keys patches for 3.17

2014-07-24 Thread James Morris
On Tue, 22 Jul 2014, David Howells wrote: > I have a number of sets of patches for you to pull. I've git-merged them > together into a single branch (keys-next) as there are some conflicts and > tagged the end. Pulled, thanks. -- James Morris -- To unsubscribe from this list:

[ANNOUNCE] Linux Security Summit 2013 - CFP

2013-05-06 Thread James Morris
The Linux Security Summit for 2013 is organized by: * James Morris, Oracle * Serge Hallyn, Canonical * Paul Moore, Red Hat * Stephen Smalley, NSA * Joshua Brindle, Quark Security * Herbert Xu, Red Hat * John Johansen, Canonical * Kees Cook, Google * Cas

Re: [PATCH 2/2] mpilib: use DIV_ROUND_UP and remove unused macros

2013-01-31 Thread James Morris
On Wed, 30 Jan 2013, Dmitry Kasatkin wrote: > From: Andy Shevchenko > > Remove MIN, MAX and ABS macros that are duplicates kernel's native > implementation. > > Signed-off-by: Andy Shevchenko Applied. As maintainer, you should have added your signed-off-by.

Re: [PATCH 1/2] digsig: remove unnecessary memory allocation and copying

2013-01-31 Thread James Morris
On Wed, 30 Jan 2013, Dmitry Kasatkin wrote: > In existing use case, copying of the decoded data is unnecessary in > pkcs_1_v1_5_decode_emsa. It is just enough to get pointer to the message. > Removing copying and extra buffer allocation. Applied. -- James Morris -- To unsubscribe

Re: [PATCH 14/16] X.509: Add an ASN.1 decoder

2012-09-18 Thread James Morris
he UEFI signature/key database may contain ASN.1 X.509 certificates > > and > > we may need to use those very early in the boot process, during initrd. > > Ok that makes some sense. I'd like to see some serious effort at code review and testing before this code is m

[ANN] Linux Security Summit 2012 - Announcement and CFP

2012-04-12 Thread James Morris
mail to the program committee at: lss-pc (_at_) ext.namei.org Abstracts should be approximately 150 words in total. PROGRAM COMMITTEE The Linux Security Summit for 2012 is organized by: * James Morris, Oracle * Serge Hallyn, Canonical * Paul Moore, Red Hat * Stephen Smalle

Re: [Keyrings] [RFC][PATCH 00/16] Crypto keys and module signing [ver #2]

2011-12-05 Thread James Morris
On Mon, 5 Dec 2011, David Howells wrote: > However, we don't have to include the DSA stuff in the kernel; I can always > discard that patch from the upstream-aimed patchset. I'd encourage dropping DSA, as there appears to be no legacy justification for its inclusion. - James

Re: [PATCH v2.2 1/7] crypto: GnuPG based MPI lib - source files (part 1)

2011-11-21 Thread James Morris
On Mon, 21 Nov 2011, Kasatkin, Dmitry wrote: > It can be easily split into 2 commits and one of them would not comply > with mailing list limits. > > James, should I do anything about it? No, it's in my public tree now. - James -- James Morris -- To unsubscribe from this li

Re: [PATCH v2.1 4/7] crypto: GnuPG based MPI lib - additional sources (part 4)

2011-10-17 Thread James Morris
On Mon, 17 Oct 2011, Kasatkin, Dmitry wrote: > It is there for completeness and it will not be even compiled at all > without CONFIG_MPILIB_EXTRA > > Still remove? Yes, please. -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-crypto&

Re: [PATCH v2.1 4/7] crypto: GnuPG based MPI lib - additional sources (part 4)

2011-10-14 Thread James Morris
On Fri, 14 Oct 2011, Dmitry Kasatkin wrote: > +#if 0/* not yet ported to MPI */ > + > +mpi_limb_t > +mpihelp_udiv_w_sdiv(mpi_limp_t *rp, > + mpi_limp_t *a1, mpi_limp_t *a0, mpi_limp_t *d) Drop this if it's not working. --

Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)

2011-10-14 Thread James Morris
type. Also, kmalloc return values do not need to be cast, they're void *. > +EXPORT_SYMBOL(mpi_alloc); New interfaces should be EXPORT_SYMBOL_GPL. -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@

Re: [RFC v2.1 0/6] evm: digital signature verification extension

2011-09-28 Thread James Morris
On Thu, 29 Sep 2011, Herbert Xu wrote: > Well if James is OK with adding the user for this then I'm fine > with adding the necessary infrastructure. Are you happy with the API? -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in

Re: [RFC v2.1 0/6] evm: digital signature verification extension

2011-09-26 Thread James Morris
On Mon, 26 Sep 2011, Kasatkin, Dmitry wrote: > It seems nobody wants to share their thoughts about it? > Does this silence mean acceptance? > Should I prepare final patches for merge? Not yet. I'd like to hear what the crypto folk think about the crypto. -- James Morris --

Re: [RFC v1.1 3/5] evm: digital signature support

2011-08-15 Thread James Morris
gital signature. > This patch enables RSA signature based integrity verification. This description (also the kconfig text) is not very clear. Perhaps start with what the feature does rather than what the lack of it doesn't. -- James Morris -- To unsubscribe from this list: send the

Re: [RFC v1.1 2/5] crypto: ksign - digital signature verification support

2011-08-15 Thread James Morris
t; + down_read(&key->sem); > + ukp = key->payload.data; > + pkh = (struct pubkey_hdr *)ukp->data; > + > + if (pkh->version != 1) > + return -EINVAL; > + > + if (pkh->algo != PUBKEY_ALGO_RSA) > + return -EINVAL; Are you

Re: [RFC v1.1 1/5] crypto: GnuPG based MPI lib

2011-08-15 Thread James Morris
6. First thing -- this code needs to be formatted using kernel coding style. - James -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[ANN] Linux Security Summit 2011 - Announcement and CFP

2011-04-04 Thread James Morris
inux Security Summit for 2011 is organized by: * James Morris, Red Hat * Serge Hallyn, Canonical * Paul Moore, HP * Stephen Smalley, NSA * Joshua Brindle, Tresys * Tetsuo Handa, NTT Data * Herbert Xu, Red Hat * John Johansen, Canonical * Kees Cook, Canonical * Casey

Re: [PATCH v1.5 0/5] keys: trusted and encrypted keys

2010-11-28 Thread James Morris
kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] keys: added cleanup code for trusted and encrypted key types

2010-10-07 Thread James Morris
ommit known-broken code into the tree. -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[ANNOUNCE] Linux Security Summit 2010 - Schedule Published

2010-06-16 Thread James Morris
Updates and announcements about the event will also be sent to the list. WEB SITE Please also note the Linux Security Summit web site: https://security.wiki.kernel.org/index.php/LinuxSecuritySummit2010 which will be kept updated with all available information on the event. PRO

[ANN] Linux Security Summit 2010 - Announcement and CFP

2010-05-21 Thread James Morris
tySummit2010 which will be kept updated with all available information on the event. PROGRAM COMMITTEE The Linux Security Summit for 2010 is organized by: * James Morris, Red Hat * Serge Hallyn, IBM * Paul Moore, HP * Stephen Smalley, NSA * Joshua Brindle

Re: [CRYPTO] Added CRYPTO_TFM_REQ_MAY_SLEEP flag

2005-08-22 Thread James Morris
nes whether sleeping is allowed. Unlike the earlier version, > the default is to not allow sleeping. This ensures that no existing code > can break. > > As usual, this flag may either be set through crypto_alloc_tfm(), or > just before a specific crypto operation. > > Sign