Re: [PATCH 0/4] Remove PicoXcell

2020-12-13 Thread Jamie Iles
Acked-by: Jamie Iles for the series. Intel EOLd this product now, good idea to remove it. Thanks, Jamie On Thu, Dec 10, 2020 at 02:03:11PM -0600, Rob Herring wrote: > PicoXcell has had nothing but treewide cleanups for at least the last 8 > years and no signs of activity. The most

Re: [PATCH] drivers: crypto: picoxcell_crypto: Fix potential race condition bug

2020-08-13 Thread Jamie Iles
ich updates engine->stat_irq_thresh, > therefore initialize it before creating the file in probe function. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Madhuparna Bhowmik Acked-by: Jamie Iles Thanks!

Re: [PATCH v3 10/13] crypto: picoxcell - permit asynchronous skcipher as fallback

2020-07-06 Thread Jamie Iles
t's fix this, by allocating an ordinary skcipher > as the fallback, and invoke it with the completion routine that was given > to the outer request. > > Signed-off-by: Ard Biesheuvel Thanks Ard! Reviewed-by: Jamie Iles

Re: [PATCH -next 07/12] crypto: picoxcell - use devm_platform_ioremap_resource() to simplify code

2019-08-03 Thread Jamie Iles
On Fri, Aug 02, 2019 at 09:28:04PM +0800, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Acked-by: Jamie Iles > --- > drivers/crypto/p

Re: [PATCH 7/9] crypto: picoxcell - don't leak pointers to authenc keys

2018-03-22 Thread Jamie Iles
On Wed, Mar 21, 2018 at 07:00:55PM +0200, Tudor Ambarus wrote: > Signed-off-by: Tudor Ambarus Reviewed-by: Jamie Iles > --- > drivers/crypto/picoxcell_crypto.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/crypto/picoxcell_crypto.c > b/drivers/cryp

Re: [PATCH] crypto: picoxcell - Fix error handling in spacc_probe()

2018-01-24 Thread Jamie Iles
rification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Reviewed-by: Jamie Iles

Re: [PATCH] drivers/crypto: Convert timers to use timer_setup()

2017-10-26 Thread Jamie Iles
Cc: Jesper Nilsson > Cc: Lars Persson > Cc: Niklas Cassel > Cc: "David S. Miller" > Cc: Jamie Iles > Cc: linux-arm-ker...@axis.com > Cc: linux-crypto@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Signed-off-by: Kees Cook > --- Acked-by: Jamie Iles Thanks, Jamie

Re: [PATCH 0/3] crypto: picoxcell - Cleanups removing non-DT code

2017-01-07 Thread Jamie Iles
crypto: picoxcell - Remove spacc_is_compatible() wrapper function > > drivers/crypto/Kconfig| 2 +- > drivers/crypto/picoxcell_crypto.c | 28 +++- > 2 files changed, 4 insertions(+), 26 deletions(-) Acked-by: Jamie Iles Thanks, Jamie -- To unsub

Re: [PATCH 5/7] crypto: picoxcell: check return value of sg_nents_for_len

2015-11-06 Thread Jamie Iles
orentin Acked-by: Jamie Iles thanks for doing this! Jamie -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] crypto: picoxcell - Clamp AEAD SG list by input length

2015-06-17 Thread Jamie Iles
his is compile-tested only. Looks good, thanks Herbert! Acked-by: Jamie Iles -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] crypto: picoxcell_crypto: Use of_match_ptr() macro

2013-03-15 Thread Jamie Iles
Thanks Sachin! On Thu, Mar 14, 2013 at 03:46:58PM +0530, Sachin Kamat wrote: > This eliminates having an #ifdef returning NULL for the case > when OF is disabled. > > Signed-off-by: Sachin Kamat Acked-by: Jamie Iles -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] crypto: picoxcell: Add terminating entry for platform_device_id table

2012-11-04 Thread Jamie Iles
Hi Axel, On Sun, Nov 04, 2012 at 11:36:25PM +0800, Axel Lin wrote: > The platform_device_id table is supposed to be zero-terminated. > > Signed-off-by: Axel Lin Good spot! Thanks for fixing. Acked-by: Jamie Iles Jamie -- To unsubscribe from this list: send the line "uns

[PATCH] crypto: picoxcell: fix boolean and / or confusion

2011-12-13 Thread Jamie Iles
The AES engine only supports 128 and 256 bit keys so we should correctly test for that. Cc: Herbert Xu Reported-by: Joe Perches Signed-off-by: Jamie Iles --- drivers/crypto/picoxcell_crypto.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto

Re: drivers/crypto/picoxcell_crypto.c: boolean and / or confusion

2011-12-13 Thread Jamie Iles
Hi Joe, On Mon, Dec 12, 2011 at 03:44:53PM -0800, Joe Perches wrote: > On Tue, 2011-12-13 at 00:06 +0100, roel wrote: > > The test not [val1] or not [val2] always evaluates to true > > Hey Jamie and Roel > > Looking at drivers with: > > $ grep -rP --include=*.[ch] > "(\b[\w\[\]\>\._\-]+)\s*\!\

Re: [PATCH] crypto: convert drivers/crypto/* to use module_platform_driver()

2011-11-26 Thread Jamie Iles
apolskiy > Cc: Jamie Iles Acked-by: Jamie Iles Thanks Axel! -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 2/2] crypto: driver for Tegra AES hardware

2011-11-18 Thread Jamie Iles
Hi Varun, Just a couple of nitpicks inline, otherwise looks good to me. Jamie On Fri, Nov 18, 2011 at 11:12:33AM +0530, Varun Wadekar wrote: > driver supports ecb/cbc/ofb/ansi_x9.31rng modes, > 128, 192 and 256-bit key sizes > > Signed-off-by: Varun Wadekar > --- > drivers/crypto/Kconfig

Re: Hardware acceleration indication in af_alg

2011-11-01 Thread Jamie Iles
Hi Nikos, On Tue, Nov 01, 2011 at 01:43:26PM +0100, Nikos Mavrogiannopoulos wrote: > On 10/28/2011 06:24 PM, Nikos Mavrogiannopoulos wrote: > > >>> I can imagine, an alternative approach and perhaps better > >>> approach would be to measure the speed of the kernel provided > >>> algorithm against

[PATCH] crypto: picoxcell: add dependency on HAVE_CLK

2011-09-30 Thread Jamie Iles
The picoxcell crypto driver requires the clk API, but the platform in mainline does not currently support it. Add an explicit dependency on HAVE_CLK to avoid build breakage. Cc: Herbert Xu Signed-off-by: Jamie Iles --- drivers/crypto/Kconfig |2 +- 1 files changed, 1 insertions(+), 1

[PATCH] crypto: picoxcell: fix possible invalid pointer dereference

2011-08-02 Thread Jamie Iles
The completion callback will free the request so we must remove it from the completion list before calling the callback. Cc: Herbert Xu Signed-off-by: Jamie Iles --- drivers/crypto/picoxcell_crypto.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/crypto

[PATCH 3/3] crypto: picoxcell - support for device tree matching

2011-08-01 Thread Jamie Iles
Allow the crypto engines to be matched from device tree bindings. Cc: devicetree-disc...@lists.ozlabs.org Cc: Herbert Xu Signed-off-by: Jamie Iles --- .../devicetree/bindings/crypto/picochip-spacc.txt | 23 drivers/crypto/picoxcell_crypto.c | 36

[PATCH 2/3] crypto: picoxcell - add connection ID to the clock name

2011-08-01 Thread Jamie Iles
For using the device tree probing we use a connection ID for the clk_get() operation. Cc: Herbert Xu Signed-off-by: Jamie Iles --- drivers/crypto/picoxcell_crypto.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/crypto/picoxcell_crypto.c b/drivers/crypto

[PATCH 1/3] crypto: picoxcell - convert to platform ID table

2011-08-01 Thread Jamie Iles
vice names. Cc: Herbert Xu Signed-off-by: Jamie Iles --- drivers/crypto/picoxcell_crypto.c | 93 + 1 files changed, 33 insertions(+), 60 deletions(-) diff --git a/drivers/crypto/picoxcell_crypto.c b/drivers/crypto/picoxcell_crypto.c index 230b5b8..4ffb903 10064

[PATCH] crypto: picoxcell: fix possible invalid pointer dereference

2011-06-06 Thread Jamie Iles
The completion callback will free the request so we must remove it from the completion list before calling the callback. Cc: sta...@kernel.org Cc: Herbert Xu Signed-off-by: Jamie Iles --- drivers/crypto/picoxcell_crypto.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH] picoxcell-crypto: fix possible status FIFO overflow

2011-03-23 Thread Jamie Iles
popped from the status FIFO does not exceed the size of a single FIFO. Signed-off-by: Jamie Iles --- drivers/crypto/picoxcell_crypto.c | 64 - 1 files changed, 35 insertions(+), 29 deletions(-) diff --git a/drivers/crypto/picoxcell_crypto.c b/drivers/crypto/pic

Re: [PATCH] picoxcell_crypto: add support for the picoxcell crypto engines

2011-02-11 Thread Jamie Iles
On Thu, Feb 10, 2011 at 10:09:16PM -0600, Kim Phillips wrote: > On Tue, 8 Feb 2011 15:56:16 + > Jamie Iles wrote: > > > Picochip picoXcell devices have two crypto engines, one targeted > > at IPSEC offload and the other at WCDMA layer 2 ciphering. > > > >

Re: [PATCH 01/16] crypto: omap-aes: don't treat NULL clk as an error

2011-01-12 Thread Jamie Iles
Jamie 8<--- >From 75cef47f02ea19b94203f287eaaddc644c51ce30 Mon Sep 17 00:00:00 2001 From: Jamie Iles Date: Tue, 11 Jan 2011 09:48:26 + Subject: [PATCH] crypto: omap-aes: don't treat NULL clk as an error clk_get() returns a struct clk cookie to the driver and some platforms

[PATCH 01/16] crypto: omap-aes: don't treat NULL clk as an error

2011-01-11 Thread Jamie Iles
clk_get() returns a struct clk cookie to the driver and some platforms may return NULL if they only support a single clock. clk_get() has only failed if it returns a ERR_PTR() encoded pointer. Cc: Dmitry Kasatkin Cc: linux-crypto@vger.kernel.org Signed-off-by: Jamie Iles --- drivers/crypto

[PATCH 02/16] crypto: omap-sham: don't treat NULL clk as an error

2011-01-11 Thread Jamie Iles
clk_get() returns a struct clk cookie to the driver and some platforms may return NULL if they only support a single clock. clk_get() has only failed if it returns a ERR_PTR() encoded pointer. Cc: Dmitry Kasatkin Cc: linux-crypto@vger.kernel.org Signed-off-by: Jamie Iles --- drivers/crypto

Re: IPSec AH hardware offload

2009-01-28 Thread Jamie Iles
Herbert Xu wrote: Once that's completed we can then convert IPsec (or rather, authenc) over to using ahash. Does that include the hash for authentication header in net/ipv[46]/ah[46].c? The driver implements authenc algorithms, so we'll already get asynchronous operation for ESP, but the cryp

IPSec AH hardware offload

2009-01-20 Thread Jamie Iles
Hi, I'm currently developing a driver for a hardware crypto offload engine that is capable of offloading both ESP and AH in IPSec. I've noticed that none of the crypto drivers in 2.6.28 do offload for ahash and that the netkey AH implementation both use synchronous hashes. Are the synchronous soft