Re: [PATCH 7/9] crypto: picoxcell - don't leak pointers to authenc keys

On Wed, Mar 21, 2018 at 07:00:55PM +0200, Tudor Ambarus wrote: > Signed-off-by: Tudor Ambarus <tudor.amba...@microchip.com> Reviewed-by: Jamie Iles <ja...@jamieiles.com> > --- > drivers/crypto/picoxcell_crypto.c | 2 ++ > 1 file changed, 2 insertions(+) > &g

Re: [PATCH] crypto: picoxcell - Fix error handling in spacc_probe()

rification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> Reviewed-by: Jamie Iles <ja...@jamieiles.com>

Re: [PATCH] drivers/crypto: Convert timers to use timer_setup()

erbert Xu <herb...@gondor.apana.org.au> > Cc: Jesper Nilsson <jesper.nils...@axis.com> > Cc: Lars Persson <lars.pers...@axis.com> > Cc: Niklas Cassel <niklas.cas...@axis.com> > Cc: "David S. Miller" <da...@davemloft.net> > Cc: Jamie Iles <ja...@jamieiles.com

Re: [PATCH 0/3] crypto: picoxcell - Cleanups removing non-DT code

Remove spacc_is_compatible() wrapper function > > drivers/crypto/Kconfig| 2 +- > drivers/crypto/picoxcell_crypto.c | 28 +++----- > 2 files changed, 4 insertions(+), 26 deletions(-) Acked-by: Jamie Iles <ja...@jamieiles.com> Thanks, Jamie --

Re: [PATCH 5/7] crypto: picoxcell: check return value of sg_nents_for_len

ntin <clabbe.montj...@gmail.com> Acked-by: Jamie Iles <ja...@jamieiles.com> thanks for doing this! Jamie -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] crypto: picoxcell - Clamp AEAD SG list by input length

. Looks good, thanks Herbert! Acked-by: Jamie Iles ja...@jamieiles.com -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] crypto: picoxcell_crypto: Use of_match_ptr() macro

Thanks Sachin! On Thu, Mar 14, 2013 at 03:46:58PM +0530, Sachin Kamat wrote: This eliminates having an #ifdef returning NULL for the case when OF is disabled. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Jamie Iles ja...@jamieiles.com -- To unsubscribe from this list: send

Re: [PATCH] crypto: picoxcell: Add terminating entry for platform_device_id table

Hi Axel, On Sun, Nov 04, 2012 at 11:36:25PM +0800, Axel Lin wrote: The platform_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin axel@ingics.com Good spot! Thanks for fixing. Acked-by: Jamie Iles ja...@jamieiles.com Jamie -- To unsubscribe from this list

Re: drivers/crypto/picoxcell_crypto.c: boolean and / or confusion

Hi Joe, On Mon, Dec 12, 2011 at 03:44:53PM -0800, Joe Perches wrote: On Tue, 2011-12-13 at 00:06 +0100, roel wrote: The test not [val1] or not [val2] always evaluates to true Hey Jamie and Roel Looking at drivers with: $ grep -rP --include=*.[ch]

Re: [PATCH] crypto: convert drivers/crypto/* to use module_platform_driver()

: Vladimir Zapolskiy vzapols...@gmail.com Cc: Jamie Iles ja...@jamieiles.com Acked-by: Jamie Iles ja...@jamieiles.com Thanks Axel! -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v7 2/2] crypto: driver for Tegra AES hardware

Hi Varun, Just a couple of nitpicks inline, otherwise looks good to me. Jamie On Fri, Nov 18, 2011 at 11:12:33AM +0530, Varun Wadekar wrote: driver supports ecb/cbc/ofb/ansi_x9.31rng modes, 128, 192 and 256-bit key sizes Signed-off-by: Varun Wadekar vwade...@nvidia.com ---

Re: Hardware acceleration indication in af_alg

Hi Nikos, On Tue, Nov 01, 2011 at 01:43:26PM +0100, Nikos Mavrogiannopoulos wrote: On 10/28/2011 06:24 PM, Nikos Mavrogiannopoulos wrote: I can imagine, an alternative approach and perhaps better approach would be to measure the speed of the kernel provided algorithm against a software

[PATCH] crypto: picoxcell: add dependency on HAVE_CLK

The picoxcell crypto driver requires the clk API, but the platform in mainline does not currently support it. Add an explicit dependency on HAVE_CLK to avoid build breakage. Cc: Herbert Xu herb...@gondor.apana.org.au Signed-off-by: Jamie Iles ja...@jamieiles.com --- drivers/crypto/Kconfig

[PATCH] crypto: picoxcell: fix possible invalid pointer dereference

The completion callback will free the request so we must remove it from the completion list before calling the callback. Cc: Herbert Xu herb...@gondor.apana.org.au Signed-off-by: Jamie Iles ja...@jamieiles.com --- drivers/crypto/picoxcell_crypto.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 1/3] crypto: picoxcell - convert to platform ID table

: Herbert Xu herb...@gondor.apana.org.au Signed-off-by: Jamie Iles ja...@jamieiles.com --- drivers/crypto/picoxcell_crypto.c | 93 + 1 files changed, 33 insertions(+), 60 deletions(-) diff --git a/drivers/crypto/picoxcell_crypto.c b/drivers/crypto/picoxcell_crypto.c

[PATCH 2/3] crypto: picoxcell - add connection ID to the clock name

For using the device tree probing we use a connection ID for the clk_get() operation. Cc: Herbert Xu herb...@gondor.apana.org.au Signed-off-by: Jamie Iles ja...@jamieiles.com --- drivers/crypto/picoxcell_crypto.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers

[PATCH 3/3] crypto: picoxcell - support for device tree matching

Allow the crypto engines to be matched from device tree bindings. Cc: devicetree-disc...@lists.ozlabs.org Cc: Herbert Xu herb...@gondor.apana.org.au Signed-off-by: Jamie Iles ja...@jamieiles.com --- .../devicetree/bindings/crypto/picochip-spacc.txt | 23 drivers/crypto

[PATCH] crypto: picoxcell: fix possible invalid pointer dereference

The completion callback will free the request so we must remove it from the completion list before calling the callback. Cc: sta...@kernel.org Cc: Herbert Xu herb...@gondor.apana.org.au Signed-off-by: Jamie Iles ja...@jamieiles.com --- drivers/crypto/picoxcell_crypto.c |2 +- 1 files changed

[PATCH] picoxcell-crypto: fix possible status FIFO overflow

the status FIFO does not exceed the size of a single FIFO. Signed-off-by: Jamie Iles ja...@jamieiles.com --- drivers/crypto/picoxcell_crypto.c | 64 - 1 files changed, 35 insertions(+), 29 deletions(-) diff --git a/drivers/crypto/picoxcell_crypto.c b/drivers/crypto

Re: [PATCH] picoxcell_crypto: add support for the picoxcell crypto engines

On Thu, Feb 10, 2011 at 10:09:16PM -0600, Kim Phillips wrote: On Tue, 8 Feb 2011 15:56:16 + Jamie Iles ja...@jamieiles.com wrote: Picochip picoXcell devices have two crypto engines, one targeted at IPSEC offload and the other at WCDMA layer 2 ciphering. Cc: Herbert Xu herb

Re: [PATCH 01/16] crypto: omap-aes: don't treat NULL clk as an error

--- From 75cef47f02ea19b94203f287eaaddc644c51ce30 Mon Sep 17 00:00:00 2001 From: Jamie Iles ja...@jamieiles.com Date: Tue, 11 Jan 2011 09:48:26 + Subject: [PATCH] crypto: omap-aes: don't treat NULL clk as an error clk_get() returns a struct clk cookie to the driver and some platforms may

[PATCH 02/16] crypto: omap-sham: don't treat NULL clk as an error

clk_get() returns a struct clk cookie to the driver and some platforms may return NULL if they only support a single clock. clk_get() has only failed if it returns a ERR_PTR() encoded pointer. Cc: Dmitry Kasatkin dmitry.kasat...@nokia.com Cc: linux-crypto@vger.kernel.org Signed-off-by: Jamie

Re: IPSec AH hardware offload

Herbert Xu wrote: Once that's completed we can then convert IPsec (or rather, authenc) over to using ahash. Does that include the hash for authentication header in net/ipv[46]/ah[46].c? The driver implements authenc algorithms, so we'll already get asynchronous operation for ESP, but the

IPSec AH hardware offload

Hi, I'm currently developing a driver for a hardware crypto offload engine that is capable of offloading both ESP and AH in IPSec. I've noticed that none of the crypto drivers in 2.6.28 do offload for ahash and that the netkey AH implementation both use synchronous hashes. Are the synchronous