Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-03 Thread Josh Cartwright
Hey Stanimir- Just a few comments/questions from a quick scan of your patchset: On Thu, Apr 03, 2014 at 07:17:58PM +0300, Stanimir Varbanov wrote: [..] > +++ b/drivers/crypto/qce/core.c [..] > + > +static struct qce_algo_ops qce_ops[] = { > + { > + .type = CRYPTO_ALG_TYPE_ABLKCIPH

Re: [PATCH 3/9] crypto: qce: Add dma and sg helpers

2014-04-03 Thread Josh Cartwright
Nitworthy comments :). On Thu, Apr 03, 2014 at 07:18:00PM +0300, Stanimir Varbanov wrote: [..] > +++ b/drivers/crypto/qce/dma.c [..] > +int qce_dma_request(struct device *dev, struct qce_dma_data *dma) > +{ > + unsigned int memsize; > + void *va; > + int ret; > + > + dma->txchan =