Re: orinoco: Use shash instead of ahash for MIC calculations

2016-12-30 Thread Kalle Valo
Kalle Valo <kv...@codeaurora.org> writes: > Kalle Valo <kv...@codeaurora.org> writes: > >> Andrew Lutomirski <l...@kernel.org> wrote: >>> Eric Biggers pointed out that the orinoco driver pointed scatterlists >>> at the stack. >>> >&g

Re: orinoco: Use shash instead of ahash for MIC calculations

2016-12-30 Thread Kalle Valo
Kalle Valo <kv...@codeaurora.org> writes: > Andrew Lutomirski <l...@kernel.org> wrote: >> Eric Biggers pointed out that the orinoco driver pointed scatterlists >> at the stack. >> >> Fix it by switching from ahash to shash. The result should be >>

Re: orinoco: Use shash instead of ahash for MIC calculations

2016-12-30 Thread Kalle Valo
Andrew Lutomirski wrote: > Eric Biggers pointed out that the orinoco driver pointed scatterlists > at the stack. > > Fix it by switching from ahash to shash. The result should be > simpler, faster, and more correct. > > Cc: sta...@vger.kernel.org # 4.9 only > Reported-by: Eric

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-13 Thread Kalle Valo
Andy Lutomirski <l...@amacapital.net> writes: > On Tue, Dec 13, 2016 at 3:35 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> Andy Lutomirski <l...@kernel.org> writes: >> >>> Eric Biggers pointed out that the orinoco driver pointed scatterlists >>

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-13 Thread Kalle Valo
I'm just wondering should I push this to 4.10 or -next. This is a driver for ancient hardware so I'm starting to lean for -next. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2/2] ath9k: disable RNG by default

2016-09-28 Thread Kalle Valo
miaoqing pan wrote: > From: Miaoqing Pan > > ath9k RNG will dominates all the noise sources from the real HW > RNG, disable it by default. But we strongly recommand to enable > it if the system without HW RNG, especially on embedded systems. >

Re: [1/2] ath9k: change entropy formula for easier understanding

2016-09-27 Thread Kalle Valo
miaoqing pan wrote: > From: Miaoqing Pan > > The quality of ADC entropy is 10 bits of min-entropy for > a 32-bit value, change '(((x) * 8 * 320) >> 10)' to > '(((x) * 8 * 10) >> 5)' for easier understanding. > > Signed-off-by: Miaoqing Pan

Re: [v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-09-27 Thread Kalle Valo
Stephan Mueller wrote: > The ATH9K driver implements an RNG which is completely bypassing the > standard Linux HW generator logic. > > The RNG may or may not deliver entropy. Considering the conservative > approach in treating entropy with respect to non-auditable sources,

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-15 Thread Kalle Valo
Please don't top post, it breaks patchwork which is extremely annoying for me: https://patchwork.kernel.org/patch/9266265/ https://patchwork.kernel.org/patch/9266617/ -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to m

Re: [PATCH 2/2] ath9k: export HW random number generator

2015-11-25 Thread Kalle Valo
ert my patch also (I was about to > submit a request for reverting it and writing something similar when > this thread came up). Could you submit the revert as a patch and with the explonation in the commit log, please? -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH 2/2] ath9k: export HW random number generator

2015-07-31 Thread Kalle Valo
with the hwrandom framework. Based on the discussion I'm going to revert this patch, at least for now. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org