Re: [v3] crypto: ctr - avoid VLA use

2018-04-03 Thread Laura Abbott
On 03/30/2018 01:53 AM, Salvatore Mesoraca wrote: All ciphers implemented in Linux have a block size less than or equal to 16 bytes and the most demanding hw require 16 bytes alignment for the block buffer. We avoid 2 VLAs[1] by always allocating 16 bytes with 16 bytes alignment, unless the

KASAN errors after 21c8e72037fb ("crypto: testmgr - use calculated count for number of test vectors")

2017-02-28 Thread Laura Abbott
Hi, While attempting to debug something else, I saw KASAN errors from the crypto test with ccm: [ 28.231615] == [ 28.232007] BUG: KASAN: global-out-of-bounds in __test_aead+0x9d9/0x2200 at addr 8212fca0 [ 28.232007]

[PATCHv2] crypto: testmgr: Use heap buffer for acomp test input

2016-12-21 Thread Laura Abbott
this by copying the input vectors to heap buffer before setting up the scatterlist. Reported-by: Christopher Covington <c...@codeaurora.org> Fixes: d7db7a882deb ("crypto: acomp - update testmgr with support for acomp") Signed-off-by: Laura Abbott <labb...@redhat.com> ---

[PATCH] crypto: testmgr: Use linear alias for test input

2016-12-19 Thread Laura Abbott
. The kernel image is also aliased to the linear map so get the linear alias and pass that to the scatterlist instead. Reported-by: Christopher Covington <c...@codeaurora.org> Fixes: d7db7a882deb ("crypto: acomp - update testmgr with support for acomp") Signed-off-by: Laura Abbott <

Re: BUG: algif_hash crash with extra recv() in 4.9-rc5

2016-11-17 Thread Laura Abbott
On 11/17/2016 06:07 AM, Herbert Xu wrote: > On Wed, Nov 16, 2016 at 11:17:33AM -0800, Mat Martineau wrote: >> >> Herbert - >> >> Following commit 493b2ed3f7603a15ff738553384d5a4510ffeb95, there is a NULL >> dereference crash in algif_hash when recv() is called twice like this: >> >> send(sk, data,

[REGRESSION] 493b2ed3f760 ("crypto: algif_hash - Handle NULL hashes correctly")

2016-11-16 Thread Laura Abbott
Hi, Fedora got a bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1395896 of an oops with this program: #include #include #include int main(int argc, char *argv[]) { static const union { struct sockaddr sa; struct sockaddr_alg alg; } sa = {