[PATCH v2][RESEND] X.509: unpack RSA signatureValue field from BIT STRING

is a problem for RSA implementations that need it to be exactly correct (like AMD CCP). Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Fixes: c26fd69fa009 ("X.509: Add a crypto key parser for binary (DER) X.509 certificates") Cc: sta...@vger.kernel.org --- This is a r

Re: [PATCH v2] X.509: unpack RSA signatureValue field from BIT STRING

On 17.04.2018 17:07, Kamil Konieczny wrote: > > > On 17.04.2018 15:39, Maciej S. Szmigiero wrote: >> The signatureValue field of a X.509 certificate is encoded as a BIT STRING. >> For RSA signatures this BIT STRING is of so-called primitive subtype, which >> cont

[PATCH v2] X.509: unpack RSA signatureValue field from BIT STRING

is a problem for RSA implementations that need it to be exactly correct (like AMD CCP). Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Fixes: c26fd69fa009 ("X.509: Add a crypto key parser for binary (DER) X.509 certificates") Cc: sta...@vger.kernel.org --- This is a r

Re: [PATCH] X.509: unpack RSA signatureValue field from BIT STRING

On 07.03.2018 18:56, Maciej S. Szmigiero wrote: > On 07.03.2018 16:44, David Howells wrote: >> Maciej S. Szmigiero <m...@maciej.szmigiero.name> wrote: >> >>> + if (!strcmp(ctx->cert->sig->pkey_algo, "rsa")) { >> >> I'm going to chang

Re: [PATCH] crypto/ccp: Validate buffer lengths for copy operations

On 07.03.2018 18:31, Gary R Hook wrote: > The CCP driver copies data between scatter/gather lists and DMA buffers. > The length of the requested copy operation must be checked against > the available destination buffer length. > > Reported-by: Maciej S. Szmigiero <m...@mac

Re: [PATCH] X.509: unpack RSA signatureValue field from BIT STRING

On 07.03.2018 16:44, David Howells wrote: > Maciej S. Szmigiero <m...@maciej.szmigiero.name> wrote: > >> +if (!strcmp(ctx->cert->sig->pkey_algo, "rsa")) { > > I'm going to change this to '== 0' rather than '!'. No problem. > David > Thanks, Maciej

[PATCH] X.509: unpack RSA signatureValue field from BIT STRING

is a problem for RSA implementations that need it to be exactly correct (like AMD CCP). Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Fixes: c26fd69fa009 ("X.509: Add a crypto key parser for binary (DER) X.509 certificates") Cc: sta...@vger.kernel.org --- This is a resend

Re: [PATCH 2/3] crypto: ccp - return an actual key size from RSA max_size callback

On 03.03.2018 00:49, Hook, Gary wrote: > On 3/2/2018 5:15 PM, Maciej S. Szmigiero wrote: >> On 02.03.2018 17:44, Herbert Xu wrote: >>> On Sat, Feb 24, 2018 at 05:03:21PM +0100, Maciej S. Szmigiero wrote: >>>> rsa-pkcs1pad uses a value returned from a RSA impleme

Re: [PATCH 2/3] crypto: ccp - return an actual key size from RSA max_size callback

On 02.03.2018 17:44, Herbert Xu wrote: > On Sat, Feb 24, 2018 at 05:03:21PM +0100, Maciej S. Szmigiero wrote: >> rsa-pkcs1pad uses a value returned from a RSA implementation max_size >> callback as a size of an input buffer passed to the RSA implementation for >> encryp

[PATCH 2/3] crypto: ccp - return an actual key size from RSA max_size callback

to CCP even for smaller key sizes and then in a buffer overflow when ccp_run_rsa_cmd() tried to copy this large input buffer into a RSA key length-sized hardware input buffer. Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Fixes: ceeec0afd684 ("crypto: ccp - Add supp

[PATCH 3/3] crypto: ccp - protect RSA implementation from too large input data

has been a case when this has happened let's better reject such oversized input data and log an error message in this case so we know what is going on. Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> --- drivers/crypto/ccp/ccp-ops.c | 24 1 file chang

[PATCH 1/3] X.509: unpack RSA signatureValue field from BIT STRING

is a problem for RSA implementations that need it to be exactly correct (like AMD CCP). Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Fixes: c26fd69fa009 ("X.509: Add a crypto key parser for binary (DER) X.509 certificates") Cc: sta...@vger.kernel.org --- crypto