Re: [PATCH v2 0/3] dmaengine: Add supports for APM X-Gene SoC CRC32C accerlerator driver

On Wed, Dec 9, 2015 at 1:57 PM, Herbert Xu <herb...@gondor.apana.org.au> wrote: > On Wed, Dec 09, 2015 at 01:55:55PM +0530, Rameshwar Sahu wrote: >> >> Any comments on above patch ?? > > My concern that there aren't going to be any in-kernel users remains. Yes, we are n

Re: [PATCH v2 0/3] dmaengine: Add supports for APM X-Gene SoC CRC32C accerlerator driver

Hi, On Mon, Nov 16, 2015 at 2:42 PM, wrote: > From: Rameshwar Prasad Sahu > > This patch implements support for APM X-Gene SoC CRC32C h/w accelerator driver > and adds CRC32C computations support in dmaengine framework. APM X-Gene SoC > has > DMA engine capable

Re: [PATCH v2 0/3] dmaengine: Add supports for APM X-Gene SoC CRC32C accerlerator driver

Hi Herbert, On Mon, Nov 30, 2015 at 2:20 PM, Herbert Xu <herb...@gondor.apana.org.au> wrote: > On Mon, Nov 30, 2015 at 02:19:33PM +0530, Rameshwar Sahu wrote: >> >> One of our client is using this layer for offloading the crc32c to our >> dmaengine hw. >

Re: [PATCH v2 0/3] dmaengine: Add supports for APM X-Gene SoC CRC32C accerlerator driver

On Mon, Nov 16, 2015 at 2:42 PM, wrote: > From: Rameshwar Prasad Sahu > > This patch implements support for APM X-Gene SoC CRC32C h/w accelerator driver > and adds CRC32C computations support in dmaengine framework. APM X-Gene SoC > has > DMA engine capable of

Re: [PATCH v2 0/3] dmaengine: Add supports for APM X-Gene SoC CRC32C accerlerator driver

Hi Herbert, On Mon, Nov 30, 2015 at 2:09 PM, Herbert Xu <herb...@gondor.apana.org.au> wrote: > On Mon, Nov 30, 2015 at 02:06:03PM +0530, Rameshwar Sahu wrote: >> On Mon, Nov 16, 2015 at 2:42 PM, <rs...@apm.com> wrote: >> > From: Rameshwar Prasad Sahu <rs

Re: [PATCH v1 1/4] dmaengine: Add support for new feature CRC32C

On Thu, Aug 20, 2015 at 12:38 PM, Vinod Koul vinod.k...@intel.com wrote: On Thu, Aug 20, 2015 at 11:59:07AM +0530, Rameshwar Sahu wrote: Hi Vinod, On Thu, Aug 20, 2015 at 10:56 AM, Vinod Koul vinod.k...@intel.com wrote: On Thu, Jul 30, 2015 at 05:41:05PM +0530, Rameshwar Prasad Sahu wrote

Re: [PATCH v1 1/4] dmaengine: Add support for new feature CRC32C

Hi Vinod, On Thu, Aug 20, 2015 at 10:56 AM, Vinod Koul vinod.k...@intel.com wrote: On Thu, Jul 30, 2015 at 05:41:05PM +0530, Rameshwar Prasad Sahu wrote: This patch adds support for new feature CRC32C calculation in dmaengine framework. Looks okay can you please update Documentation also

Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver

Hi Vinod, On Thu, Aug 20, 2015 at 11:18 AM, Vinod Koul vinod.k...@intel.com wrote: On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote: + nents = sg_nents(req-src); + sg_count = dma_map_sg(dev, req-src, nents, DMA_TO_DEVICE); + if (!sg_count) { +

Re: [PATCH v1 2/4] dmaengine: xgene-dma: Add support for CRC32C calculation via DMA engine

Hi Vinod, On Thu, Aug 20, 2015 at 11:10 AM, Vinod Koul vinod.k...@intel.com wrote: On Thu, Jul 30, 2015 at 05:41:06PM +0530, Rameshwar Prasad Sahu wrote: + /* Invalidate unused source address field */ + for (; i 4; i++) +

Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver

On Fri, Jul 31, 2015 at 12:43 PM, Herbert Xu herb...@gondor.apana.org.au wrote: On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote: + .cra_name = xgene(crc32c), + .cra_driver_name= crc32c-xgene, This looks wrong. If you're

Re: [PATCH v1 0/4] Crypto: tcrypt: Add test case for APM X-Gene SoC CRC32C algo

Hi All, On Thu, Jul 30, 2015 at 5:41 PM, Rameshwar Prasad Sahu rs...@apm.com wrote: This patch adds test case for APM X-Gene SoC CRC32C algorithm. Please discard this patch description and subject line in this cover letter, I have resent it again. Thanks, Ram Signed-off-by: Rameshwar Prasad