Hi YueHaibing,
Please add below fixes tag in the commit message,
Fixes: 9d12ba86f818 ("crypto: brcm - Add Broadcom SPU driver")
Otherwise patch looks good to me.
-Raveendra
On Fri, Dec 28, 2018 at 9:07 AM YueHaibing wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/crypto/b
Remove setkey() callback handler for normal/non key
hash algorithms and keep it for AES-CBC/CMAC which needs key.
Signed-off-by: Raveendra Padasalagi
---
drivers/crypto/bcm/cipher.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/bcm/cipher.c b/drivers
Hi Stefan,
The change looks to be fine. From the IP point of view its using the
same values in case of AES cipher and hash types so explicit casting
should be ok.
-Raveendra
On Sat, Mar 24, 2018 at 4:32 PM, Stefan Agner wrote:
> In the AES cases enum spu_cipher_type and enum hash_type have
> t
quot;)
Signed-off-by: Raveendra Padasalagi
Reviewed-by: Anup Patel
Reviewed-by: Scott Branden
Cc: sta...@vger.kernel.org
diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c
index 9cfd36c..45440ac 100644
--- a/drivers/crypto/bcm/cipher.c
+++ b/drivers/crypto/bcm/cipher.c
@@ -258
m SPU driver")
Signed-off-by: Raveendra Padasalagi
Reviewed-by: Scott Branden
Reviewed-by: Florian Fainelli
Cc: sta...@vger.kernel.org
---
Changes in v1:
- Added error path to clean up mbox channel in spu_mb_init() in case
mbox channel request fails.
- Removed spu_reg_vbase[] an
Need to address few issues in the patch.
So NAKing this patch. Will send out re-vised version.
Regards,
Raveendra
> -Original Message-
> From: Raveendra Padasalagi [mailto:raveendra.padasal...@broadcom.com]
> Sent: 13 July 2017 13:58
> To: Herbert Xu; David S. Miller; Rob
m SPU driver")
Signed-off-by: Raveendra Padasalagi
cc: sta...@vger.kernel.org
---
drivers/crypto/bcm/cipher.c | 105 +---
drivers/crypto/bcm/cipher.h | 15 ---
2 files changed, 57 insertions(+), 63 deletions(-)
diff --git a/drivers/crypto/bcm/
iver")
Signed-off-by: Raveendra Padasalagi
Reviewed-by: Ray Jui
Reviewed-by: Scott Branden
Cc: sta...@vger.kernel.org
---
drivers/crypto/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index fb1e60f..778fc1b 100644
--- a/dri
Need to consider some more scenarios.
So NAKing this patch. Will send out re-vised version.
Regards,
Raveendra
On Fri, Jun 23, 2017 at 2:24 PM, Raveendra Padasalagi
wrote:
> Zero length payload requests are not handled in
> Broadcom SPU2 engine, so this patch adds conditional
>
ned-off-by: Raveendra Padasalagi
Reviewed-by: Ray Jui
Reviewed-by: Scott Branden
Cc: sta...@vger.kernel.org
---
Changes in v1:
- Added Cc and fixes tag in the Signed-off area to send the patch
to stable kernel
drivers/crypto/bcm/spu2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/driv
Zero length payload requests are not handled in
Broadcom SPU2 engine, so this patch adds conditional
check to fallback to software implementation for AES-GCM
and AES-CCM algorithms.
Fixes: 9d12ba86f818 ("crypto: brcm - Add Broadcom SPU driver")
Signed-off-by: Raveendra Padasalagi
R
Zero length payload requests are not handled in
Broadcom SPU2 engine, so this patch adds conditional
check to fallback to software implementation for AES-GCM
and AES-CCM algorithms.
Signed-off-by: Raveendra Padasalagi
Reviewed-by: Ray Jui
Reviewed-by: Scott Branden
---
drivers/crypto/bcm
In Broadcom SPU driver, due to missing break statement
in spu2_hash_xlate() while mapping SPU2 equivalent
SHA3-512 value, -EINVAL is chosen and hence leading to
failure of SHA3-512 algorithm. This patch fixes the same.
Signed-off-by: Raveendra Padasalagi
Reviewed-by: Ray Jui
Reviewed-by: Scott
This patch adds HMAC-SHA3 test modes in tcrypt module
and related test vectors.
Signed-off-by: Raveendra Padasalagi
---
crypto/tcrypt.c | 16 +++
crypto/testmgr.c | 40 ++
crypto/testmgr.h | 388 +++
3 files changed, 444 insertions
++ Stephan Mueller
Regards,
Raveendra
> -Original Message-
> From: Raveendra Padasalagi [mailto:raveendra.padasal...@broadcom.com]
> Sent: 17 June 2016 10:31
> To: Herbert Xu; David S. Miller; linux-crypto@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Cc: Jon Mason
Added support for SHA-3 algorithm test's
in tcrypt module and related test vectors.
Signed-off-by: Raveendra Padasalagi
---
crypto/tcrypt.c | 53 ++-
crypto/testmgr.c | 40 ++
crypto/testmgr.h
igned-off-by: Raveendra Padasalagi
---
crypto/Kconfig| 10 ++
crypto/Makefile | 1 +
crypto/sha3_generic.c | 300 ++
include/crypto/sha3.h | 29 +
4 files changed, 340 insertions(+)
create mode 100644 crypto/sha3_generic.c
c
below cra_driver_name's
sha3-224-generic
sha3-256-generic
sha3-384-generic
sha3-512-generic
Jeff Garzik (1):
Crypto: Add SHA-3 hash algorithm
Raveendra Padasalagi (1):
Crypto: Add SHA-3 Test's in tcrypt
crypto/Kconfig| 10 ++
crypto/Makefile | 1 +
crypto/sha3_
for software
implementation,
as hardware implementation can use non zero value if it needs higher priority.
What's your opinion ?
Regards,
Raveendra
On Thu, Jun 16, 2016 at 9:10 PM, Stephan Mueller wrote:
> Am Donnerstag, 16. Juni 2016, 14:44:57 schrieb Raveendra Padasalagi:
>
Hi Stephan,
Thanks for the review comments. I will address it in the next patch.
Please look at my reply below against each comment.
Regards,
Raveendra
On Wed, Jun 15, 2016 at 5:12 PM, Stephan Mueller wrote:
> Am Mittwoch, 15. Juni 2016, 15:11:58 schrieb Raveendra Padasalagi:
>
> Hi
The patch set can be fetched from iproc-sha3-v1 branch of
https://github.com/Broadcom/arm64-linux.git
Regards,
Raveendra
> -Original Message-
> From: Raveendra Padasalagi [mailto:raveendra.padasal...@broadcom.com]
> Sent: 15 June 2016 15:20
> To: 'Herbert Xu'; &#x
Forgot to add Jeff Garzik in the email list.
++ Jeff Garzik.
Regards,
Raveendra
> -Original Message-
> From: Raveendra Padasalagi [mailto:raveendra.padasal...@broadcom.com]
> Sent: 15 June 2016 15:12
> To: Herbert Xu; David S. Miller; linux-crypto@vger.kernel.org;
Forgot to add Jeff Garzik in the email list.
++ Jeff Garzik.
Regards,
Raveendra
> -Original Message-
> From: Raveendra Padasalagi [mailto:raveendra.padasal...@broadcom.com]
> Sent: 15 June 2016 15:12
> To: Herbert Xu; David S. Miller; linux-crypto@vger.kernel.org;
Added support for SHA-3 algorithm test's
in tcrypt module and related test vectors.
Signed-off-by: Raveendra Padasalagi
---
crypto/tcrypt.c | 53 ++-
crypto/testmgr.c | 40 ++
crypto/testmgr.h
ework in place.
The patchset is based on v4.7-rc1 tag and its tested on
Broadcom NorthStar2 SoC.
Jeff Garzik (1):
Crypto: Add SHA-3 hash algorithm
Raveendra Padasalagi (1):
Crypto: Add SHA-3 Test's in tcrypt
crypto/Kconfig| 10 ++
crypto/Makefile | 1 +
crypto/sha3_gener
igned-off-by: Raveendra Padasalagi
---
crypto/Kconfig| 10 ++
crypto/Makefile | 1 +
crypto/sha3_generic.c | 296 ++
include/crypto/sha3.h | 29 +
4 files changed, 336 insertions(+)
create mode 100644 crypto/sha3_generic.c
c
26 matches
Mail list logo
