Re: [PATCH v2 0/3] add support of hardware random generator on MediaTek MT7622

2017-06-20 Thread Sean Wang
On Tue, 2017-06-20 at 16:59 +0200, Torsten Duwe wrote: > On Tue, Jun 20, 2017 at 10:21:17PM +0800, Sean Wang wrote: > > Hi Herbert, > > > > thanks for effort reviewing on those patches. > > > > By the way, also loop in Torsten > > > > Could you

Re: [PATCH v2 0/3] add support of hardware random generator on MediaTek MT7622

2017-06-20 Thread Sean Wang
1:56:53PM +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang <sean.w...@mediatek.com> > > > > Changes since v1: > > - update the bindings with the specific "mediatek,mt7622-rng" > > instead of the generic one as "mediatek,generic-rng" &

Re: [PATCH 1/4] dt-bindings: rng: add generic bindings for MediaTek SoCs

2017-06-07 Thread Sean Wang
On Wed, 2017-06-07 at 15:25 +0200, Matthias Brugger wrote: > > On 07/06/17 15:20, Sean Wang wrote: > > On Tue, 2017-06-06 at 13:07 +0200, Matthias Brugger wrote: > >> > >> On 31/05/17 20:44, sean.w...@mediatek.com wrote: > >>> From: Sean Wang <sean.w

Re: [PATCH 1/4] dt-bindings: rng: add generic bindings for MediaTek SoCs

2017-06-07 Thread Sean Wang
On Tue, 2017-06-06 at 13:07 +0200, Matthias Brugger wrote: > > On 31/05/17 20:44, sean.w...@mediatek.com wrote: > > From: Sean Wang <sean.w...@mediatek.com> > > > > Add the generic binding for allowing the support of RNG on MediaTek SoCs > > such as MT762

Re: [PATCH 2/2] hwrng: mtk: Add driver for hardware random generator on MT7623 SoC

2017-04-13 Thread Sean Wang
Hi PrasannaKumar, Add my comments inline On Thu, 2017-04-13 at 14:09 +0530, PrasannaKumar Muralidharan wrote: > Hi Sean, > > Mostly looks good, have few minor comments. > > On 13 April 2017 at 12:35, wrote: > > +static bool mtk_rng_wait_ready(struct hwrng *rng, bool

Re: [PATCH 2/2] hwrng: mtk: Add driver for hardware random generator on MT7623 SoC

2017-04-13 Thread Sean Wang
iatek.com wrote: > > From: Sean Wang <sean.w...@mediatek.com> > > > > This patch adds support for hardware random generator on MT7623 SoC > > and should also work on other similar Mediatek SoCs. Currently, > > the driver is already tested successfully with r