Re: [Patch v2 4/6] drivers: crypto: qce: Fix SHA result buffer corruption issues.

2020-11-24 Thread Stephen Boyd
Quoting Thara Gopinath (2020-11-19 07:52:31) > Partial hash was being copied into the final result buffer without the > entire message block processed. Depending on how the end user processes > this result buffer, errors vary from result buffer corruption to result > buffer poisoing. Fix this issue

Re: [Patch v2 2/6] clk: qcom: rpmh: Add CE clock on sdm845.

2020-11-24 Thread Stephen Boyd
Quoting Thara Gopinath (2020-11-19 07:52:29) > Qualcomm CE clock resource that is managed by BCM is required > by crypto driver to access the core clock. > > Reviewed-by: Bjorn Andersson > Signed-off-by: Thara Gopinath > --- Applied to clk-next

Re: [Patch v2 1/6] dt-bindings: clock: Add entry for crypto engine RPMH clock resource

2020-11-24 Thread Stephen Boyd
Quoting Thara Gopinath (2020-11-19 07:52:28) > Add clock id forc CE clock resource which is required to bring up the > crypto engine on sdm845. > > Reviewed-by: Bjorn Andersson > Signed-off-by: Thara Gopinath > --- Applied to clk-next

[PATCH] random: Use wait_event_freezable() in add_hwgenerator_randomness()

2019-09-05 Thread Stephen Boyd
stian Andrzej Siewior Tested-by: Sebastian Andrzej Siewior Cc: Keerthy Fixes: ff296293b353 ("random: Support freezable kthreads in add_hwgenerator_randomness()") Signed-off-by: Stephen Boyd --- See https://lkml.kernel.org/r/20190904110038.2bx25byitrejlteu@flow for context on the bug

Re: [PATCH] random: Support freezable kthreads in add_hwgenerator_randomness()

2019-09-05 Thread Stephen Boyd
Quoting Sebastian Andrzej Siewior (2019-09-05 00:41:52) > On 2019-09-04 11:49:57 [-0700], Stephen Boyd wrote: > > Can you try this? > > yes, works. > Cool thanks. I'll send a proper patch with your tested-by then? Alternatively this can be squashed into this previous p

Re: [PATCH] random: Support freezable kthreads in add_hwgenerator_randomness()

2019-09-04 Thread Stephen Boyd
Quoting Sebastian Andrzej Siewior (2019-09-04 04:00:38) > On 2019-08-22 15:55:19 [+1000], Herbert Xu wrote: > > Patch applied. Thanks. > [ ff296293b3538 ("random: Support freezable kthreads in > add_hwgenerator_randomness()") ] > > and since kthread_freezable_should_stop() has might_sleep() in i

[PATCH] random: Support freezable kthreads in add_hwgenerator_randomness()

2019-08-19 Thread Stephen Boyd
y: Keerthy Signed-off-by: Stephen Boyd --- Probably needs to go via Herbert who routed the patch this is fixing. drivers/char/random.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/char/random.c b/drivers/char/random.c index 5d5ea4ce1442..e2e85ca16410 100644 --

Re: [PATCH v3] hwrng: core: Freeze khwrng thread during suspend

2019-08-06 Thread Stephen Boyd
Quoting Stephen Boyd (2019-08-05 16:32:41) > The hwrng_fill() function can run while devices are suspending and > resuming. If the hwrng is behind a bus such as i2c or SPI and that bus > is suspended, the hwrng may hang the bus while attempting to add some > randomness. It's

[PATCH v3] hwrng: core: Freeze khwrng thread during suspend

2019-08-05 Thread Stephen Boyd
get into a bad state because the device is guaranteed to be resumed before the hwrng kthread is thawed. Cc: Andrey Pronin Cc: Duncan Laurie Cc: Jason Gunthorpe Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Guenter Roeck Cc: Alexander Steffen Signed-off-by: Stephen Boyd --- I'm splitt

[PATCH v6 05/57] crypto: Remove dev_err() usage after platform_get_irq()

2019-07-30 Thread Stephen Boyd
n Cc: Herbert Xu Cc: "David S. Miller" Cc: Signed-off-by: Stephen Boyd --- Please apply directly to subsystem trees drivers/crypto/atmel-aes.c | 1 - drivers/crypto/atmel-sha.c | 1 - drivers/crypto/atmel-tdes.c| 1 - drivers/crypto/ccree/cc_driver.c

Re: [PATCH 1/8] tpm: block messages while suspended

2019-07-16 Thread Stephen Boyd
Quoting Herbert Xu (2019-06-24 07:26:54) > On Thu, Jun 20, 2019 at 06:03:17PM -0700, Stephen Boyd wrote: > > > > What do you think of the attached patch? I haven't tested it, but it > > would make sure that the kthread is frozen so that the hardware can be > > resu

Re: [PATCH 1/8] tpm: block messages while suspended

2019-06-20 Thread Stephen Boyd
Quoting Jason Gunthorpe (2019-06-17 15:51:34) > On Fri, Jun 14, 2019 at 11:12:36AM -0700, Stephen Boyd wrote: > > Quoting Jason Gunthorpe (2019-06-13 16:26:13) > > > On Thu, Jun 13, 2019 at 11:09:24AM -0700, Stephen Boyd wrote: > > > > From: Andrey Pronin >

Re: [PATCH 2/6] clk: imx: vf610: Add CRC clock

2018-08-30 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2018-08-30 10:15:35) > Add the clock for CRC block allowing it to be enabled by HW CRC driver. > > Signed-off-by: Krzysztof Kozlowski > --- Acked-by: Stephen Boyd

Re: [PATCH 1/2] hwrng: msm: add a spinlock and support for blocking reads

2018-06-22 Thread Stephen Boyd
Quoting Timur Tabi (2018-06-22 08:41:11) > On 6/22/18 10:38 AM, Stanimir Varbanov wrote: > > Before entering into the read function we already hold a mutex which > > serializes data reading so I cannot imagine how below sequence could > > happen. Can you explain how to reproduce this race? > > > >

Re: [PATCH 1/2] hwrng: msm: add a spinlock and support for blocking reads

2018-06-21 Thread Stephen Boyd
Quoting Timur Tabi (2018-06-21 08:17:55) > @@ -96,11 +110,39 @@ static int msm_rng_read(struct hwrng *hwrng, void *data, > size_t max, bool wait) > > /* read random data from hardware */ > do { > - val = readl_relaxed(rng->base + PRNG_STATUS); > - if (

Re: [PATCH v2 2/2] hwrng: msm - Add support for prng v2

2018-06-21 Thread Stephen Boyd
Quoting Vinod (2018-06-20 06:37:25) > On 19-06-18, 22:58, Stephen Boyd wrote: > > Quoting Vinod Koul (2018-06-19 02:54:30) > > > Qcom 8996 and later chips support prng v2 which requires to > > > implement only .read callback for hwrng. > > > > > >

Re: [PATCH 1/3] clk: samsung: exynos4: Add SSS gate clock

2015-10-19 Thread Stephen Boyd
series that has dts changes I guess that means it should go through arm-soc: Acked-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-crypto&quo

Re: [PATCH v2 4/7] hwrng: st: Provide DT bindings for ST's Random Number Generator

2015-09-18 Thread Stephen Boyd
On 09/17/2015 06:45 AM, Lee Jones wrote: > Signed-off-by: Lee Jones > --- > Documentation/devicetree/bindings/rng/st,rng.txt | 15 +++ > 1 file changed, 15 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rng/st,rng.txt > > diff --git a/Documentation/devicetree/bi

Re: [PATCH 5/9] crypto: qce: Adds sha and hmac transforms

2014-04-11 Thread Stephen Boyd
On 04/10, Stanimir Varbanov wrote: > On 04/09/2014 03:09 AM, Stephen Boyd wrote: > > On 04/03, Stanimir Varbanov wrote: > > > >> + > >> + return 0; > >> +} > >> + > >> +static int qce_ahash_import(struct ahash_request *req,

Re: [PATCH 5/9] crypto: qce: Adds sha and hmac transforms

2014-04-08 Thread Stephen Boyd
On 04/03, Stanimir Varbanov wrote: > +static void qce_ahash_dma_done(void *data) > +{ > + struct crypto_async_request *async_req = data; > + struct ahash_request *req = ahash_request_cast(async_req); > + struct crypto_ahash *ahash = crypto_ahash_reqtfm(req); > + struct qce_sha_reqct