[PATCH] crypto: clear htmldocs build warnings for crypto/hash

2018-01-06 Thread Tobin C. Harding
ieves the resulting hash from the driver and pushes it back to upper layers. No data processing happens at this point unless hardware requires it to finish the transformation (then the data buffered by the device driver is processed). Signed-off-by: Tobin C. Harding --- This patch be

Re: [PATCH 3/3] staging: ccree: simplify ioread/iowrite

2017-11-06 Thread Tobin C. Harding
On Mon, Nov 06, 2017 at 04:46:54PM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 06, 2017 at 10:59:47AM +0200, Gilad Ben-Yossef wrote: > > On Mon, Nov 6, 2017 at 10:37 AM, Tobin C. Harding wrote: > > > On Mon, Nov 06, 2017 at 06:55:52AM +, Gilad Ben-Yossef wrote: >

Re: [PATCH 3/3] staging: ccree: simplify ioread/iowrite

2017-11-06 Thread Tobin C. Harding
On Mon, Nov 06, 2017 at 06:55:52AM +, Gilad Ben-Yossef wrote: > Registers ioread/iowrite operations were done via macros, > sometime using a "magical" implicit parameter. > > Replace all register access with simple inline macros. > > Signed-off-by: Gilad Ben-Yossef Hi, Nice work. I had a l

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-23 Thread Tobin C. Harding
On Mon, Oct 23, 2017 at 07:53:18AM -0700, Stephen Brennan wrote: > Simply break down some long lines and tab-indent them. Hi Stephen, Welcome to the Linux kernel. Great that you have put in a patch, you are, however, unlikely to see success fixing 'line over 80' warnings. There are a bunch of ar

Re: [PATCH v3] staging: ccree: fix boolreturn.cocci warning

2017-10-18 Thread Tobin C. Harding
*tfm) > { > - return 0; > + return false; > } > > #endif /* CRYPTO_TFM_REQ_HW_KEY */ > -- > 1.9.1 > For what it's worth, Reviewed-by: Tobin C. Harding As stated I am being particularly 'nit picky', the commit log is _probably_ good enough to

Re: [PATCH v2] staging: ccree: fix boolreturn.cocci warning

2017-10-17 Thread Tobin C. Harding
On Wed, Oct 18, 2017 at 07:42:53AM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > Return "false" instead of 0. > > This fixes the following coccinelle warning: > WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool. So close! The order of problem description and

Re: [PATCH v2] staging: ccree: Fix bool comparison

2017-10-17 Thread Tobin C. Harding
On Wed, Oct 18, 2017 at 07:40:14AM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > Comparision operator "equal to" not required on a variable > "foo" of type "bool". Bool has only two values, can be used > directly or with logical not. > > This fixes the following coccinelle warning

Re: [PATCH] staging: ccree: fix boolreturn.cocci warning

2017-10-16 Thread Tobin C. Harding
On Mon, Oct 16, 2017 at 03:39:57PM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > This fixes the following coccinelle warning: > WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool. Perhaps Coccinelle emits WARNING: return of 0/1 in function 'ssi_is_hw_key' wi

Re: [PATCH] staging: ccree: Fix bool comparison

2017-10-16 Thread Tobin C. Harding
On Mon, Oct 16, 2017 at 03:38:11PM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > Bool tests don't need comparisons. This commit log could be a bit longer. You may like to read Documentation/process/submitting-patches.rst (section 2). > This fixes the following coccinelle warning:

Re: [PATCH V2 00/27] Drivers: ccree - align block comments

2017-05-30 Thread Tobin C. Harding
On Tue, May 30, 2017 at 08:49:41AM +0200, Antoine Tenart wrote: > Hello Derek, > > On Tue, May 30, 2017 at 06:09:37PM +1200, Derek Robson wrote: > > Fixed block comments across whole ccree driver > > Since all these commits are doing the same logical change across a > single driver, you could pro

Re: [PATCH 01/27] Drivers: ccree: ssi_sysfs.h - align block comments

2017-05-24 Thread Tobin C. Harding
On Wed, May 24, 2017 at 04:40:32PM +1200, Derek Robson wrote: > Fixed block comment alignment, Style fix only > Found using checkpatch It's 'one thing per patch', this whole set does one thing. You may like to submit it as a single patch. You won't need the file name in the commit summary then als