Re: crypto: broken Kconfig option CRYPTO_NULL2

2015-08-19 Thread Valentin Rothberg
On Wed, Aug 19, 2015 at 9:52 AM, Herbert Xu wrote: > On Wed, Aug 19, 2015 at 09:49:37AM +0200, Valentin Rothberg wrote: >> >> your commit 149a39717dcc ("crypto: aead - Add type-safe geniv >> init/exit helpers") has shown up in Linux next (i.e., next-20150818) >&g

crypto: broken Kconfig option CRYPTO_NULL2

2015-08-19 Thread Valentin Rothberg
Hi Herbert, your commit 149a39717dcc ("crypto: aead - Add type-safe geniv init/exit helpers") has shown up in Linux next (i.e., next-20150818) adding the following lines of code to crypto/Kconfig: @@ -150,12 +152,15 @@ config CRYPTO_GF128MUL [...] +config CRYPTO_NULL2 + select CRYPTO_ALGAP

crypto: img-hash - undefined Kconfig symbols

2015-03-18 Thread Valentin Rothberg
Hi James, your commit d358f1abbf71 ("crypto: img-hash - Add Imagination Technologies hw hash accelerator") adds two selects on undefined Kconfig symbols, namely CRYPTO_ALG_API and CRYPTO_SHA224. The first symbols looks like a typo since there is an option CRYPTO_ALGAPI defined in crypto/Kconfig.

[PATCH] aesni-intel_glue.c: remove unnecessary #define

2014-10-21 Thread Valentin Rothberg
er, it's inconsistent with the rest of the ifdef blocks in the file, which directly reference Kconfig options. This patch removes 'HAS_PCBC' and replaces its occurrences with the actual dependency on 'CRYPTO_PCBC' being set as 'y' or 'm'. Signed-off-by: