Re: [PATCH 1/5] crypto: talitos - add hmac algorithms

2011-11-17 Thread Lee Nipper
On Wed, Nov 16, 2011 at 6:19 PM, Kim Phillips kim.phill...@freescale.com wrote: From: Lee Nipper lee.nip...@gmail.com Add these hmac algorithms to talitos:    hmac(md5),    hmac(sha1),    hmac(sha224),    hmac(sha256),    hmac(sha384),    hmac(sha512). These are all type ahash. Signed

Re: [PATCH 1/1] crypto: api.c: doc on crypto_alg_lookup, crypto_larval_lookup, and crypto_alg_mod_lookup

2010-11-05 Thread Lee Nipper
On Fri, Nov 5, 2010 at 13:05, Mark Allyn mark.a.al...@intel.com wrote: Resubmit due to errors on patch submitted 11/4/2010 Signed-off-by: Mark A. Allyn mark.a.al...@intel.com ---  crypto/api.c |   25 +  1 files changed, 25 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 1/1] crypto: api.c: doc on crypto_alg_lookup, crypto_larval_lookup, and crypto_alg_mod_lookup

2010-11-05 Thread Lee Nipper
On Fri, Nov 5, 2010 at 13:36, Allyn, Mark A mark.a.al...@intel.com wrote: Can you please explain what larval means in this context? I tried googling it an could not find anything meaningful. What is the difference between crypto_alg_lookup and crypto_larval_lookup? In the kernel crypto

Re: Crypto Fixes for 2.6.35

2010-07-23 Thread Lee Nipper
On Fri, Jul 23, 2010 at 02:27, Herbert Xu herb...@gondor.apana.org.au wrote: If it causes a crash or has other serious implications then I will push it.  However, if it simply results in a broken hash computation, a failure that should be fairly obvious, then it can wait til the next cycle.

Re: Crypto Fixes for 2.6.35

2010-07-22 Thread Lee Nipper
:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git Lee Nipper (1):      crypto: talitos - fix bug in sg_copy_end_to_buffer  drivers/crypto/talitos.c |    6 +-  1 files changed, 5 insertions(+), 1 deletions(-) Thanks Herbert. But I am curious why this patch http://www.mail-archive.com/linux

[PATCH v2] crypto: talitos - fix bug in sg_copy_end_to_buffer

2010-07-13 Thread Lee Nipper
In function sg_copy_end_to_buffer, too much data is copied when a segment in the scatterlist has .length greater than the requested copy length. This patch adds the limit checks to fix this bug of over copying, which affected only the ahash algorithms. Signed-off-by: Lee Nipper lee.nip

[PATCH] crypto: talitos - fix ahash for multiple of blocksize

2010-06-10 Thread Lee Nipper
Correct ahash_process_req() to properly handle cases where the total hash amount is a multiple of the blocksize. The SEC must have some data to hash during the very last descriptor operation; so up to one whole blocksize of data is buffered until the final hash. Signed-off-by: Lee Nipper lee.nip

Re: [PATCH] crypto: talitos - add support for sha224

2010-05-01 Thread Lee Nipper
and add support for all driver compatible devices. I like it. Signed-off by: Lee Nipper lee.nip...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCHv2 3/3] crypto: talitos - add hash algorithms

2010-04-30 Thread Lee Nipper
Add the following alorithms to talitos: md5, sha1, sha256, sha384, sha512. These are all type ahash. Signed-off-by: Lee Nipper lee.nip...@gmail.com --- This is v2 of this patch. It incorporates changes made after Kim's review. drivers/crypto/talitos.c | 544

Re: [PATCH 3/3] crypto: talitos - add hash algorithms

2010-04-30 Thread Lee Nipper
Kim Phillips wrote: On Wed, 28 Apr 2010 05:33:56 -0700 lee.nip...@gmail.com wrote: Add the following alorithms to talitos: md5, sha1, sha256, sha384, sha512. These are all type ahash. sha224 is left as an exercise for the reader, I see ;) Well, here's the story.

[PATCH 1/3] crypto: talitos - prepare for adding ahash algorithms

2010-04-28 Thread lee . nipper
No functional changes. Use a union in talitos_alg_template for the crypto_alg so that we can add a member later for ahash_alg. Signed-off-by: Lee Nipper lee.nip...@gmail.com --- drivers/crypto/talitos.c | 39 +-- 1 files changed, 21 insertions(+), 18

[PATCH 2/3] crypto: talitos - second prepare step for adding ahash algorithms

2010-04-28 Thread lee . nipper
Used talitos_alg_template in talitos_crypto_alg so that it will accommodate ahash algorithms. Added some preparation code for ahash allocation and removal. No actual algorithms yet. Signed-off-by: Lee Nipper lee.nip...@gmail.com --- drivers/crypto/talitos.c | 55

[PATCH][RFC] crypto: talitos - add hmac algorithms

2010-04-28 Thread lee . nipper
Add the these hmac algorithms to talitos: hmac(md5), hmac(sha1), hmac(sha256), hmac(sha384), hmac(sha512). These are all type ahash. Signed-off-by: Lee Nipper lee.nip...@gmail.com --- Currently on an 8349E, there's a problem with hmac for any talitos hmac sequence requiring

[PATCH 3/3] crypto: talitos - add hash algorithms

2010-04-28 Thread lee . nipper
Add the following alorithms to talitos: md5, sha1, sha256, sha384, sha512. These are all type ahash. Signed-off-by: Lee Nipper lee.nip...@gmail.com --- This patch series (3 of 3) applies against the kernel.org crypto tree at git://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH][RFC] crypto: talitos - add hmac algorithms

2010-04-28 Thread Lee Nipper
On Wed, Apr 28, 2010 at 07:33, lee.nip...@gmail.com wrote: Add the these hmac algorithms to talitos:    hmac(md5),    hmac(sha1),    hmac(sha256),    hmac(sha384),    hmac(sha512). These are all type ahash. This patch jumped in front of the 3rd patch in the series of 3 in the message

Re: [PATCH] crypto: talitos - protect against possible null ptr upon error

2009-03-24 Thread Lee Nipper
On Tue, Mar 24, 2009 at 16:23, Kim Phillips kim.phill...@freescale.com wrote: On Sun, 15 Mar 2009 20:21:47 -0500 Lee Nipper lee.nip...@gmail.com wrote: Added test for null descriptor returned from current_desc. Also removed the diagnostic from current_desc, and added one instead

Re: Talitos on MPC8548

2009-03-20 Thread Lee Nipper
On Thu, Mar 19, 2009, G.Muruganandam gmur...@gdatech.com wrote: I would like to get a pointer to start testing talitos on the MPC8548 board. I have linux kernel 2.6.27.18 running on the custom designed MPC8548 board. This is how I would approach it: 1) Look at the custom board's .dts file

[PATCH] crypto: talitos - protect against possible null ptr upon error

2009-03-15 Thread Lee Nipper
Added test for null descriptor returned from current_desc. Also removed the diagnostic from current_desc, and added one instead in talitos_error to report an EU error without finding the descriptor. Signed-off-by: Lee Nipper lee.nip...@gmail.com --- drivers/crypto/talitos.c | 14

[PATCH 3/3] crypto: talitos - Add ahash algorithms (1st cut, digest only)

2009-03-15 Thread Lee Nipper
This patch adds simple ahash algorithms for sha1, hmac(sha1), sha256, hmac(sha256), sha384, hmac(sha384), sha512. hmac(sha512). md5, hmac(md5). The implementation provides digest only, as the update and final functions are omitted. Signed-off-by: Lee Nipper lee.nip...@gmail.com --- drivers

[PATCH] crypto: ahash - fix ahash digest size

2009-02-18 Thread Lee Nipper
crypto_ahash_show changed to use cra_ahash for digestsize reference. Signed-off-by: Lee Nipper lee.nip...@freescale.com --- Makes digestsize for an ahash to be shown correctly. crypto/ahash.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/crypto/ahash.c b/crypto

[PATCH] crypto: talitos - ack done interrupt in isr instead of tasklet

2008-12-18 Thread Lee Nipper
for channel done processing that has actually already been completed by the tasklet prior to fielding a pending interrupt. Signed-off-by: Lee Nipper lee.nip...@freescale.com Signed-off-by: Kim Phillips kim.phill...@freescale.com --- This patch applies to git://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH 1/3] crypto: talitos - pass correct interrupt status to error handler

2008-10-13 Thread Lee Nipper
On Sun, 2008-10-12 at 05:34 -0700, Herbert Xu wrote: I've applied all three patches. However, I had to fix up the bits around INIT_LIST_HEAD in 1 and 3. So please check the cryptodev-2.6 tree and let me know if it's wrong. I checked cryptodev-2.6 and it looks good. Thank you! I thought I

[PATCH 2/3] crypto: talitos - done interrupt mitigation

2008-10-06 Thread Lee Nipper
is ack'ed, a few done overflows still occur. Signed-off-by: Lee Nipper [EMAIL PROTECTED] Signed-off-by: Kim Phillips [EMAIL PROTECTED] --- drivers/crypto/talitos.c | 30 ++ drivers/crypto/talitos.h |3 ++- 2 files changed, 24 insertions(+), 9 deletions(-) diff

[PATCH 3/3] crypto: talitos - perform auth check in h/w if on sec 2.1 and above

2008-10-06 Thread Lee Nipper
-by: Lee Nipper [EMAIL PROTECTED] --- drivers/crypto/talitos.c | 127 ++ drivers/crypto/talitos.h |8 +++ 2 files changed, 91 insertions(+), 44 deletions(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index 6ced894..ca4d36c

[PATCH] crypto: talitos - add handling for SEC 3.x treatment of link table

2008-07-29 Thread Lee Nipper
a decryption uses a link table to gather the fragments. This is observed by doing a ping with size of 1447 or larger with AES, or a ping with size 1455 or larger with 3des. So, add check for SEC compatible fsl,3.0 for using extra link table entry. Signed-off-by: Lee Nipper [EMAIL PROTECTED] Signed

[PATCH] crypto: talitos - add support for sha256 and md5 variants

2008-07-09 Thread Lee Nipper
This patch adds support for: authenc(hmac(sha256),cbc(aes)), authenc(hmac(sha256),cbc(des3_ede)), authenc(hmac(md5),cbc(aes)), authenc(hmac(md5),cbc(des3_ede)). Some constant usage was changed to use aes, des, and sha include files. Signed-off-by: Lee Nipper [EMAIL PROTECTED] --- This patch

[PATCH] [CRYPTO] talitos: Add support for 3des.

2008-07-02 Thread Lee Nipper
This patch adds support for authenc(hmac(sha1),cbc(des3_ede)) to the talitos crypto driver for the Freescale Security Engine. Some adjustments were made to the scatterlist to link table conversion to make 3des work for ping -s 1439..1446. Signed-off-by: Lee Nipper [EMAIL PROTECTED] --- This patch