Re: [BUGFIX 2/3] crypto: Remove CRYPTO_TFM_REQ_MAY_SLEEP flag in AES-NI accelerated ecb/cbc mode

2009-06-18 Thread Huang Ying
On Thu, 2009-06-18 at 19:40 +0800, Herbert Xu wrote: > On Mon, Jun 15, 2009 at 05:04:57PM +0800, Huang Ying wrote: > > Because AES-NI instructions will touch XMM state, corresponding code > > must be enclosed within kernel_fpu_begin/end, which used > > preempt_disable/enable. So sleep should be pre

Re: [BUGFIX 2/3] crypto: Remove CRYPTO_TFM_REQ_MAY_SLEEP flag in AES-NI accelerated ecb/cbc mode

2009-06-18 Thread Herbert Xu
On Mon, Jun 15, 2009 at 05:04:57PM +0800, Huang Ying wrote: > Because AES-NI instructions will touch XMM state, corresponding code > must be enclosed within kernel_fpu_begin/end, which used > preempt_disable/enable. So sleep should be prevented between > kernel_fpu_begin/end. > > Signed-off-by: Hu

[BUGFIX 2/3] crypto: Remove CRYPTO_TFM_REQ_MAY_SLEEP flag in AES-NI accelerated ecb/cbc mode

2009-06-15 Thread Huang Ying
Because AES-NI instructions will touch XMM state, corresponding code must be enclosed within kernel_fpu_begin/end, which used preempt_disable/enable. So sleep should be prevented between kernel_fpu_begin/end. Signed-off-by: Huang Ying --- arch/x86/crypto/aesni-intel_glue.c |4 1 file c