Re: [PATCH] crypto: aes - make assembler implementation default for i386 and x86-64

2012-06-20 Thread Jussi Kivilinna
Quoting Herbert Xu herb...@gondor.apana.org.au: On Tue, Jun 12, 2012 at 09:25:18PM +0300, Jussi Kivilinna wrote: Well, how about letting arch specific assembler implementations replace aes-generic completely.. in this case add depends on !X86 on CRYPTO_AES_GENERIC. Hardware modules get

Re: [PATCH] crypto: aes - make assembler implementation default for i386 and x86-64

2012-06-18 Thread Herbert Xu
On Tue, Jun 12, 2012 at 09:25:18PM +0300, Jussi Kivilinna wrote: Well, how about letting arch specific assembler implementations replace aes-generic completely.. in this case add depends on !X86 on CRYPTO_AES_GENERIC. Hardware modules get autoloaded (cpuid/pci/platform/etc) but generic

Re: [PATCH] crypto: aes - make assembler implementation default for i386 and x86-64

2012-06-12 Thread Herbert Xu
On Sat, Jun 09, 2012 at 05:50:55PM +0300, Jussi Kivilinna wrote: AES is often built-in and therefore implementations other than aes-generic don't get autoloaded by module-aliases. This is solved for aes-ni by cpuid autoloading, but for x86-64/i586 assembler implementation cpuid matching does