Re: [PATCH] crypto: algif - change algif_skcipher to be asynchronous

2015-01-25 Thread Herbert Xu
On Fri, Jan 23, 2015 at 02:40:56PM -0800, Tadeusz Struk wrote: Ok, It looks to me that we *do* have all we need to implement zero copy and AIO with algif_skcipher. The only thing we need to do is to add support for it in skcipher_recvmsg(). I think no change is required in neither

Re: [PATCH] crypto: algif - change algif_skcipher to be asynchronous

2015-01-23 Thread Tadeusz Struk
On 01/15/2015 06:00 PM, Herbert Xu wrote: But then would you like to extend AIO interface to take the IV and something that would indicate the encrypt/decrypt operation on aio_write()? Also as far as I can see AIO doesn't support splice() Any metadata such as the IV can still go through the

Re: [PATCH] crypto: algif - change algif_skcipher to be asynchronous

2015-01-15 Thread Herbert Xu
On Wed, Jan 14, 2015 at 09:36:57AM -0800, Tadeusz Struk wrote: But then would you like to extend AIO interface to take the IV and something that would indicate the encrypt/decrypt operation on aio_write()? Also as far as I can see AIO doesn't support splice() Any metadata such as the IV can

Re: [PATCH] crypto: algif - change algif_skcipher to be asynchronous

2015-01-14 Thread Tadeusz Struk
Hi Herbert, On 01/13/2015 09:38 PM, Herbert Xu wrote: What you want is AIO so we should try to use that interface rather than creating some funky crypto-specific interface. Dave, the AIO hooks in net/socket.c is currently simply pointing to the sync implementation. What are you thoughts on

Re: [PATCH] crypto: algif - change algif_skcipher to be asynchronous

2015-01-13 Thread Herbert Xu
On Tue, Jan 13, 2015 at 12:28:23PM -0800, Tadeusz Struk wrote: The way the algif_skcipher works currently is that on sendmsg/sendpage it builds an sgl for the input data and then on read/recvmsg it sends the job for encryption putting the user to sleep till the data is processed. This way it

[PATCH] crypto: algif - change algif_skcipher to be asynchronous

2015-01-13 Thread Tadeusz Struk
The way the algif_skcipher works currently is that on sendmsg/sendpage it builds an sgl for the input data and then on read/recvmsg it sends the job for encryption putting the user to sleep till the data is processed. This way it can only handle one job at a given time. This patch changes it to be