Re: [PATCH] crypto: ccp - Fix handling of RSA exponent on a v5 device

2016-11-17 Thread Herbert Xu
On Wed, Nov 16, 2016 at 11:25:19AM -0600, Gary R Hook wrote: > > The kernel crypto layer does not yet support RSA, true. However, we > designed the ccp.ko layer to be available to anyone that wants to use > it. The underlying module currently has differing behavior/results > between the v3 and v5

Re: [PATCH] crypto: ccp - Fix handling of RSA exponent on a v5 device

2016-11-17 Thread Gary R Hook
On 11/17/2016 07:14 AM, Herbert Xu wrote: On Wed, Nov 16, 2016 at 11:25:19AM -0600, Gary R Hook wrote: The kernel crypto layer does not yet support RSA, true. However, we designed the ccp.ko layer to be available to anyone that wants to use it. The underlying module currently has differing

Re: [PATCH] crypto: ccp - Fix handling of RSA exponent on a v5 device

2016-11-16 Thread Gary R Hook
On 11/16/2016 03:01 AM, Herbert Xu wrote: On Tue, Nov 15, 2016 at 03:41:25PM -0600, Gary R Hook wrote: On 11/13/2016 03:49 AM, Herbert Xu wrote: On Tue, Nov 01, 2016 at 02:05:05PM -0500, Gary R Hook wrote: The exponent size in the ccp_op structure is in bits. A v5 CCP requires the exponent

Re: [PATCH] crypto: ccp - Fix handling of RSA exponent on a v5 device

2016-11-16 Thread Herbert Xu
On Tue, Nov 15, 2016 at 03:41:25PM -0600, Gary R Hook wrote: > On 11/13/2016 03:49 AM, Herbert Xu wrote: > >On Tue, Nov 01, 2016 at 02:05:05PM -0500, Gary R Hook wrote: > >>The exponent size in the ccp_op structure is in bits. A v5 > >>CCP requires the exponent size to be in bytes, so convert >

Re: [PATCH] crypto: ccp - Fix handling of RSA exponent on a v5 device

2016-11-15 Thread Gary R Hook
On 11/13/2016 03:49 AM, Herbert Xu wrote: On Tue, Nov 01, 2016 at 02:05:05PM -0500, Gary R Hook wrote: The exponent size in the ccp_op structure is in bits. A v5 CCP requires the exponent size to be in bytes, so convert the size from bits to bytes when populating the descriptor. The current

Re: [PATCH] crypto: ccp - Fix handling of RSA exponent on a v5 device

2016-11-13 Thread Herbert Xu
On Tue, Nov 01, 2016 at 02:05:05PM -0500, Gary R Hook wrote: > The exponent size in the ccp_op structure is in bits. A v5 > CCP requires the exponent size to be in bytes, so convert > the size from bits to bytes when populating the descriptor. > > The current code references the exponent in

[PATCH] crypto: ccp - Fix handling of RSA exponent on a v5 device

2016-11-01 Thread Gary R Hook
The exponent size in the ccp_op structure is in bits. A v5 CCP requires the exponent size to be in bytes, so convert the size from bits to bytes when populating the descriptor. The current code references the exponent in memory, but these fields have not been set since the exponent is actually