Re: [PATCH] crypto: fix AEAD tag memory handling

2016-11-09 Thread Mat Martineau
Stephan, On Wed, 9 Nov 2016, Stephan Mueller wrote: Am Montag, 31. Oktober 2016, 16:18:32 CET schrieb Mat Martineau: Hi Mat, My main concern is getting the semantics correct and consistent in a single patch series. It would be a big problem to explain that AF_ALG AEAD read and write works o

Re: [PATCH] crypto: fix AEAD tag memory handling

2016-11-09 Thread Stephan Mueller
Am Montag, 31. Oktober 2016, 16:18:32 CET schrieb Mat Martineau: Hi Mat, > > My main concern is getting the semantics correct and consistent in a > single patch series. It would be a big problem to explain that AF_ALG AEAD > read and write works one way in 4.x, another way in 4.y, and some > diff

Re: [PATCH] crypto: fix AEAD tag memory handling

2016-11-01 Thread Stephan Mueller
Am Montag, 31. Oktober 2016, 16:18:32 CET schrieb Mat Martineau: Hi Mat, > My main concern is getting the semantics correct and consistent in a > single patch series. It would be a big problem to explain that AF_ALG AEAD > read and write works one way in 4.x, another way in 4.y, and some > differ

Re: [PATCH] crypto: fix AEAD tag memory handling

2016-10-31 Thread Mat Martineau
Hi Stephan - On Mon, 31 Oct 2016, Stephan Mueller wrote: Am Freitag, 28. Oktober 2016, 15:21:19 CET schrieb Mat Martineau: Hi Mat, Please check the current patch (the one I sent to you as a pre-release did not contain the fix for the decryption part -- the patch sent to the list and what we

Re: [PATCH] crypto: fix AEAD tag memory handling

2016-10-31 Thread Stephan Mueller
Am Freitag, 28. Oktober 2016, 15:21:19 CET schrieb Mat Martineau: Hi Mat, > > > > Please check the current patch (the one I sent to you as a pre-release did > > not contain the fix for the decryption part -- the patch sent to the list > > and what we discuss here contains the appropriate handling

Re: [PATCH] crypto: fix AEAD tag memory handling

2016-10-28 Thread Mat Martineau
Stephan, On Fri, 28 Oct 2016, Stephan Mueller wrote: Am Donnerstag, 27. Oktober 2016, 14:42:14 CEST schrieb Mat Martineau: Hi Mat, Stephan and Herbert, On Thu, 27 Oct 2016, Stephan Mueller wrote: Hi Herbert, for this patch, I have updated the testing for libkcapi accordingly and all test

Re: [PATCH] crypto: fix AEAD tag memory handling

2016-10-27 Thread Stephan Mueller
Am Donnerstag, 27. Oktober 2016, 14:42:14 CEST schrieb Mat Martineau: Hi Mat, > Stephan and Herbert, > > On Thu, 27 Oct 2016, Stephan Mueller wrote: > > Hi Herbert, > > > > for this patch, I have updated the testing for libkcapi accordingly and > > all > > tests pass. I will push the libkcapi c

Re: [PATCH] crypto: fix AEAD tag memory handling

2016-10-27 Thread Mat Martineau
Stephan and Herbert, On Thu, 27 Oct 2016, Stephan Mueller wrote: Hi Herbert, for this patch, I have updated the testing for libkcapi accordingly and all tests pass. I will push the libkcapi code 0.12 with that test code change out shortly. Using the current upstream version of 0.11.1 will sho

[PATCH] crypto: fix AEAD tag memory handling

2016-10-26 Thread Stephan Mueller
Hi Herbert, for this patch, I have updated the testing for libkcapi accordingly and all tests pass. I will push the libkcapi code 0.12 with that test code change out shortly. Using the current upstream version of 0.11.1 will show failures as it expects the correct recv return code. As stated below