Re: [PATCH] crypto: marvell/cesa - Fix DMA API misuse

2018-01-18 Thread Herbert Xu
On Wed, Jan 10, 2018 at 03:15:43PM +, Robin Murphy wrote: > phys_to_dma() is an internal helper for certain DMA API implementations, > and is not appropriate for drivers to use. It appears that what the CESA > driver really wants to be using is dma_map_resource() - admittedly that > didn't exis

Re: [PATCH] crypto: marvell/cesa - Fix DMA API misuse

2018-01-10 Thread Boris Brezillon
Hi Christoph, On Wed, 10 Jan 2018 16:48:17 +0100 Christoph Hellwig wrote: > On Wed, Jan 10, 2018 at 04:25:22PM +0100, Boris Brezillon wrote: > > On Wed, 10 Jan 2018 15:15:43 + > > Robin Murphy wrote: > > > > > phys_to_dma() is an internal helper for certain DMA API implementations, > > >

Re: [PATCH] crypto: marvell/cesa - Fix DMA API misuse

2018-01-10 Thread Christoph Hellwig
On Wed, Jan 10, 2018 at 04:25:22PM +0100, Boris Brezillon wrote: > On Wed, 10 Jan 2018 15:15:43 + > Robin Murphy wrote: > > > phys_to_dma() is an internal helper for certain DMA API implementations, > > and is not appropriate for drivers to use. It appears that what the CESA > > driver really

Re: [PATCH] crypto: marvell/cesa - Fix DMA API misuse

2018-01-10 Thread Boris Brezillon
On Wed, 10 Jan 2018 15:15:43 + Robin Murphy wrote: > phys_to_dma() is an internal helper for certain DMA API implementations, > and is not appropriate for drivers to use. It appears that what the CESA > driver really wants to be using is dma_map_resource() - admittedly that > didn't exist whe

[PATCH] crypto: marvell/cesa - Fix DMA API misuse

2018-01-10 Thread Robin Murphy
phys_to_dma() is an internal helper for certain DMA API implementations, and is not appropriate for drivers to use. It appears that what the CESA driver really wants to be using is dma_map_resource() - admittedly that didn't exist when the offending code was first merged, but it does now. Signed-o