Re: [PATCH] crypto: sahara - Fix misuse of IS_ENABLED

2015-08-10 Thread Axel Lin
2015-08-10 15:32 GMT+08:00 Herbert Xu : > On Mon, Aug 10, 2015 at 03:18:36PM +0800, Axel Lin wrote: >> IS_ENABLED should only be used for CONFIG_* symbols. >> So use #ifdef DEBUG instead. >> >> Signed-off-by: Axel Lin > > Nack. While the abuse is certainly wrong you're removing compiler > coverag

Re: [PATCH] crypto: sahara - Fix misuse of IS_ENABLED

2015-08-10 Thread Herbert Xu
On Mon, Aug 10, 2015 at 03:18:36PM +0800, Axel Lin wrote: > IS_ENABLED should only be used for CONFIG_* symbols. > So use #ifdef DEBUG instead. > > Signed-off-by: Axel Lin Nack. While the abuse is certainly wrong you're removing compiler coverage over code which is worse. PLease find a way to

[PATCH] crypto: sahara - Fix misuse of IS_ENABLED

2015-08-10 Thread Axel Lin
IS_ENABLED should only be used for CONFIG_* symbols. So use #ifdef DEBUG instead. Signed-off-by: Axel Lin --- drivers/crypto/sahara.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c index 397a500b..b2661a5 1006