Re: [PATCH] crypto: user - prevent operating on larval algorithms

2019-07-03 Thread Michal Suchánek
On Wed, 3 Jul 2019 13:31:29 -0700 Eric Biggers wrote: > Hi Michal, > > On Wed, Jul 03, 2019 at 10:21:08PM +0200, Michal Suchánek wrote: > > On Wed, 3 Jul 2019 22:30:57 +0800 > > Herbert Xu wrote: > > > > > On Tue, Jul 02, 2019 at 02:17:00PM -0700, Eric Biggers wrote: > > > > From: Eric Big

Re: [PATCH] crypto: user - prevent operating on larval algorithms

2019-07-03 Thread Eric Biggers
Hi Michal, On Wed, Jul 03, 2019 at 10:21:08PM +0200, Michal Suchánek wrote: > On Wed, 3 Jul 2019 22:30:57 +0800 > Herbert Xu wrote: > > > On Tue, Jul 02, 2019 at 02:17:00PM -0700, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > Michal Suchanek reported [1] that running the pcrypt_aead

Re: [PATCH] crypto: user - prevent operating on larval algorithms

2019-07-03 Thread Michal Suchánek
On Wed, 3 Jul 2019 22:30:57 +0800 Herbert Xu wrote: > On Tue, Jul 02, 2019 at 02:17:00PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > Michal Suchanek reported [1] that running the pcrypt_aead01 test from > > LTP [2] in a loop and holding Ctrl-C causes a NULL dereference of > > alg-

Re: [PATCH] crypto: user - prevent operating on larval algorithms

2019-07-03 Thread Herbert Xu
On Tue, Jul 02, 2019 at 02:17:00PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Michal Suchanek reported [1] that running the pcrypt_aead01 test from > LTP [2] in a loop and holding Ctrl-C causes a NULL dereference of > alg->cra_users.next in crypto_remove_spawns(), via crypto_del_alg(). >

[PATCH] crypto: user - prevent operating on larval algorithms

2019-07-02 Thread Eric Biggers
From: Eric Biggers Michal Suchanek reported [1] that running the pcrypt_aead01 test from LTP [2] in a loop and holding Ctrl-C causes a NULL dereference of alg->cra_users.next in crypto_remove_spawns(), via crypto_del_alg(). The test repeatedly uses CRYPTO_MSG_NEWALG and CRYPTO_MSG_DELALG. The cr