Re: [PATCH] eCryptfs: Clean up crypto initialization

2016-01-26 Thread Tyler Hicks
[fixed mhalcrow's email address] Hi Dan - thanks for the alert. I think the code is fine in this situation. On 2016-01-25 17:23:11, Dan Carpenter wrote: > Hello Michael Halcrow, > > The patch e5d9cbde6ce0: "[PATCH] eCryptfs: Clean up crypto > initialization" fr

re: [PATCH] eCryptfs: Clean up crypto initialization

2016-01-25 Thread Dan Carpenter
Hello Michael Halcrow, The patch e5d9cbde6ce0: "[PATCH] eCryptfs: Clean up crypto initialization" from Oct 30, 2006, leads to the following static checker warning: fs/ecryptfs/crypto.c:1625 ecryptfs_process_key_cipher() error: get_random_bytes() 'dummy_key' too sm