Re: [PATCH] omap-crypto - fix kernel oops and output buffer update

2018-03-30 Thread Herbert Xu
Francis Le Bourse wrote: > Hi Tero, > >> I have a couple of additional comments, but can't add them as the patch >> content is an attachment (like, I would not add the WARN_ON.) Overall, >> the issue you have found is a legitimate problem, and should be fixed. > > I have used WARN_ON() to have s

RE: [PATCH] omap-crypto - fix kernel oops and output buffer update

2018-03-27 Thread Francis Le Bourse
Hi Tero, > I have a couple of additional comments, but can't add them as the patch > content is an attachment (like, I would not add the WARN_ON.) Overall, > the issue you have found is a legitimate problem, and should be fixed. I have used WARN_ON() to have some very visible output, I agree it i

Re: [PATCH] omap-crypto - fix kernel oops and output buffer update

2018-03-23 Thread Tero Kristo
On 23/03/18 15:50, Tero Kristo wrote: Hi Francis, Your email program is still messing up things, the patch was sent as a multipart message. Use git-send-email tool or something similar if possible. Also, there are at least two checkpatch issues (run scripts/checkpatch.pl -strict ), in addit

Re: [PATCH] omap-crypto - fix kernel oops and output buffer update

2018-03-23 Thread Tero Kristo
Hi Francis, Your email program is still messing up things, the patch was sent as a multipart message. Use git-send-email tool or something similar if possible. Also, there are at least two checkpatch issues (run scripts/checkpatch.pl -strict ), in addition to the UTF-8 formatted message cont

[PATCH] omap-crypto - fix kernel oops and output buffer update

2018-03-22 Thread Francis Le Bourse
Hello, In omap_crypto_cleanup(),:     if (orig && (flags & OMAP_CRYPTO_COPY_MASK))         scatterwalk_map_and_copy(buf, orig, offset, len, 1); implies that scatterwalk_map_and_copy() is called if flag is set to OMAP_CRYPTO_SG_COPIED. If the output buffer crosses a page boundary, the seco