[PATCH] omap-rng: Change RNG_CONFIG_REG to RNG_CONTROL_REG when checking and disabling TRNG

2015-03-10 Thread Andre Wolokita
In omap4_rng_init(), a check of bit 10 of the RNG_CONFIG_REG is done to determine whether the RNG is running. This is suspicious firstly due to the use of RNG_CONTROL_ENABLE_TRNG_MASK and secondly because the same mask is written to RNG_CONTROL_REG after configuration of the FROs. Similar suspicio

[PATCH] omap-rng: Change RNG_CONFIG_REG to RNG_CONTROL_REG when checking and disabling TRNG

2015-03-15 Thread Andre Wolokita
In omap4_rng_init(), a check of bit 10 of the RNG_CONFIG_REG is done to determine whether the RNG is running. This is suspicious firstly due to the use of RNG_CONTROL_ENABLE_TRNG_MASK and secondly because the same mask is written to RNG_CONTROL_REG after configuration of the FROs. Similar suspicio

Re: [PATCH] omap-rng: Change RNG_CONFIG_REG to RNG_CONTROL_REG when checking and disabling TRNG

2015-03-13 Thread Herbert Xu
On Wed, Mar 11, 2015 at 03:29:35PM +1100, Andre Wolokita wrote: > In omap4_rng_init(), a check of bit 10 of the RNG_CONFIG_REG is done to > determine > whether the RNG is running. This is suspicious firstly due to the use of > RNG_CONTROL_ENABLE_TRNG_MASK and secondly because the same mask is writ

Re: [PATCH] omap-rng: Change RNG_CONFIG_REG to RNG_CONTROL_REG when checking and disabling TRNG

2015-03-17 Thread Herbert Xu
On Mon, Mar 16, 2015 at 10:19:11AM +1100, Andre Wolokita wrote: > In omap4_rng_init(), a check of bit 10 of the RNG_CONFIG_REG is done to > determine > whether the RNG is running. This is suspicious firstly due to the use of > RNG_CONTROL_ENABLE_TRNG_MASK and secondly because the same mask is writ